From: Jacob Keller <jacob.e.keller@intel.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
Realtek linux nic maintainers <nic_swsd@realtek.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/3] net: add macro netif_subqueue_completed_wake
Date: Thu, 13 Apr 2023 12:22:09 -0700 [thread overview]
Message-ID: <4d9c854f-16c7-66e4-34d0-498147d0acdf@intel.com> (raw)
In-Reply-To: <16e51984-a539-24d4-a2d6-604c0b75f14b@gmail.com>
On 4/13/2023 12:14 PM, Heiner Kallweit wrote:
> Add netif_subqueue_completed_wake, complementing the subqueue versions
> netif_subqueue_try_stop and netif_subqueue_maybe_stop.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> include/net/netdev_queues.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/net/netdev_queues.h b/include/net/netdev_queues.h
> index b26fdb441..d68b0a483 100644
> --- a/include/net/netdev_queues.h
> +++ b/include/net/netdev_queues.h
> @@ -160,4 +160,14 @@ netdev_txq_completed_mb(struct netdev_queue *dev_queue,
> netif_txq_maybe_stop(txq, get_desc, stop_thrs, start_thrs); \
> })
>
> +#define netif_subqueue_completed_wake(dev, idx, pkts, bytes, \
> + get_desc, start_thrs) \
> + ({ \
> + struct netdev_queue *txq; \
> + \
> + txq = netdev_get_tx_queue(dev, idx); \
> + netif_txq_completed_wake(txq, pkts, bytes, \
> + get_desc, start_thrs); \
> + })
> +
> #endif
next prev parent reply other threads:[~2023-04-13 19:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 19:13 [PATCH net-next 0/3] r8169: use new macros from netdev_queues.h Heiner Kallweit
2023-04-13 19:14 ` [PATCH net-next 1/3] net: add macro netif_subqueue_completed_wake Heiner Kallweit
2023-04-13 19:22 ` Jacob Keller [this message]
2023-04-13 19:15 ` [PATCH net-next 2/3] r8169: use new macro netif_subqueue_maybe_stop in rtl8169_start_xmit Heiner Kallweit
2023-04-13 19:24 ` Jacob Keller
2023-04-15 1:53 ` Jakub Kicinski
2023-04-15 7:14 ` Heiner Kallweit
2023-04-13 19:16 ` [PATCH net-next 3/3] r8169: use new macro netif_subqueue_completed_wake in the tx cleanup path Heiner Kallweit
2023-04-13 19:25 ` Jacob Keller
2023-04-13 19:36 ` Heiner Kallweit
2023-04-13 21:04 ` Jacob Keller
2023-04-13 19:17 ` [PATCH net-next 0/3] r8169: use new macros from netdev_queues.h Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d9c854f-16c7-66e4-34d0-498147d0acdf@intel.com \
--to=jacob.e.keller@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.