From: Florian Fainelli <f.fainelli@gmail.com>
To: Pierre Gondois <pierre.gondois@arm.com>, linux-kernel@vger.kernel.org
Cc: Radu Rendec <rrendec@redhat.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>,
Conor Dooley <conor.dooley@microchip.com>,
Will Deacon <will@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Palmer Dabbelt <palmer@rivosinc.com>,
Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH v3 2/4] cacheinfo: Check cache properties are present in DT
Date: Thu, 13 Apr 2023 11:16:37 -0700 [thread overview]
Message-ID: <4da53918-839b-4d28-0634-66fd7f38c8bd@gmail.com> (raw)
In-Reply-To: <20230413091436.230134-3-pierre.gondois@arm.com>
On 4/13/23 02:14, Pierre Gondois wrote:
> If a Device Tree (DT) is used, the presence of cache properties is
> assumed. Not finding any is not considered. For arm64 platforms,
> cache information can be fetched from the clidr_el1 register.
> Checking whether cache information is available in the DT
> allows to switch to using clidr_el1.
>
> init_of_cache_level()
> \-of_count_cache_leaves()
> will assume there a 2 cache leaves (L1 data/instruction caches), which
> can be different from clidr_el1 information.
>
> cache_setup_of_node() tries to read cache properties in the DT.
> If there are none, this is considered a success. Knowing no
> information was available would allow to switch to using clidr_el1.
>
> Fixes: de0df442ee49 ("cacheinfo: Check 'cache-unified' property to count cache leaves")
> Reported-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> Link: https://lore.kernel.org/all/20230404-hatred-swimmer-6fecdf33b57a@spud/
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
Humm, it would appear that the cache levels and topology is still
provided, despite the lack of cache properties in the Device Tree which
is intended by this patch set however we lost the size/ways/sets
information, could we not complement the missing properties here?
If this is out of the scope of what you are doing:
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Before:
# lscpu -C
NAME ONE-SIZE ALL-SIZE WAYS TYPE LEVEL SETS PHY-LINE COHERENCY-SIZE
L1d 32K 128K 4 Data 1 128 64
L1i 32K 128K 2 Instruction 1 256 64
L2 512K 512K 16 Unified 2 512 64
After:
# lscpu -C
NAME ONE-SIZE ALL-SIZE WAYS TYPE LEVEL SETS PHY-LINE COHERENCY-SIZE
L1d Data 1
L1i Instruction 1
L2 Unified 2
--
Florian
next prev parent reply other threads:[~2023-04-13 18:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 9:14 [PATCH v3 0/4] cacheinfo: Correctly fallback to using clidr_el1's information Pierre Gondois
2023-04-13 9:14 ` [PATCH v3 1/4] cacheinfo: Check sib_leaf in cache_leaves_are_shared() Pierre Gondois
2023-04-13 10:04 ` Conor Dooley
2023-04-13 9:14 ` [PATCH v3 2/4] cacheinfo: Check cache properties are present in DT Pierre Gondois
2023-04-13 10:06 ` Conor Dooley
2023-04-13 18:16 ` Florian Fainelli [this message]
2023-04-13 19:50 ` Sudeep Holla
2023-04-13 20:06 ` Florian Fainelli
2023-04-14 7:33 ` Pierre Gondois
2023-04-14 9:05 ` Sudeep Holla
2023-04-14 22:21 ` Florian Fainelli
2023-04-14 8:19 ` Pierre Gondois
2023-04-13 9:14 ` [PATCH v3 3/4] arch_topology: Remove early cacheinfo error message Pierre Gondois
2023-04-13 10:02 ` Conor Dooley
2023-04-13 10:25 ` Conor Dooley
2023-04-13 15:25 ` Pierre Gondois
2023-04-13 16:23 ` Conor Dooley
2023-04-13 9:14 ` [PATCH v3 4/4] cacheinfo: Add use_arch[|_cache]_info field/function Pierre Gondois
2023-04-13 9:49 ` Sudeep Holla
2023-04-13 10:17 ` Pierre Gondois
2023-04-13 10:20 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4da53918-839b-4d28-0634-66fd7f38c8bd@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexghiti@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=gshan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=palmer@rivosinc.com \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=rrendec@redhat.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.