From: Andrew Rybchenko <arybchenko@solarflare.com>
To: santosh <santosh.shukla@caviumnetworks.com>, <dev@dpdk.org>
Cc: Olivier MATZ <olivier.matz@6wind.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v1 0/9] mempool: prepare to add bucket driver
Date: Wed, 14 Mar 2018 18:57:34 +0300 [thread overview]
Message-ID: <4dae318c-ce21-185a-a6eb-3f193aae2ae9@solarflare.com> (raw)
In-Reply-To: <317a928a-f8de-13da-74bd-28fa0b5234b9@caviumnetworks.com>
Hi Santosh,
On 03/14/2018 06:49 PM, santosh wrote:
> Hi Andrew,
>
>
> On Saturday 10 March 2018 09:09 PM, Andrew Rybchenko wrote:
>
> [...]
>
>> RFCv1 -> RFCv2:
>> - add driver ops to calculate required memory size and populate
>> mempool objects, remove extra flags which were required before
>> to control it
>> - transition of octeontx and dpaa drivers to the new callbacks
>> - change info API to get information from driver required to
>> API user to know contiguous block size
>> - remove get_capabilities (not required any more and may be
>> substituted with more in info get API)
>> - remove register_memory_area since it is substituted with
>> populate callback which can do more
>> - use SPDX tags
>> - avoid all objects affinity to single lcore
>> - fix bucket get_count
>> - deprecate XMEM API
>> - avoid introduction of a new function to flush cache
>> - fix NO_CACHE_ALIGN case in bucket mempool
> I'm evaluating your series in octeontx platform.
> Noticed a build break for dpaa platform:
> CC dpaa_mempool.o
> /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c: In function ‘dpaa_populate’:
> /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c:291:41: error: passing argument 1 of ‘rte_mempool_op_populate_default’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
> return rte_mempool_op_populate_default(mp, max_objs, vaddr, paddr, len,
> ^
> In file included from /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.h:15:0,
> from /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c:28:
> /home/ubuntu/83xx/dpdk/build/include/rte_mempool.h:490:5: note: expected ‘struct rte_mempool *’ but argument is of type ‘const struct rte_mempool *’
> int rte_mempool_op_populate_default(struct rte_mempool *mp,
> ^
> /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c: At top level:
> /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c:303:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> .populate = dpaa_populate,
> ^
> /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c:303:14: note: (near initialization for ‘dpaa_mpool_ops.populate’)
> cc1: all warnings being treated as errors
Yes, my bad, const should be simply removed to match prototype (and
mempool is actually modified since it is populated). Will fix.
Many thank,
Andrew.
next prev parent reply other threads:[~2018-03-14 15:57 UTC|newest]
Thread overview: 197+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 16:06 [RFC PATCH 0/6] mempool: add bucket mempool driver Andrew Rybchenko
2017-11-24 16:06 ` [RFC PATCH 1/6] mempool: implement abstract mempool info API Andrew Rybchenko
2017-12-14 13:36 ` Olivier MATZ
2018-01-17 15:03 ` Andrew Rybchenko
2017-11-24 16:06 ` [RFC PATCH 2/6] mempool: implement clustered object allocation Andrew Rybchenko
2017-12-14 13:37 ` Olivier MATZ
2018-01-17 15:03 ` Andrew Rybchenko
2018-01-17 15:55 ` santosh
2018-01-17 16:37 ` Andrew Rybchenko
2017-11-24 16:06 ` [RFC PATCH 3/6] mempool/bucket: implement bucket mempool manager Andrew Rybchenko
2017-12-14 13:38 ` Olivier MATZ
2018-01-17 15:06 ` Andrew Rybchenko
2017-11-24 16:06 ` [RFC PATCH 4/6] mempool: add a function to flush default cache Andrew Rybchenko
2017-12-14 13:38 ` Olivier MATZ
2018-01-17 15:07 ` Andrew Rybchenko
2017-11-24 16:06 ` [RFC PATCH 5/6] mempool: support block dequeue operation Andrew Rybchenko
2017-12-14 13:38 ` Olivier MATZ
2017-11-24 16:06 ` [RFC PATCH 6/6] mempool/bucket: implement " Andrew Rybchenko
2017-12-14 13:36 ` [RFC PATCH 0/6] mempool: add bucket mempool driver Olivier MATZ
2018-01-17 15:03 ` Andrew Rybchenko
2018-01-23 13:15 ` [RFC v2 00/17] " Andrew Rybchenko
2018-01-23 13:15 ` [RFC v2 01/17] mempool: fix phys contig check if populate default skipped Andrew Rybchenko
2018-01-31 16:45 ` Olivier Matz
2018-02-01 5:05 ` santosh
2018-02-01 6:54 ` Andrew Rybchenko
2018-02-01 9:09 ` santosh
2018-02-01 9:18 ` Andrew Rybchenko
2018-02-01 9:30 ` santosh
2018-02-01 10:00 ` Andrew Rybchenko
2018-02-01 10:14 ` Olivier Matz
2018-02-01 10:33 ` santosh
2018-02-01 14:02 ` Andrew Rybchenko
2018-02-01 10:17 ` santosh
2018-02-01 14:02 ` [PATCH] " Andrew Rybchenko
2018-02-05 23:53 ` [dpdk-stable] " Thomas Monjalon
2018-01-23 13:15 ` [RFC v2 02/17] mempool: add op to calculate memory size to be allocated Andrew Rybchenko
2018-01-31 16:45 ` Olivier Matz
2018-02-01 7:15 ` Andrew Rybchenko
2018-01-23 13:15 ` [RFC v2 03/17] mempool/octeontx: add callback to calculate memory size Andrew Rybchenko
[not found] ` <BN3PR07MB2513732462EB5FE5E1B05713E3FA0@BN3PR07MB2513.namprd07.prod.outlook.com>
2018-02-01 10:01 ` santosh
2018-02-01 13:40 ` santosh
2018-03-10 15:49 ` Andrew Rybchenko
2018-03-11 6:31 ` santosh
2018-01-23 13:15 ` [RFC v2 04/17] mempool: add op to populate objects using provided memory Andrew Rybchenko
2018-01-31 16:45 ` Olivier Matz
2018-02-01 8:51 ` Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 05/17] mempool/octeontx: implement callback to populate objects Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 06/17] mempool: remove callback to get capabilities Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 07/17] mempool: deprecate xmem functions Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 08/17] mempool/octeontx: prepare to remove register memory area op Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 09/17] mempool/dpaa: convert to use populate driver op Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 10/17] mempool: remove callback to register memory area Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 11/17] mempool: ensure the mempool is initialized before populating Andrew Rybchenko
2018-01-31 16:45 ` Olivier Matz
2018-02-01 8:53 ` Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 12/17] mempool/bucket: implement bucket mempool manager Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 13/17] mempool: support flushing the default cache of the mempool Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 14/17] mempool: implement abstract mempool info API Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 15/17] mempool: support block dequeue operation Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 16/17] mempool/bucket: implement " Andrew Rybchenko
2018-01-23 13:16 ` [RFC v2 17/17] mempool/bucket: do not allow one lcore to grab all buckets Andrew Rybchenko
2018-01-31 16:44 ` [RFC v2 00/17] mempool: add bucket mempool driver Olivier Matz
2018-03-10 15:39 ` [PATCH v1 0/9] mempool: prepare to add bucket driver Andrew Rybchenko
2018-03-10 15:39 ` [PATCH v1 1/9] mempool: add op to calculate memory size to be allocated Andrew Rybchenko
2018-03-11 12:51 ` santosh
2018-03-12 6:53 ` Andrew Rybchenko
2018-03-19 17:03 ` Olivier Matz
2018-03-20 10:29 ` Andrew Rybchenko
2018-03-20 14:41 ` Bruce Richardson
2018-03-10 15:39 ` [PATCH v1 2/9] mempool: add op to populate objects using provided memory Andrew Rybchenko
2018-03-19 17:04 ` Olivier Matz
2018-03-21 7:05 ` Andrew Rybchenko
2018-03-10 15:39 ` [PATCH v1 3/9] mempool: remove callback to get capabilities Andrew Rybchenko
2018-03-14 14:40 ` Burakov, Anatoly
2018-03-14 16:12 ` Andrew Rybchenko
2018-03-14 16:53 ` Burakov, Anatoly
2018-03-14 17:24 ` Andrew Rybchenko
2018-03-15 9:48 ` Burakov, Anatoly
2018-03-15 11:49 ` Andrew Rybchenko
2018-03-15 12:00 ` Burakov, Anatoly
2018-03-15 12:44 ` Andrew Rybchenko
2018-03-19 17:05 ` Olivier Matz
2018-03-19 17:06 ` Olivier Matz
2018-03-10 15:39 ` [PATCH v1 4/9] mempool: deprecate xmem functions Andrew Rybchenko
2018-03-10 15:39 ` [PATCH v1 5/9] mempool/octeontx: prepare to remove register memory area op Andrew Rybchenko
2018-03-10 15:39 ` [PATCH v1 6/9] mempool/dpaa: " Andrew Rybchenko
2018-03-10 15:39 ` [PATCH v1 7/9] mempool: remove callback to register memory area Andrew Rybchenko
2018-03-10 15:39 ` [PATCH v1 8/9] mempool: ensure the mempool is initialized before populating Andrew Rybchenko
2018-03-19 17:06 ` Olivier Matz
2018-03-20 13:32 ` Andrew Rybchenko
2018-03-20 16:57 ` Olivier Matz
2018-03-10 15:39 ` [PATCH v1 9/9] mempool: support flushing the default cache of the mempool Andrew Rybchenko
2018-03-14 15:49 ` [PATCH v1 0/9] mempool: prepare to add bucket driver santosh
2018-03-14 15:57 ` Andrew Rybchenko [this message]
2018-03-19 17:03 ` Olivier Matz
2018-03-20 10:09 ` Andrew Rybchenko
2018-03-20 11:04 ` Thomas Monjalon
2018-03-25 16:20 ` [PATCH v2 00/11] " Andrew Rybchenko
2018-03-25 16:20 ` [PATCH v2 01/11] mempool: fix memhdr leak when no objects are populated Andrew Rybchenko
2018-03-25 16:20 ` [PATCH v2 02/11] mempool: rename flag to control IOVA-contiguous objects Andrew Rybchenko
2018-03-25 16:20 ` [PATCH v2 03/11] mempool: ensure the mempool is initialized before populating Andrew Rybchenko
2018-03-25 16:20 ` [PATCH v2 04/11] mempool: add op to calculate memory size to be allocated Andrew Rybchenko
2018-03-25 16:20 ` [PATCH v2 05/11] mempool: add op to populate objects using provided memory Andrew Rybchenko
2018-03-25 16:20 ` [PATCH v2 06/11] mempool: remove callback to get capabilities Andrew Rybchenko
2018-03-25 16:20 ` [PATCH v2 07/11] mempool: deprecate xmem functions Andrew Rybchenko
2018-03-25 16:20 ` [PATCH v2 08/11] mempool/octeontx: prepare to remove register memory area op Andrew Rybchenko
2018-03-25 16:20 ` [PATCH v2 09/11] mempool/dpaa: " Andrew Rybchenko
2018-03-26 7:13 ` Andrew Rybchenko
2018-03-25 16:20 ` [PATCH v2 10/11] mempool: remove callback to register memory area Andrew Rybchenko
2018-03-25 16:20 ` [PATCH v2 11/11] mempool: support flushing the default cache of the mempool Andrew Rybchenko
2018-03-26 16:09 ` [PATCH v3 00/11] mempool: prepare to add bucket driver Andrew Rybchenko
2018-03-26 16:09 ` [PATCH v3 01/11] mempool: fix memhdr leak when no objects are populated Andrew Rybchenko
2018-04-06 15:50 ` Olivier Matz
2018-03-26 16:09 ` [PATCH v3 02/11] mempool: rename flag to control IOVA-contiguous objects Andrew Rybchenko
2018-04-06 15:50 ` Olivier Matz
2018-03-26 16:09 ` [PATCH v3 03/11] mempool: ensure the mempool is initialized before populating Andrew Rybchenko
2018-04-04 15:06 ` santosh
2018-04-06 15:50 ` Olivier Matz
2018-03-26 16:09 ` [PATCH v3 04/11] mempool: add op to calculate memory size to be allocated Andrew Rybchenko
2018-04-04 15:08 ` santosh
2018-04-06 15:51 ` Olivier Matz
2018-04-12 15:22 ` Burakov, Anatoly
2018-03-26 16:09 ` [PATCH v3 05/11] mempool: add op to populate objects using provided memory Andrew Rybchenko
2018-04-04 15:09 ` santosh
2018-04-06 15:51 ` Olivier Matz
2018-03-26 16:09 ` [PATCH v3 06/11] mempool: remove callback to get capabilities Andrew Rybchenko
2018-04-04 15:10 ` santosh
2018-04-06 15:51 ` Olivier Matz
2018-03-26 16:09 ` [PATCH v3 07/11] mempool: deprecate xmem functions Andrew Rybchenko
2018-04-06 15:52 ` Olivier Matz
2018-03-26 16:09 ` [PATCH v3 08/11] mempool/octeontx: prepare to remove register memory area op Andrew Rybchenko
2018-04-04 15:12 ` santosh
2018-03-26 16:09 ` [PATCH v3 09/11] mempool/dpaa: " Andrew Rybchenko
2018-04-05 8:25 ` Hemant Agrawal
2018-03-26 16:09 ` [PATCH v3 10/11] mempool: remove callback to register memory area Andrew Rybchenko
2018-04-04 15:13 ` santosh
2018-04-06 15:52 ` Olivier Matz
2018-03-26 16:09 ` [PATCH v3 11/11] mempool: support flushing the default cache of the mempool Andrew Rybchenko
2018-04-06 15:53 ` Olivier Matz
2018-03-26 16:12 ` [PATCH v1 0/6] mempool: add bucket driver Andrew Rybchenko
2018-03-26 16:12 ` [PATCH v1 1/6] mempool/bucket: implement bucket mempool manager Andrew Rybchenko
2018-03-26 16:12 ` [PATCH v1 2/6] mempool: implement abstract mempool info API Andrew Rybchenko
2018-04-19 16:42 ` Olivier Matz
2018-04-25 9:57 ` Andrew Rybchenko
2018-04-25 10:26 ` Olivier Matz
2018-03-26 16:12 ` [PATCH v1 3/6] mempool: support block dequeue operation Andrew Rybchenko
2018-04-19 16:41 ` Olivier Matz
2018-04-25 9:49 ` Andrew Rybchenko
2018-03-26 16:12 ` [PATCH v1 4/6] mempool/bucket: implement " Andrew Rybchenko
2018-03-26 16:12 ` [PATCH v1 5/6] mempool/bucket: do not allow one lcore to grab all buckets Andrew Rybchenko
2018-03-26 16:12 ` [PATCH v1 6/6] doc: advertise bucket mempool driver Andrew Rybchenko
2018-04-19 16:43 ` Olivier Matz
2018-04-19 16:41 ` [PATCH v1 0/6] mempool: add bucket driver Olivier Matz
2018-04-16 13:24 ` [PATCH v4 00/11] mempool: prepare to " Andrew Rybchenko
2018-04-16 13:24 ` [PATCH v4 01/11] mempool: fix memhdr leak when no objects are populated Andrew Rybchenko
2018-04-16 13:24 ` [PATCH v4 02/11] mempool: rename flag to control IOVA-contiguous objects Andrew Rybchenko
2018-04-16 13:24 ` [PATCH v4 03/11] mempool: ensure the mempool is initialized before populating Andrew Rybchenko
2018-04-16 13:24 ` [PATCH v4 04/11] mempool: add op to calculate memory size to be allocated Andrew Rybchenko
2018-04-16 15:33 ` Olivier Matz
2018-04-16 15:41 ` Andrew Rybchenko
2018-04-17 10:23 ` Burakov, Anatoly
2018-04-16 13:24 ` [PATCH v4 05/11] mempool: add op to populate objects using provided memory Andrew Rybchenko
2018-04-16 13:24 ` [PATCH v4 06/11] mempool: remove callback to get capabilities Andrew Rybchenko
2018-04-16 13:24 ` [PATCH v4 07/11] mempool: deprecate xmem functions Andrew Rybchenko
2018-04-16 13:24 ` [PATCH v4 08/11] mempool/octeontx: prepare to remove register memory area op Andrew Rybchenko
2018-04-16 13:24 ` [PATCH v4 09/11] mempool/dpaa: " Andrew Rybchenko
2018-04-16 13:24 ` [PATCH v4 10/11] mempool: remove callback to register memory area Andrew Rybchenko
2018-04-16 13:24 ` [PATCH v4 11/11] mempool: support flushing the default cache of the mempool Andrew Rybchenko
2018-04-24 0:20 ` [PATCH v4 00/11] mempool: prepare to add bucket driver Thomas Monjalon
2018-04-16 13:33 ` [PATCH v2 0/6] mempool: " Andrew Rybchenko
2018-04-16 13:33 ` [PATCH v2 1/6] mempool/bucket: implement bucket mempool manager Andrew Rybchenko
2018-04-16 13:33 ` [PATCH v2 2/6] mempool: implement abstract mempool info API Andrew Rybchenko
2018-04-25 8:44 ` Olivier Matz
2018-04-16 13:33 ` [PATCH v2 3/6] mempool: support block dequeue operation Andrew Rybchenko
2018-04-25 8:45 ` Olivier Matz
2018-04-16 13:33 ` [PATCH v2 4/6] mempool/bucket: implement " Andrew Rybchenko
2018-04-16 13:33 ` [PATCH v2 5/6] mempool/bucket: do not allow one lcore to grab all buckets Andrew Rybchenko
2018-04-16 13:33 ` [PATCH v2 6/6] doc: advertise bucket mempool driver Andrew Rybchenko
2018-04-24 23:00 ` [PATCH v2 0/6] mempool: add bucket driver Thomas Monjalon
2018-04-25 8:43 ` Olivier Matz
2018-04-25 16:32 ` [PATCH v3 " Andrew Rybchenko
2018-04-25 16:32 ` [PATCH v3 1/6] mempool/bucket: implement bucket mempool manager Andrew Rybchenko
2018-04-25 16:32 ` [PATCH v3 2/6] mempool: implement abstract mempool info API Andrew Rybchenko
2018-04-25 16:32 ` [PATCH v3 3/6] mempool: support block dequeue operation Andrew Rybchenko
2018-04-25 16:32 ` [PATCH v3 4/6] mempool/bucket: implement " Andrew Rybchenko
2018-04-25 16:32 ` [PATCH v3 5/6] mempool/bucket: do not allow one lcore to grab all buckets Andrew Rybchenko
2018-04-25 16:32 ` [PATCH v3 6/6] doc: advertise bucket mempool driver Andrew Rybchenko
2018-04-25 21:56 ` Thomas Monjalon
2018-04-25 22:04 ` Thomas Monjalon
2018-04-26 9:50 ` Andrew Rybchenko
2018-04-26 10:59 ` [PATCH v4 0/5] mempool: add bucket driver Andrew Rybchenko
2018-04-26 10:59 ` [PATCH v4 1/5] mempool/bucket: implement bucket mempool manager Andrew Rybchenko
2018-04-26 10:59 ` [PATCH v4 2/5] mempool: implement abstract mempool info API Andrew Rybchenko
2018-04-26 10:59 ` [PATCH v4 3/5] mempool: support block dequeue operation Andrew Rybchenko
2018-04-26 10:59 ` [PATCH v4 4/5] mempool/bucket: implement " Andrew Rybchenko
2018-04-26 10:59 ` [PATCH v4 5/5] mempool/bucket: do not allow one lcore to grab all buckets Andrew Rybchenko
2018-04-26 21:35 ` [PATCH v4 0/5] mempool: add bucket driver Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dae318c-ce21-185a-a6eb-3f193aae2ae9@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=olivier.matz@6wind.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.