All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex DAMIAN <alexandru.damian@intel.com>
To: bitbake-devel@lists.openembedded.org
Cc: Ravi Chintakunta <ravi.chintakunta@timesys.com>
Subject: [PATCH 03/14] toaster: Display task description
Date: Mon, 31 Mar 2014 17:47:03 +0100	[thread overview]
Message-ID: <4db519c5b37cfdce37e4b2afaef75109295ff800.1396284354.git.alexandru.damian@intel.com> (raw)
In-Reply-To: <2eb6aba6ca24b899b4afe03cb21460d4238e19ed.1396284354.git.alexandru.damian@intel.com>
In-Reply-To: <cover.1396284354.git.alexandru.damian@intel.com>

From: Ravi Chintakunta <ravi.chintakunta@timesys.com>

Display task description as content of help bubble for a task.

[YOCTO #5748]

Signed-off-by: Ravi Chintakunta <ravi.chintakunta@timesys.com>
---
 lib/toaster/orm/models.py                    | 7 +++++++
 lib/toaster/toastergui/templates/recipe.html | 2 +-
 lib/toaster/toastergui/templates/tasks.html  | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/lib/toaster/orm/models.py b/lib/toaster/orm/models.py
index 4975433..9c15ebf 100644
--- a/lib/toaster/orm/models.py
+++ b/lib/toaster/orm/models.py
@@ -174,6 +174,13 @@ class Task(models.Model):
             return "Executed"
         return "Not Executed"
 
+    def get_description(self):
+        variable = Variable.objects.filter(variable_name=self.task_name, build = self.build)
+        try:
+            return variable[0].description
+        except IndexError:
+            return ''
+
     build = models.ForeignKey(Build, related_name='task_build')
     order = models.IntegerField(null=True)
     task_executed = models.BooleanField(default=False) # True means Executed, False means Not/Executed
diff --git a/lib/toaster/toastergui/templates/recipe.html b/lib/toaster/toastergui/templates/recipe.html
index e367077..b8898d2 100644
--- a/lib/toaster/toastergui/templates/recipe.html
+++ b/lib/toaster/toastergui/templates/recipe.html
@@ -112,7 +112,7 @@
                     <td><a {{ task|task_color }} href="{% url "task" build.pk task.pk %}">{{task.order}}</a></td>
                     <td>
                         <a {{ task|task_color }} href="{% url "task" build.pk task.pk %}">{{task.task_name}}</a>
-                        <i class="icon-question-sign get-help hover-help" title="This task fetches the source code"></i>
+                        {% if task.get_description %}<i class="icon-question-sign get-help hover-help" title="" data-original-title="{{task.get_description}}"></i> {% endif %}
                     </td>
 
                     <td><a {{ task|task_color }} href="{% url "task" build.pk task.pk %}">{{task.get_executed_display}}</a></td>
diff --git a/lib/toaster/toastergui/templates/tasks.html b/lib/toaster/toastergui/templates/tasks.html
index ca7e187..d68a31a 100644
--- a/lib/toaster/toastergui/templates/tasks.html
+++ b/lib/toaster/toastergui/templates/tasks.html
@@ -86,7 +86,7 @@
                 <a href="{% url "recipe" build.pk task.recipe.pk %}">{{task.recipe.version}}</a>
             </td>
             <td class="task_name">
-                <a href="{%url "task" build.pk task.pk%} ">{{task.task_name}}</a>
+                <a href="{%url "task" build.pk task.pk%} ">{{task.task_name}}</a> {% if task.get_description %}<i class="icon-question-sign get-help hover-help" title="" data-original-title="{{task.get_description}}"></i> {% endif %}
             </td>
             <td class="executed">
                 <a href="{%url "task" build.pk task.pk%} ">{{task.get_executed_display}}</a>
-- 
1.9.1



  parent reply	other threads:[~2014-03-31 16:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 16:47 [PATCH 00/14] Toaster pull request Alex DAMIAN
2014-03-31 16:47 ` [PATCH 01/14] toaster: update saving sstate task data Alex DAMIAN
2014-03-31 16:47 ` [PATCH 02/14] toaster: fix timezone detection Alex DAMIAN
2014-03-31 16:47 ` Alex DAMIAN [this message]
2014-03-31 16:47 ` [PATCH 04/14] toaster: use deploy_dir var to obtain the license.manifest path Alex DAMIAN
2014-03-31 16:47 ` [PATCH 05/14] toaster: disable configvar sorts for value and files Alex DAMIAN
2014-03-31 16:47 ` [PATCH 06/14] toaster: Show "No builds found" in the builds table Alex DAMIAN
2014-03-31 16:47 ` [PATCH 07/14] toaster: Remove trailing spaces from 'name' Alex DAMIAN
2014-03-31 16:47 ` [PATCH 08/14] toaster: Small tweaks to the packages included interface Alex DAMIAN
2014-03-31 16:47 ` [PATCH 09/14] toaster: Fix the fade out animation Alex DAMIAN
2014-03-31 16:47 ` [PATCH 10/14] toaster: Increase animation duration Alex DAMIAN
2014-03-31 16:47 ` [PATCH 11/14] toaster: Match search results form to no results form Alex DAMIAN
2014-03-31 16:47 ` [PATCH 12/14] toaster: Update help text in format_vpackage_namehelp tag Alex DAMIAN
2014-03-31 16:47 ` [PATCH 13/14] toaster: unbuilt package dependency formats Alex DAMIAN
2014-03-31 16:47 ` [PATCH 14/14] toaster: secondary sort key as table's default order Alex DAMIAN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4db519c5b37cfdce37e4b2afaef75109295ff800.1396284354.git.alexandru.damian@intel.com \
    --to=alexandru.damian@intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=ravi.chintakunta@timesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.