From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85552C4338F for ; Wed, 4 Aug 2021 07:10:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F1A760EEA for ; Wed, 4 Aug 2021 07:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235223AbhHDHK5 (ORCPT ); Wed, 4 Aug 2021 03:10:57 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:43704 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235219AbhHDHK5 (ORCPT ); Wed, 4 Aug 2021 03:10:57 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 58A9E1FDB6; Wed, 4 Aug 2021 07:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628061044; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6Fma+4mkffDQMef6Jjk4YxVumN0JgVC+wFZCNyVS+U=; b=MmAgVVXyzNmgZOd0xIxFUQDwU0idupOhxjU77otdVv92Aj6n/aknmlZ8pF/qnQ4oCwhmwF Ieb5iE6N7lGymEJjhc/5pszed4TWliogCGoAzDmfc9faB3N/FLOUlxiCQr5GjrCCpEOr5b X8j39hoeQJv0wczMR+lxYzOvA0bL/G4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628061044; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6Fma+4mkffDQMef6Jjk4YxVumN0JgVC+wFZCNyVS+U=; b=utuo1u7XkDupb4O1+qajZc9NPeWTeX7FpJO1d+NUYnwx7DbpPCyzpM20Jj+VaOeIHnW5xX O0SxzGfy0QbjmpBA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 9E23B136DD; Wed, 4 Aug 2021 07:10:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id wHpHJXM9CmG7RAAAGKfGzw (envelope-from ); Wed, 04 Aug 2021 07:10:43 +0000 Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy To: "Chrisanthus, Anitha" , Sam Ravnborg Cc: "daniel@ffwll.ch" , "airlied@linux.ie" , "alexander.deucher@amd.com" , "christian.koenig@amd.com" , "liviu.dudau@arm.com" , "brian.starkey@arm.com" , "bbrezillon@kernel.org" , "nicolas.ferre@microchip.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "stefan@agner.ch" , "alison.wang@nxp.com" , "patrik.r.jakobsson@gmail.com" , "robdclark@gmail.com" , "Dea, Edmund J" , "sean@poorly.run" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "jyri.sarha@iki.fi" , "tomba@kernel.org" , "Dan.Sneddon@microchip.com" , "tomi.valkeinen@ideasonboard.com" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "freedreno@lists.freedesktop.org" References: <20210803090704.32152-1-tzimmermann@suse.de> From: Thomas Zimmermann Message-ID: <4dbc29d7-5f88-e3ac-5dab-e2dc5c6a703e@suse.de> Date: Wed, 4 Aug 2021 09:10:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5 Content-Type: multipart/mixed; boundary="rRGFxDGZO3Dx2xxobza1NKfBtRtDsmBuD"; protected-headers="v1" From: Thomas Zimmermann To: "Chrisanthus, Anitha" , Sam Ravnborg Cc: "daniel@ffwll.ch" , "airlied@linux.ie" , "alexander.deucher@amd.com" , "christian.koenig@amd.com" , "liviu.dudau@arm.com" , "brian.starkey@arm.com" , "bbrezillon@kernel.org" , "nicolas.ferre@microchip.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "stefan@agner.ch" , "alison.wang@nxp.com" , "patrik.r.jakobsson@gmail.com" , "robdclark@gmail.com" , "Dea, Edmund J" , "sean@poorly.run" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "jyri.sarha@iki.fi" , "tomba@kernel.org" , "Dan.Sneddon@microchip.com" , "tomi.valkeinen@ideasonboard.com" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "freedreno@lists.freedesktop.org" Message-ID: <4dbc29d7-5f88-e3ac-5dab-e2dc5c6a703e@suse.de> Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy References: <20210803090704.32152-1-tzimmermann@suse.de> In-Reply-To: --rRGFxDGZO3Dx2xxobza1NKfBtRtDsmBuD Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 03.08.21 um 20:36 schrieb Chrisanthus, Anitha: > Hi Thomas, > Can you please hold off on applying the kmb patch, I am seeing some iss= ues while testing. Modetest works, but video playback only plays once, an= d it fails the second time with this patch. Sounds a bit like the testing issue at [1]. For testing, you need the=20 latest drm-misc-next or drm-tip. Specifically, you need commit=20 1e4cd78ed493 ("drm: Don't test for IRQ support in VBLANK ioctls"). Let me know whether this works for you. Best regards Thomas [1] https://patchwork.freedesktop.org/patch/447057/?series=3D93078&rev=3D= 1 >=20 > Thanks, > Anitha >=20 >=20 >> -----Original Message----- >> From: Sam Ravnborg >> Sent: Tuesday, August 3, 2021 8:05 AM >> To: Thomas Zimmermann >> Cc: daniel@ffwll.ch; airlied@linux.ie; alexander.deucher@amd.com; >> christian.koenig@amd.com; liviu.dudau@arm.com; brian.starkey@arm.com; >> bbrezillon@kernel.org; nicolas.ferre@microchip.com; >> maarten.lankhorst@linux.intel.com; mripard@kernel.org; stefan@agner.ch= ; >> alison.wang@nxp.com; patrik.r.jakobsson@gmail.com; Chrisanthus, Anitha= >> ; robdclark@gmail.com; Dea, Edmund J >> ; sean@poorly.run; shawnguo@kernel.org; >> s.hauer@pengutronix.de; kernel@pengutronix.de; jyri.sarha@iki.fi; >> tomba@kernel.org; Dan.Sneddon@microchip.com; >> tomi.valkeinen@ideasonboard.com; amd-gfx@lists.freedesktop.org; dri- >> devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; lin= ux-arm- >> msm@vger.kernel.org; freedreno@lists.freedesktop.org >> Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy >> >> Hi Thomas, >> >> On Tue, Aug 03, 2021 at 11:06:50AM +0200, Thomas Zimmermann wrote: >>> DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move >>> the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux >>> IRQ interfaces. >>> >>> DRM provides IRQ helpers for setting up, receiving and removing IRQ >>> handlers. It's an abstraction over plain Linux functions. The code >>> is mid-layerish with several callbacks to hook into the rsp drivers. >>> Old UMS driver have their interrupts enabled via ioctl, so these >>> abstractions makes some sense. Modern KMS manage all their interrupts= >>> internally. Using the DRM helpers adds indirection without benefits. >>> >>> Most KMS drivers already use Linux IRQ functions instead of DRM's >>> abstraction layer. Patches 1 to 12 convert the remaining ones. >>> The patches also resolve a bug for devices without assigned interrupt= >>> number. DRM helpers don't test for IRQ_NOTCONNECTED, so drivers do >>> not detect if the device has no interrupt assigned. >>> >>> Patch 13 removes an unused function. >>> >>> Patch 14 moves the DRM IRQ helpers behind CONFIG_DRM_LEGACY. Only >>> the old non-KMS drivers still use the functionality. >>> >>> v2: >>> * drop IRQ_NOTCONNECTED test from atmel-hlcdc (Sam) >>> * use devm_request_irq() in atmel-hlcdc (Sam) >>> * unify variable names in arm/hlcdc (Sam) >>> >>> Thomas Zimmermann (14): >> >> The following patches are all: >> Acked-by: Sam Ravnborg >> >>> drm/fsl-dcu: Convert to Linux IRQ interfaces >>> drm/gma500: Convert to Linux IRQ interfaces >>> drm/kmb: Convert to Linux IRQ interfaces >>> drm/msm: Convert to Linux IRQ interfaces >>> drm/mxsfb: Convert to Linux IRQ interfaces >>> drm/tidss: Convert to Linux IRQ interfaces >>> drm/vc4: Convert to Linux IRQ interfaces >>> drm: Remove unused devm_drm_irq_install() >> >> The remaining patches I either skipped or already had a feedback from >> me or I asked a question. >> >> Sam --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --rRGFxDGZO3Dx2xxobza1NKfBtRtDsmBuD-- --fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmEKPXMFAwAAAAAACgkQlh/E3EQov+BL vA/9FMcuq6uMCqAQTbojiwk+Wff+g6UvCm0U80Woyz2mQ05HAGK6vmc2fdhyjKyrdGAA1LkWe0ES P44igHsVIFVHDUlbVmtmoozHc6vJiyPR8u5pcA37HCUT6Z6qrvUgrIvsQ4LYjbxfImARN9N6RBRX GXigsbkib+NNj1u39NSz/udKa6eH3RKJcGqx3gyxhmNHx2dbgWR64YBsc51BLwr9HGDO2or2f35i Q54NYRbNzeFDrFXY92DO8iffUaz8o3a5kvm9y0cGC3mIcCdacte/8z+fr1OztAfFh1FJLNVnQDTM WguRoXq+0S700QWAzmyR8/bYyBML5qMR4Cf1rdLlck7IxHDy2kTgZYyLydxZl6qthnJhOM7GAptQ 6fsMKIoh16KNggKn1vv/1TQyQdNyHUZphr8f0p+Y7bA9pIkhkqz0C12xS8Y5t/AGd9aMFOXxPx8k EJ8YfTE3L8XHnUjg6CCO3cHf4BiAmYlqaIb40RslM821VDhOWtrwW1qfpU8/E5YMXKOGgoyxAoki EcarYFDZrwDoWw9A4hK05JS8g6NsHLHKFyF46yE9wyeRPmNnb9h5dvFWP0tLuAoAmoPJatO+Q/eV TIOd12UvXGgFClMKZCB3sCcgdKyP7vZ+0RpBwtUEOCsZ/mT4PHn2VzL3c2CLKRmm740G8OFQXQe+ DF8= =1EtW -----END PGP SIGNATURE----- --fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF5B6C4338F for ; Wed, 4 Aug 2021 07:12:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58ABE60F35 for ; Wed, 4 Aug 2021 07:12:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 58ABE60F35 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6przArbDtoURyD95FPxdGvubUQZJOI7dYRmR2DMqi64=; b=G/DRhJE/aIZ/zQNiSDYiUYtBPK YThEG75Ep+jsG84e2HvkFQTWa/vnAhu53FujsCEj8+kqBpvk/P4tqoB/XwjSxYvlucC7ogRMIGuur ftfEkpHRxZZAYyVPpgaZoszGyxYmA1lnxcUlhQziz6zDAilhB0w4oHgP8eShDbBgXzpkYGsKchfqm CgOYNOgsW9PgO3ASdGyecKaLOqi4w6Ikro5VwX9/k7AXjhwm6xd7YadVzHSus0ERAU7KEBxp5pI0S Xunm6csv4/RXXZqcZxNFWBhrAN3yFJmWm3h+JniqPCIqJ0ibOVDkbbKMo3vVpUrwn4jtuHFk+3eTN OlrOi9Pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBB3B-004z94-J9; Wed, 04 Aug 2021 07:10:49 +0000 Received: from smtp-out2.suse.de ([195.135.220.29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBB37-004z8b-UK for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 07:10:47 +0000 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 58A9E1FDB6; Wed, 4 Aug 2021 07:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628061044; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6Fma+4mkffDQMef6Jjk4YxVumN0JgVC+wFZCNyVS+U=; b=MmAgVVXyzNmgZOd0xIxFUQDwU0idupOhxjU77otdVv92Aj6n/aknmlZ8pF/qnQ4oCwhmwF Ieb5iE6N7lGymEJjhc/5pszed4TWliogCGoAzDmfc9faB3N/FLOUlxiCQr5GjrCCpEOr5b X8j39hoeQJv0wczMR+lxYzOvA0bL/G4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628061044; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6Fma+4mkffDQMef6Jjk4YxVumN0JgVC+wFZCNyVS+U=; b=utuo1u7XkDupb4O1+qajZc9NPeWTeX7FpJO1d+NUYnwx7DbpPCyzpM20Jj+VaOeIHnW5xX O0SxzGfy0QbjmpBA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 9E23B136DD; Wed, 4 Aug 2021 07:10:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id wHpHJXM9CmG7RAAAGKfGzw (envelope-from ); Wed, 04 Aug 2021 07:10:43 +0000 Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy To: "Chrisanthus, Anitha" , Sam Ravnborg References: <20210803090704.32152-1-tzimmermann@suse.de> From: Thomas Zimmermann Message-ID: <4dbc29d7-5f88-e3ac-5dab-e2dc5c6a703e@suse.de> Date: Wed, 4 Aug 2021 09:10:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_001046_188464_23B5B2B7 X-CRM114-Status: GOOD ( 22.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "airlied@linux.ie" , "tomi.valkeinen@ideasonboard.com" , "liviu.dudau@arm.com" , "stefan@agner.ch" , "amd-gfx@lists.freedesktop.org" , "Dan.Sneddon@microchip.com" , "patrik.r.jakobsson@gmail.com" , "linux-arm-msm@vger.kernel.org" , "freedreno@lists.freedesktop.org" , "daniel@ffwll.ch" , "Dea, Edmund J" , "s.hauer@pengutronix.de" , "alison.wang@nxp.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "dri-devel@lists.freedesktop.org" , "sean@poorly.run" , "linux-arm-kernel@lists.infradead.org" , "tomba@kernel.org" , "bbrezillon@kernel.org" , "jyri.sarha@iki.fi" , "christian.koenig@amd.com" , "robdclark@gmail.com" , "kernel@pengutronix.de" , "alexander.deucher@amd.com" , "shawnguo@kernel.org" , "brian.starkey@arm.com" Content-Type: multipart/mixed; boundary="===============1533987909060137387==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1533987909060137387== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5 Content-Type: multipart/mixed; boundary="rRGFxDGZO3Dx2xxobza1NKfBtRtDsmBuD"; protected-headers="v1" From: Thomas Zimmermann To: "Chrisanthus, Anitha" , Sam Ravnborg Cc: "daniel@ffwll.ch" , "airlied@linux.ie" , "alexander.deucher@amd.com" , "christian.koenig@amd.com" , "liviu.dudau@arm.com" , "brian.starkey@arm.com" , "bbrezillon@kernel.org" , "nicolas.ferre@microchip.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "stefan@agner.ch" , "alison.wang@nxp.com" , "patrik.r.jakobsson@gmail.com" , "robdclark@gmail.com" , "Dea, Edmund J" , "sean@poorly.run" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "jyri.sarha@iki.fi" , "tomba@kernel.org" , "Dan.Sneddon@microchip.com" , "tomi.valkeinen@ideasonboard.com" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "freedreno@lists.freedesktop.org" Message-ID: <4dbc29d7-5f88-e3ac-5dab-e2dc5c6a703e@suse.de> Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy References: <20210803090704.32152-1-tzimmermann@suse.de> In-Reply-To: --rRGFxDGZO3Dx2xxobza1NKfBtRtDsmBuD Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 03.08.21 um 20:36 schrieb Chrisanthus, Anitha: > Hi Thomas, > Can you please hold off on applying the kmb patch, I am seeing some iss= ues while testing. Modetest works, but video playback only plays once, an= d it fails the second time with this patch. Sounds a bit like the testing issue at [1]. For testing, you need the=20 latest drm-misc-next or drm-tip. Specifically, you need commit=20 1e4cd78ed493 ("drm: Don't test for IRQ support in VBLANK ioctls"). Let me know whether this works for you. Best regards Thomas [1] https://patchwork.freedesktop.org/patch/447057/?series=3D93078&rev=3D= 1 >=20 > Thanks, > Anitha >=20 >=20 >> -----Original Message----- >> From: Sam Ravnborg >> Sent: Tuesday, August 3, 2021 8:05 AM >> To: Thomas Zimmermann >> Cc: daniel@ffwll.ch; airlied@linux.ie; alexander.deucher@amd.com; >> christian.koenig@amd.com; liviu.dudau@arm.com; brian.starkey@arm.com; >> bbrezillon@kernel.org; nicolas.ferre@microchip.com; >> maarten.lankhorst@linux.intel.com; mripard@kernel.org; stefan@agner.ch= ; >> alison.wang@nxp.com; patrik.r.jakobsson@gmail.com; Chrisanthus, Anitha= >> ; robdclark@gmail.com; Dea, Edmund J >> ; sean@poorly.run; shawnguo@kernel.org; >> s.hauer@pengutronix.de; kernel@pengutronix.de; jyri.sarha@iki.fi; >> tomba@kernel.org; Dan.Sneddon@microchip.com; >> tomi.valkeinen@ideasonboard.com; amd-gfx@lists.freedesktop.org; dri- >> devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; lin= ux-arm- >> msm@vger.kernel.org; freedreno@lists.freedesktop.org >> Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy >> >> Hi Thomas, >> >> On Tue, Aug 03, 2021 at 11:06:50AM +0200, Thomas Zimmermann wrote: >>> DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move >>> the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux >>> IRQ interfaces. >>> >>> DRM provides IRQ helpers for setting up, receiving and removing IRQ >>> handlers. It's an abstraction over plain Linux functions. The code >>> is mid-layerish with several callbacks to hook into the rsp drivers. >>> Old UMS driver have their interrupts enabled via ioctl, so these >>> abstractions makes some sense. Modern KMS manage all their interrupts= >>> internally. Using the DRM helpers adds indirection without benefits. >>> >>> Most KMS drivers already use Linux IRQ functions instead of DRM's >>> abstraction layer. Patches 1 to 12 convert the remaining ones. >>> The patches also resolve a bug for devices without assigned interrupt= >>> number. DRM helpers don't test for IRQ_NOTCONNECTED, so drivers do >>> not detect if the device has no interrupt assigned. >>> >>> Patch 13 removes an unused function. >>> >>> Patch 14 moves the DRM IRQ helpers behind CONFIG_DRM_LEGACY. Only >>> the old non-KMS drivers still use the functionality. >>> >>> v2: >>> * drop IRQ_NOTCONNECTED test from atmel-hlcdc (Sam) >>> * use devm_request_irq() in atmel-hlcdc (Sam) >>> * unify variable names in arm/hlcdc (Sam) >>> >>> Thomas Zimmermann (14): >> >> The following patches are all: >> Acked-by: Sam Ravnborg >> >>> drm/fsl-dcu: Convert to Linux IRQ interfaces >>> drm/gma500: Convert to Linux IRQ interfaces >>> drm/kmb: Convert to Linux IRQ interfaces >>> drm/msm: Convert to Linux IRQ interfaces >>> drm/mxsfb: Convert to Linux IRQ interfaces >>> drm/tidss: Convert to Linux IRQ interfaces >>> drm/vc4: Convert to Linux IRQ interfaces >>> drm: Remove unused devm_drm_irq_install() >> >> The remaining patches I either skipped or already had a feedback from >> me or I asked a question. >> >> Sam --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --rRGFxDGZO3Dx2xxobza1NKfBtRtDsmBuD-- --fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmEKPXMFAwAAAAAACgkQlh/E3EQov+BL vA/9FMcuq6uMCqAQTbojiwk+Wff+g6UvCm0U80Woyz2mQ05HAGK6vmc2fdhyjKyrdGAA1LkWe0ES P44igHsVIFVHDUlbVmtmoozHc6vJiyPR8u5pcA37HCUT6Z6qrvUgrIvsQ4LYjbxfImARN9N6RBRX GXigsbkib+NNj1u39NSz/udKa6eH3RKJcGqx3gyxhmNHx2dbgWR64YBsc51BLwr9HGDO2or2f35i Q54NYRbNzeFDrFXY92DO8iffUaz8o3a5kvm9y0cGC3mIcCdacte/8z+fr1OztAfFh1FJLNVnQDTM WguRoXq+0S700QWAzmyR8/bYyBML5qMR4Cf1rdLlck7IxHDy2kTgZYyLydxZl6qthnJhOM7GAptQ 6fsMKIoh16KNggKn1vv/1TQyQdNyHUZphr8f0p+Y7bA9pIkhkqz0C12xS8Y5t/AGd9aMFOXxPx8k EJ8YfTE3L8XHnUjg6CCO3cHf4BiAmYlqaIb40RslM821VDhOWtrwW1qfpU8/E5YMXKOGgoyxAoki EcarYFDZrwDoWw9A4hK05JS8g6NsHLHKFyF46yE9wyeRPmNnb9h5dvFWP0tLuAoAmoPJatO+Q/eV TIOd12UvXGgFClMKZCB3sCcgdKyP7vZ+0RpBwtUEOCsZ/mT4PHn2VzL3c2CLKRmm740G8OFQXQe+ DF8= =1EtW -----END PGP SIGNATURE----- --fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5-- --===============1533987909060137387== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1533987909060137387==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5143FC19F39 for ; Wed, 4 Aug 2021 07:19:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 194D360F58 for ; Wed, 4 Aug 2021 07:19:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 194D360F58 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 25DB56E9EA; Wed, 4 Aug 2021 07:19:23 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id B234D6E9DF; Wed, 4 Aug 2021 07:19:16 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 58A9E1FDB6; Wed, 4 Aug 2021 07:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628061044; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6Fma+4mkffDQMef6Jjk4YxVumN0JgVC+wFZCNyVS+U=; b=MmAgVVXyzNmgZOd0xIxFUQDwU0idupOhxjU77otdVv92Aj6n/aknmlZ8pF/qnQ4oCwhmwF Ieb5iE6N7lGymEJjhc/5pszed4TWliogCGoAzDmfc9faB3N/FLOUlxiCQr5GjrCCpEOr5b X8j39hoeQJv0wczMR+lxYzOvA0bL/G4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628061044; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6Fma+4mkffDQMef6Jjk4YxVumN0JgVC+wFZCNyVS+U=; b=utuo1u7XkDupb4O1+qajZc9NPeWTeX7FpJO1d+NUYnwx7DbpPCyzpM20Jj+VaOeIHnW5xX O0SxzGfy0QbjmpBA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 9E23B136DD; Wed, 4 Aug 2021 07:10:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id wHpHJXM9CmG7RAAAGKfGzw (envelope-from ); Wed, 04 Aug 2021 07:10:43 +0000 Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy To: "Chrisanthus, Anitha" , Sam Ravnborg Cc: "daniel@ffwll.ch" , "airlied@linux.ie" , "alexander.deucher@amd.com" , "christian.koenig@amd.com" , "liviu.dudau@arm.com" , "brian.starkey@arm.com" , "bbrezillon@kernel.org" , "nicolas.ferre@microchip.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "stefan@agner.ch" , "alison.wang@nxp.com" , "patrik.r.jakobsson@gmail.com" , "robdclark@gmail.com" , "Dea, Edmund J" , "sean@poorly.run" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "jyri.sarha@iki.fi" , "tomba@kernel.org" , "Dan.Sneddon@microchip.com" , "tomi.valkeinen@ideasonboard.com" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "freedreno@lists.freedesktop.org" References: <20210803090704.32152-1-tzimmermann@suse.de> From: Thomas Zimmermann Message-ID: <4dbc29d7-5f88-e3ac-5dab-e2dc5c6a703e@suse.de> Date: Wed, 4 Aug 2021 09:10:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5 Content-Type: multipart/mixed; boundary="rRGFxDGZO3Dx2xxobza1NKfBtRtDsmBuD"; protected-headers="v1" From: Thomas Zimmermann To: "Chrisanthus, Anitha" , Sam Ravnborg Cc: "daniel@ffwll.ch" , "airlied@linux.ie" , "alexander.deucher@amd.com" , "christian.koenig@amd.com" , "liviu.dudau@arm.com" , "brian.starkey@arm.com" , "bbrezillon@kernel.org" , "nicolas.ferre@microchip.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "stefan@agner.ch" , "alison.wang@nxp.com" , "patrik.r.jakobsson@gmail.com" , "robdclark@gmail.com" , "Dea, Edmund J" , "sean@poorly.run" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "jyri.sarha@iki.fi" , "tomba@kernel.org" , "Dan.Sneddon@microchip.com" , "tomi.valkeinen@ideasonboard.com" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "freedreno@lists.freedesktop.org" Message-ID: <4dbc29d7-5f88-e3ac-5dab-e2dc5c6a703e@suse.de> Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy References: <20210803090704.32152-1-tzimmermann@suse.de> In-Reply-To: --rRGFxDGZO3Dx2xxobza1NKfBtRtDsmBuD Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 03.08.21 um 20:36 schrieb Chrisanthus, Anitha: > Hi Thomas, > Can you please hold off on applying the kmb patch, I am seeing some iss= ues while testing. Modetest works, but video playback only plays once, an= d it fails the second time with this patch. Sounds a bit like the testing issue at [1]. For testing, you need the=20 latest drm-misc-next or drm-tip. Specifically, you need commit=20 1e4cd78ed493 ("drm: Don't test for IRQ support in VBLANK ioctls"). Let me know whether this works for you. Best regards Thomas [1] https://patchwork.freedesktop.org/patch/447057/?series=3D93078&rev=3D= 1 >=20 > Thanks, > Anitha >=20 >=20 >> -----Original Message----- >> From: Sam Ravnborg >> Sent: Tuesday, August 3, 2021 8:05 AM >> To: Thomas Zimmermann >> Cc: daniel@ffwll.ch; airlied@linux.ie; alexander.deucher@amd.com; >> christian.koenig@amd.com; liviu.dudau@arm.com; brian.starkey@arm.com; >> bbrezillon@kernel.org; nicolas.ferre@microchip.com; >> maarten.lankhorst@linux.intel.com; mripard@kernel.org; stefan@agner.ch= ; >> alison.wang@nxp.com; patrik.r.jakobsson@gmail.com; Chrisanthus, Anitha= >> ; robdclark@gmail.com; Dea, Edmund J >> ; sean@poorly.run; shawnguo@kernel.org; >> s.hauer@pengutronix.de; kernel@pengutronix.de; jyri.sarha@iki.fi; >> tomba@kernel.org; Dan.Sneddon@microchip.com; >> tomi.valkeinen@ideasonboard.com; amd-gfx@lists.freedesktop.org; dri- >> devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; lin= ux-arm- >> msm@vger.kernel.org; freedreno@lists.freedesktop.org >> Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy >> >> Hi Thomas, >> >> On Tue, Aug 03, 2021 at 11:06:50AM +0200, Thomas Zimmermann wrote: >>> DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move >>> the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux >>> IRQ interfaces. >>> >>> DRM provides IRQ helpers for setting up, receiving and removing IRQ >>> handlers. It's an abstraction over plain Linux functions. The code >>> is mid-layerish with several callbacks to hook into the rsp drivers. >>> Old UMS driver have their interrupts enabled via ioctl, so these >>> abstractions makes some sense. Modern KMS manage all their interrupts= >>> internally. Using the DRM helpers adds indirection without benefits. >>> >>> Most KMS drivers already use Linux IRQ functions instead of DRM's >>> abstraction layer. Patches 1 to 12 convert the remaining ones. >>> The patches also resolve a bug for devices without assigned interrupt= >>> number. DRM helpers don't test for IRQ_NOTCONNECTED, so drivers do >>> not detect if the device has no interrupt assigned. >>> >>> Patch 13 removes an unused function. >>> >>> Patch 14 moves the DRM IRQ helpers behind CONFIG_DRM_LEGACY. Only >>> the old non-KMS drivers still use the functionality. >>> >>> v2: >>> * drop IRQ_NOTCONNECTED test from atmel-hlcdc (Sam) >>> * use devm_request_irq() in atmel-hlcdc (Sam) >>> * unify variable names in arm/hlcdc (Sam) >>> >>> Thomas Zimmermann (14): >> >> The following patches are all: >> Acked-by: Sam Ravnborg >> >>> drm/fsl-dcu: Convert to Linux IRQ interfaces >>> drm/gma500: Convert to Linux IRQ interfaces >>> drm/kmb: Convert to Linux IRQ interfaces >>> drm/msm: Convert to Linux IRQ interfaces >>> drm/mxsfb: Convert to Linux IRQ interfaces >>> drm/tidss: Convert to Linux IRQ interfaces >>> drm/vc4: Convert to Linux IRQ interfaces >>> drm: Remove unused devm_drm_irq_install() >> >> The remaining patches I either skipped or already had a feedback from >> me or I asked a question. >> >> Sam --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --rRGFxDGZO3Dx2xxobza1NKfBtRtDsmBuD-- --fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmEKPXMFAwAAAAAACgkQlh/E3EQov+BL vA/9FMcuq6uMCqAQTbojiwk+Wff+g6UvCm0U80Woyz2mQ05HAGK6vmc2fdhyjKyrdGAA1LkWe0ES P44igHsVIFVHDUlbVmtmoozHc6vJiyPR8u5pcA37HCUT6Z6qrvUgrIvsQ4LYjbxfImARN9N6RBRX GXigsbkib+NNj1u39NSz/udKa6eH3RKJcGqx3gyxhmNHx2dbgWR64YBsc51BLwr9HGDO2or2f35i Q54NYRbNzeFDrFXY92DO8iffUaz8o3a5kvm9y0cGC3mIcCdacte/8z+fr1OztAfFh1FJLNVnQDTM WguRoXq+0S700QWAzmyR8/bYyBML5qMR4Cf1rdLlck7IxHDy2kTgZYyLydxZl6qthnJhOM7GAptQ 6fsMKIoh16KNggKn1vv/1TQyQdNyHUZphr8f0p+Y7bA9pIkhkqz0C12xS8Y5t/AGd9aMFOXxPx8k EJ8YfTE3L8XHnUjg6CCO3cHf4BiAmYlqaIb40RslM821VDhOWtrwW1qfpU8/E5YMXKOGgoyxAoki EcarYFDZrwDoWw9A4hK05JS8g6NsHLHKFyF46yE9wyeRPmNnb9h5dvFWP0tLuAoAmoPJatO+Q/eV TIOd12UvXGgFClMKZCB3sCcgdKyP7vZ+0RpBwtUEOCsZ/mT4PHn2VzL3c2CLKRmm740G8OFQXQe+ DF8= =1EtW -----END PGP SIGNATURE----- --fw5ejvAfXrHJYjv7MQv9LkhEvsGVnGgf5--