From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D11EC433EF for ; Mon, 20 Dec 2021 11:48:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229980AbhLTLsW (ORCPT ); Mon, 20 Dec 2021 06:48:22 -0500 Received: from mxout04.lancloud.ru ([45.84.86.114]:40802 "EHLO mxout04.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229619AbhLTLsV (ORCPT ); Mon, 20 Dec 2021 06:48:21 -0500 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru 2DC0020D565E Received: from LanCloud Received: from LanCloud Received: from LanCloud Message-ID: <4dcc204a-ba68-ebb8-021d-fd4b54be2729@omp.ru> Date: Mon, 20 Dec 2021 14:48:12 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] usb: dwc3: qcom: Check for null irq pointer Content-Language: en-US From: Sergey Shtylyov To: Jiasheng Jiang , , , , , CC: , , References: <20211220101520.930658-1-jiasheng@iscas.ac.cn> Organization: Open Mobile Platform In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 20.12.2021 14:25, Sergey Shtylyov wrote: >> The return value of platform_get_irq() needs to be checked. >> To avoid use of null pointer > >   What null pointer, could you please clarify? > >> in case that there is no irq. >> >> Fixes: 2bc02355f8ba ("usb: dwc3: qcom: Add support for booting with ACPI") >> Signed-off-by: Jiasheng Jiang This has already been addressed by this (yet unmerged) patch: https://marc.info/?l=linux-usb&m=162854066430255 MBR, Sergey