From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC16C4321E for ; Thu, 1 Dec 2022 06:17:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229535AbiLAGRl (ORCPT ); Thu, 1 Dec 2022 01:17:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbiLAGRk (ORCPT ); Thu, 1 Dec 2022 01:17:40 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B3B62BE4; Wed, 30 Nov 2022 22:17:34 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id A77A424E1C7; Thu, 1 Dec 2022 14:17:26 +0800 (CST) Received: from EXMBX161.cuchost.com (172.16.6.71) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 1 Dec 2022 14:17:26 +0800 Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX161.cuchost.com (172.16.6.71) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 1 Dec 2022 14:17:26 +0800 Received: from EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e]) by EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e%16]) with mapi id 15.00.1497.044; Thu, 1 Dec 2022 14:17:26 +0800 From: JiaJie Ho To: "Conor.Dooley@microchip.com" CC: "robh+dt@kernel.org" , "herbert@gondor.apana.org.au" , "linux-crypto@vger.kernel.org" , "kernel@esmil.dk" , "davem@davemloft.net" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" Subject: RE: [PATCH 6/6] riscv: dts: starfive: Add crypto and DMA node for VisionFive 2 Thread-Topic: [PATCH 6/6] riscv: dts: starfive: Add crypto and DMA node for VisionFive 2 Thread-Index: AQHZBH/4vZHP2U3n+EalaiuTkXOjPK5WreUAgAHaqdA= Date: Thu, 1 Dec 2022 06:17:26 +0000 Message-ID: <4ddddceba3dc437daca27374dd2f6fd7@EXMBX068.cuchost.com> References: <20221130055214.2416888-1-jiajie.ho@starfivetech.com> <20221130055214.2416888-7-jiajie.ho@starfivetech.com> <1673ef8b-179e-3b03-b3f8-8d347c70d8c3@microchip.com> In-Reply-To: <1673ef8b-179e-3b03-b3f8-8d347c70d8c3@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [202.188.176.82] x-yovoleruleagent: yovoleflag Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQ29ub3IuRG9vbGV5QG1p Y3JvY2hpcC5jb20gPENvbm9yLkRvb2xleUBtaWNyb2NoaXAuY29tPg0KPiBTZW50OiBXZWRuZXNk YXksIE5vdmVtYmVyIDMwLCAyMDIyIDU6MzEgUE0NCj4gVG86IEppYUppZSBIbyA8amlhamllLmhv QHN0YXJmaXZldGVjaC5jb20+DQo+IENjOiByb2JoK2R0QGtlcm5lbC5vcmc7IGhlcmJlcnRAZ29u ZG9yLmFwYW5hLm9yZy5hdTsgbGludXgtDQo+IGNyeXB0b0B2Z2VyLmtlcm5lbC5vcmc7IGtlcm5l bEBlc21pbC5kazsgZGF2ZW1AZGF2ZW1sb2Z0Lm5ldDsNCj4gZGV2aWNldHJlZUB2Z2VyLmtlcm5l bC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LQ0KPiByaXNjdkBsaXN0 cy5pbmZyYWRlYWQub3JnOyBrcnp5c3p0b2Yua296bG93c2tpK2R0QGxpbmFyby5vcmcNCj4gU3Vi amVjdDogUmU6IFtQQVRDSCA2LzZdIHJpc2N2OiBkdHM6IHN0YXJmaXZlOiBBZGQgY3J5cHRvIGFu ZCBETUEgbm9kZSBmb3INCj4gVmlzaW9uRml2ZSAyDQo+IA0KPiBIZXkgSmlhIEppZSBIbywNCj4g DQo+IE9uIDMwLzExLzIwMjIgMDU6NTIsIEppYSBKaWUgSG8gd3JvdGU6DQo+ID4gW1lvdSBkb24n dCBvZnRlbiBnZXQgZW1haWwgZnJvbSBqaWFqaWUuaG9Ac3RhcmZpdmV0ZWNoLmNvbS4gTGVhcm4g d2h5DQo+ID4gdGhpcyBpcyBpbXBvcnRhbnQgYXQgaHR0cHM6Ly9ha2EubXMvTGVhcm5BYm91dFNl bmRlcklkZW50aWZpY2F0aW9uIF0NCj4gPg0KPiA+IEVYVEVSTkFMIEVNQUlMOiBEbyBub3QgY2xp Y2sgbGlua3Mgb3Igb3BlbiBhdHRhY2htZW50cyB1bmxlc3MgeW91IGtub3cNCj4gPiB0aGUgY29u dGVudCBpcyBzYWZlDQo+ID4NCj4gPiBBZGRpbmcgU3RhckZpdmUgY3J5cHRvIElQIGFuZCBETUEg Y29udHJvbGxlciBub2RlIHRvIFZpc2lvbkZpdmUgMiBTb0MuDQo+ID4NCj4gPiBTaWduZWQtb2Zm LWJ5OiBKaWEgSmllIEhvIDxqaWFqaWUuaG9Ac3RhcmZpdmV0ZWNoLmNvbT4NCj4gPiBTaWduZWQt b2ZmLWJ5OiBIdWFuIEZlbmcgPGh1YW4uZmVuZ0BzdGFyZml2ZXRlY2guY29tPg0KPiANCj4gT3V0 IG9mIGN1cmlvc2l0eSwgd2hhdCB3YXMgSHVhbiBGZW5nJ3MgY29udHJpYnV0aW9uIHRvIHRoaXMg cGF0Y2g/DQo+IERpZCB0aGV5IGNvLWRldmVsb3AgaXQsIG9yIGlzIHRoZXJlIHNvbWUgb3RoZXIg cmVhc29uPw0KPiANCkhpIENvbm9yLCANClllcywgSHVhbiBGZW5nIGNvLWRldmVsb3BlZCB0aGlz IGRyaXZlci4NCg0KPiA+IC0tLQ0KPiA+ICAgLi4uL2poNzExMC1zdGFyZml2ZS12aXNpb25maXZl LXYyLmR0cyAgICAgICAgIHwgIDggKysrKysNCj4gPiAgIGFyY2gvcmlzY3YvYm9vdC9kdHMvc3Rh cmZpdmUvamg3MTEwLmR0c2kgICAgICB8IDM2ICsrKysrKysrKysrKysrKysrKysNCj4gDQo+IEkg ZmlndXJlIEVtaWwgd2lsbCBsaWtlbHkgc2VlIGFueXdheSwgYnV0IHdoZW5ldmVyIHlvdSBnZXQg YWN0dWFsIHJldmlldw0KPiBjb21tZW50cyBhbmQgc2VuZCBhIHYyIC0gcGxlYXNlIGRvbid0IGRy b3AgcGVvcGxlIHRoYXQgZ2V0X21haW50YWluZXIucGwNCj4gdGVsbHMgeW91IGFyZSByZXNwb25z aWJsZSBmb3IgdGhlIGNvZGUgaW4gcXVlc3Rpb24uDQo+IA0KSSB3aWxsIGluY2x1ZGUgZXZlcnlv bmUgaW52b2x2ZWQgd2hlbiBzZW5kaW5nIHRoZSBuZXcgcGF0Y2ggc2VyaWVzLg0KDQo+ID4gICAy IGZpbGVzIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKykNCj4gPg0KPiA+IGRpZmYgLS1naXQNCj4g PiBhL2FyY2gvcmlzY3YvYm9vdC9kdHMvc3RhcmZpdmUvamg3MTEwLXN0YXJmaXZlLXZpc2lvbmZp dmUtdjIuZHRzDQo+ID4gYi9hcmNoL3Jpc2N2L2Jvb3QvZHRzL3N0YXJmaXZlL2poNzExMC1zdGFy Zml2ZS12aXNpb25maXZlLXYyLmR0cw0KPiA+IGluZGV4IDQ1MGU5MjAyMzZhNS4uZGEyYWE0ZDU5 N2YzIDEwMDY0NA0KPiA+IC0tLSBhL2FyY2gvcmlzY3YvYm9vdC9kdHMvc3RhcmZpdmUvamg3MTEw LXN0YXJmaXZlLXZpc2lvbmZpdmUtdjIuZHRzDQo+ID4gKysrIGIvYXJjaC9yaXNjdi9ib290L2R0 cy9zdGFyZml2ZS9qaDcxMTAtc3RhcmZpdmUtdmlzaW9uZml2ZS12Mi5kdHMNCj4gPiBAQCAtMTE1 LDMgKzExNSwxMSBAQCAmdGRtX2V4dCB7DQo+ID4gICAmbWNsa19leHQgew0KPiA+ICAgICAgICAg IGNsb2NrLWZyZXF1ZW5jeSA9IDw0OTE1MjAwMD47DQo+ID4gICB9Ow0KPiA+ICsNCj4gPiArJnNl Y19kbWEgew0KPiA+ICsgICAgICAgc3RhdHVzID0gIm9rYXkiOw0KPiA+ICt9Ow0KPiA+ICsNCj4g PiArJmNyeXB0byB7DQo+ID4gKyAgICAgICBzdGF0dXMgPSAib2theSI7DQo+ID4gK307DQo+IA0K PiBJbiB3aGF0IHNjZW5hcmlvIHdvdWxkIHlvdSBub3Qgd2FudCB0byBoYXZlIHRoZXNlIGVuYWJs ZWQ/DQo+IA0KPiBUaGFua3MsDQo+IENvbm9yLg0KPiANClRoZXNlIGRyaXZlcnMgYXJlIGFsd2F5 cyBlbmFibGVkLiANCklzIGV2ZXJ5dGhpbmcgb2sgd2l0aCB0aGUgZHRzIG5vZGUgZW50cmllcz8N ClRoYW5rIHlvdSBmb3Igc3BlbmRpbmcgdGltZSByZXZpZXdpbmcgYW5kIHByb3ZpZGluZyBzdWdn ZXN0aW9ucyBmb3IgdGhpcyBwYXRjaC4NCg0KUmVnYXJkcywNCkppYSBKaWUNCg0KPiA+IGRpZmYg LS1naXQgYS9hcmNoL3Jpc2N2L2Jvb3QvZHRzL3N0YXJmaXZlL2poNzExMC5kdHNpDQo+ID4gYi9h cmNoL3Jpc2N2L2Jvb3QvZHRzL3N0YXJmaXZlL2poNzExMC5kdHNpDQo+ID4gaW5kZXggNGFjMTU5 ZDc5ZDY2Li43NDVhNTY1MDg4MmMgMTAwNjQ0DQo+ID4gLS0tIGEvYXJjaC9yaXNjdi9ib290L2R0 cy9zdGFyZml2ZS9qaDcxMTAuZHRzaQ0KPiA+ICsrKyBiL2FyY2gvcmlzY3YvYm9vdC9kdHMvc3Rh cmZpdmUvamg3MTEwLmR0c2kNCj4gPiBAQCAtNDU1LDUgKzQ1NSw0MSBAQCB1YXJ0NTogc2VyaWFs QDEyMDIwMDAwIHsNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnLXNoaWZ0ID0gPDI+ Ow0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0dXMgPSAiZGlzYWJsZWQiOw0KPiA+ ICAgICAgICAgICAgICAgICAgfTsNCj4gPiArDQo+ID4gKyAgICAgICAgICAgICAgIHNlY19kbWE6 IHNlY19kbWFAMTYwMDgwMDAgew0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGNvbXBhdGli bGUgPSAiYXJtLHBsMDgwIiwgImFybSxwcmltZWNlbGwiOw0KPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgIGFybSxwcmltZWNlbGwtcGVyaXBoaWQgPSA8MHgwMDA0MTA4MD47DQo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgcmVnID0gPDB4MCAweDE2MDA4MDAwIDB4MCAweDQwMDA+Ow0KPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgIHJlZy1uYW1lcyA9ICJzZWNfZG1hIjsNCj4gPiArICAg ICAgICAgICAgICAgICAgICAgICBpbnRlcnJ1cHRzID0gPDI5PjsNCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICBjbG9ja3MgPSA8JnN0Z2NyZyBKSDcxMTBfU1RHQ0xLX1NFQ19IQ0xLPiwNCj4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8JnN0Z2NyZyBKSDcxMTBfU1RHQ0xL X1NFQ19NSVNDQUhCPjsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBjbG9jay1uYW1lcyA9 ICJzZWNfaGNsayIsImFwYl9wY2xrIjsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICByZXNl dHMgPSA8JnN0Z2NyZyBKSDcxMTBfU1RHUlNUX1NFQ19UT1BfSFJFU0VUTj47DQo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgcmVzZXQtbmFtZXMgPSAic2VjX2hyZSI7DQo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgbGxpLWJ1cy1pbnRlcmZhY2UtYWhiMTsNCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICBtZW0tYnVzLWludGVyZmFjZS1haGIxOw0KPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgIG1lbWNweS1idXJzdC1zaXplID0gPDI1Nj47DQo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgbWVtY3B5LWJ1cy13aWR0aCA9IDwzMj47DQo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgI2RtYS1jZWxscyA9IDwyPjsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBzdGF0dXMg PSAiZGlzYWJsZWQiOw0KPiA+ICsgICAgICAgICAgICAgICB9Ow0KPiA+ICsNCj4gPiArICAgICAg ICAgICAgICAgY3J5cHRvOiBjcnlwdG9AMTYwMDAwMDAgew0KPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgIGNvbXBhdGlibGUgPSAic3RhcmZpdmUsamg3MTEwLWNyeXB0byI7DQo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgcmVnID0gPDB4MCAweDE2MDAwMDAwIDB4MCAweDQwMDA+Ow0KPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgIHJlZy1uYW1lcyA9ICJzZWNyZWciOw0KPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmc3RnY3JnIEpINzExMF9TVEdDTEtfU0VDX0hD TEs+LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwmc3RnY3JnIEpINzEx MF9TVEdDTEtfU0VDX01JU0NBSEI+Ow0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGNsb2Nr LW5hbWVzID0gInNlY19oY2xrIiwic2VjX2FoYiI7DQo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgcmVzZXRzID0gPCZzdGdjcmcgSkg3MTEwX1NUR1JTVF9TRUNfVE9QX0hSRVNFVE4+Ow0KPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgIHJlc2V0LW5hbWVzID0gInNlY19ocmUiOw0KPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgIGVuYWJsZS1zaWRlLWNoYW5uZWwtbWl0aWdhdGlvbjsNCj4g PiArICAgICAgICAgICAgICAgICAgICAgICBlbmFibGUtZG1hOw0KPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgIGRtYXMgPSA8JnNlY19kbWEgMSAyPiwNCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgPCZzZWNfZG1hIDAgMj47DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ZG1hLW5hbWVzID0gInNlY19tIiwic2VjX3AiOw0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAg IHN0YXR1cyA9ICJkaXNhYmxlZCI7DQo+ID4gKyAgICAgICAgICAgICAgIH07DQo+ID4gICAgICAg ICAgfTsNCj4gPiAgIH07DQo+ID4gLS0NCj4gPiAyLjI1LjENCj4gPg0KPiA+DQo+ID4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCj4gPiBsaW51eC1yaXNj diBtYWlsaW5nIGxpc3QNCj4gPiBsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnDQo+ID4g aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdg0K DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03EEDC43217 for ; Thu, 1 Dec 2022 06:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qZ/1yZXZ2ZmUDZq0WILz7obyeYBFeaz/D5/afugEGko=; b=ni7TJ8HxWkboYH vQ6Os3gVDOGZPfFJ31W3aMqXT+7M87TxxIJlTRyH31hQw+lWPEOdHbRnvHfK4CqtJxF5halh3b5KI R4ZXyziO8RV7q+Vgyv0AOszrG7Ijr4lkdxxIQGmZcLqQahvL1TyuRF7F8q8pTp8O43QWiG2bV8dpj puPmSrgFQDhDZvyrcwDLNdSwNU/dIYE+9eKbPjW7nhfeJRQvWNAAC1k8ysfNYAU/VN/63Gn1sdOMf g1fy+HUEkmvIfOxnuRZUBCoING+vUU4w5pOEvkvPweKGf/P6NdTjG9NTA4LvEADna7ADF2R38S17o XCpxbdl9IytVPPOkpOAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0cu8-005Ajb-3K; Thu, 01 Dec 2022 06:18:40 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0cu2-005AV7-Sg for linux-riscv@lists.infradead.org; Thu, 01 Dec 2022 06:18:37 +0000 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id A77A424E1C7; Thu, 1 Dec 2022 14:17:26 +0800 (CST) Received: from EXMBX161.cuchost.com (172.16.6.71) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 1 Dec 2022 14:17:26 +0800 Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX161.cuchost.com (172.16.6.71) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 1 Dec 2022 14:17:26 +0800 Received: from EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e]) by EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e%16]) with mapi id 15.00.1497.044; Thu, 1 Dec 2022 14:17:26 +0800 From: JiaJie Ho To: "Conor.Dooley@microchip.com" CC: "robh+dt@kernel.org" , "herbert@gondor.apana.org.au" , "linux-crypto@vger.kernel.org" , "kernel@esmil.dk" , "davem@davemloft.net" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" Subject: RE: [PATCH 6/6] riscv: dts: starfive: Add crypto and DMA node for VisionFive 2 Thread-Topic: [PATCH 6/6] riscv: dts: starfive: Add crypto and DMA node for VisionFive 2 Thread-Index: AQHZBH/4vZHP2U3n+EalaiuTkXOjPK5WreUAgAHaqdA= Date: Thu, 1 Dec 2022 06:17:26 +0000 Message-ID: <4ddddceba3dc437daca27374dd2f6fd7@EXMBX068.cuchost.com> References: <20221130055214.2416888-1-jiajie.ho@starfivetech.com> <20221130055214.2416888-7-jiajie.ho@starfivetech.com> <1673ef8b-179e-3b03-b3f8-8d347c70d8c3@microchip.com> In-Reply-To: <1673ef8b-179e-3b03-b3f8-8d347c70d8c3@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [202.188.176.82] x-yovoleruleagent: yovoleflag MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221130_221835_380989_1BCC1E95 X-CRM114-Status: GOOD ( 26.76 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Conor.Dooley@microchip.com > Sent: Wednesday, November 30, 2022 5:31 PM > To: JiaJie Ho > Cc: robh+dt@kernel.org; herbert@gondor.apana.org.au; linux- > crypto@vger.kernel.org; kernel@esmil.dk; davem@davemloft.net; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > riscv@lists.infradead.org; krzysztof.kozlowski+dt@linaro.org > Subject: Re: [PATCH 6/6] riscv: dts: starfive: Add crypto and DMA node for > VisionFive 2 > > Hey Jia Jie Ho, > > On 30/11/2022 05:52, Jia Jie Ho wrote: > > [You don't often get email from jiajie.ho@starfivetech.com. Learn why > > this is important at https://aka.ms/LearnAboutSenderIdentification ] > > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > the content is safe > > > > Adding StarFive crypto IP and DMA controller node to VisionFive 2 SoC. > > > > Signed-off-by: Jia Jie Ho > > Signed-off-by: Huan Feng > > Out of curiosity, what was Huan Feng's contribution to this patch? > Did they co-develop it, or is there some other reason? > Hi Conor, Yes, Huan Feng co-developed this driver. > > --- > > .../jh7110-starfive-visionfive-v2.dts | 8 +++++ > > arch/riscv/boot/dts/starfive/jh7110.dtsi | 36 +++++++++++++++++++ > > I figure Emil will likely see anyway, but whenever you get actual review > comments and send a v2 - please don't drop people that get_maintainer.pl > tells you are responsible for the code in question. > I will include everyone involved when sending the new patch series. > > 2 files changed, 44 insertions(+) > > > > diff --git > > a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts > > b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts > > index 450e920236a5..da2aa4d597f3 100644 > > --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts > > +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts > > @@ -115,3 +115,11 @@ &tdm_ext { > > &mclk_ext { > > clock-frequency = <49152000>; > > }; > > + > > +&sec_dma { > > + status = "okay"; > > +}; > > + > > +&crypto { > > + status = "okay"; > > +}; > > In what scenario would you not want to have these enabled? > > Thanks, > Conor. > These drivers are always enabled. Is everything ok with the dts node entries? Thank you for spending time reviewing and providing suggestions for this patch. Regards, Jia Jie > > diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi > > b/arch/riscv/boot/dts/starfive/jh7110.dtsi > > index 4ac159d79d66..745a5650882c 100644 > > --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi > > +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi > > @@ -455,5 +455,41 @@ uart5: serial@12020000 { > > reg-shift = <2>; > > status = "disabled"; > > }; > > + > > + sec_dma: sec_dma@16008000 { > > + compatible = "arm,pl080", "arm,primecell"; > > + arm,primecell-periphid = <0x00041080>; > > + reg = <0x0 0x16008000 0x0 0x4000>; > > + reg-names = "sec_dma"; > > + interrupts = <29>; > > + clocks = <&stgcrg JH7110_STGCLK_SEC_HCLK>, > > + <&stgcrg JH7110_STGCLK_SEC_MISCAHB>; > > + clock-names = "sec_hclk","apb_pclk"; > > + resets = <&stgcrg JH7110_STGRST_SEC_TOP_HRESETN>; > > + reset-names = "sec_hre"; > > + lli-bus-interface-ahb1; > > + mem-bus-interface-ahb1; > > + memcpy-burst-size = <256>; > > + memcpy-bus-width = <32>; > > + #dma-cells = <2>; > > + status = "disabled"; > > + }; > > + > > + crypto: crypto@16000000 { > > + compatible = "starfive,jh7110-crypto"; > > + reg = <0x0 0x16000000 0x0 0x4000>; > > + reg-names = "secreg"; > > + clocks = <&stgcrg JH7110_STGCLK_SEC_HCLK>, > > + <&stgcrg JH7110_STGCLK_SEC_MISCAHB>; > > + clock-names = "sec_hclk","sec_ahb"; > > + resets = <&stgcrg JH7110_STGRST_SEC_TOP_HRESETN>; > > + reset-names = "sec_hre"; > > + enable-side-channel-mitigation; > > + enable-dma; > > + dmas = <&sec_dma 1 2>, > > + <&sec_dma 0 2>; > > + dma-names = "sec_m","sec_p"; > > + status = "disabled"; > > + }; > > }; > > }; > > -- > > 2.25.1 > > > > > > _______________________________________________ > > linux-riscv mailing list > > linux-riscv@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-riscv _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv