From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 434ACC433EF for ; Mon, 11 Jul 2022 11:28:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231443AbiGKL21 (ORCPT ); Mon, 11 Jul 2022 07:28:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231214AbiGKL1r (ORCPT ); Mon, 11 Jul 2022 07:27:47 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E533AE4B for ; Mon, 11 Jul 2022 04:05:27 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id d12so8045680lfq.12 for ; Mon, 11 Jul 2022 04:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=dPrZfAXq7F8ce8t3fuNDg51KlRMukh3iZYk9RgLqoNE=; b=Ss7HyQSh+ofbEmUv0VvjsNobh4eJuEu0heIwrqhODc6RsT3ooq+uTYDKAmfXJiLl1g lcpPVr6IKvLmIYxxIJxpBgYmaD9ce+ueRFIeW3xkkBS+Mw8BvqtSW6HB5yt7N/GCqR7N Dhu0CgbfeUwhJSwtVmNiQHibrjkqYGlOPKjWoKIvEnnoIb5n7KsSeYDAhcW7bRwHrQlV HwfLcVKbF5DRSrVXPLdx1xsIEC2c4zUVhBqH6pGqaCRMdpj/h0CDTFMhfpBeAtEjh45r 2HKdKVbE08UkUyGZtuU8L3chtY+xQrdNQHmNmaPl4QrCTzroaZ+z3Isr/rm5lozyh+HR ks6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=dPrZfAXq7F8ce8t3fuNDg51KlRMukh3iZYk9RgLqoNE=; b=jVfMbYgTI/ifdakZkoq+b8eYNk6r2O5K9uKjcCsxvjKUdftZjJuihOEBnIy6Ly4nyo 4Im+I9pjDhpwWd7W+0siLcnejxMh7AsSJiMyXeDBZrvFXfKltGvrtsnb0EDFhoCwlPP1 nDKa1VvKewQJsPrw0cgtTI5LyfruduXYPvVN5nvWtUfT+jvwTREv/4NPM17uz3ODZ4cq upf9fJtjAmfWP5Oot1lxIO+IeGR3YkjQhmwR6P3b2kxJwwxilv7JXBipvq/OWuzj6wcq rby3yqlkEqodHbSRVw8iaO2cC3mtCShDa843Yg61yQuLpD9+/a7PGDfMYnTht+/dAelX vzxg== X-Gm-Message-State: AJIora/TbJR12u0QY2fHEmUasjE7mDpt/5YZ1ctp5/6xLCoyNtHqsHaN 8pvfCq6oes3vCuE6FX5V51aSHkhlSBTXW6g7 X-Google-Smtp-Source: AGRyM1u/jw24PhqwPc6UTV/hyxk2KaW3EecjOe9Ez/DY3S2cBKdbASV5EDr17T6xbqPGPzK8st+IRw== X-Received: by 2002:a05:6512:1310:b0:481:6154:c292 with SMTP id x16-20020a056512131000b004816154c292mr11134909lfu.95.1657537525579; Mon, 11 Jul 2022 04:05:25 -0700 (PDT) Received: from [10.0.0.8] (fwa5cab-55.bb.online.no. [88.92.171.55]) by smtp.gmail.com with ESMTPSA id w21-20020a05651c119500b00255500154fasm1681683ljo.52.2022.07.11.04.05.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 04:05:25 -0700 (PDT) Message-ID: <4de38d90-0020-c2db-b283-319b4a0e2ce5@linaro.org> Date: Mon, 11 Jul 2022 13:05:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/6] clk: qcom: apss-ipq6018: add MODULE_ALIAS Content-Language: en-US To: Robert Marko , bjorn.andersson@linaro.org, agross@kernel.org, konrad.dybcio@somainline.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sivaprak@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220711104719.40939-1-robimarko@gmail.com> <20220711104719.40939-4-robimarko@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220711104719.40939-4-robimarko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 11/07/2022 12:47, Robert Marko wrote: > Add MODULE_ALIAS so that driver will be autoloaded if built as a module. > > Signed-off-by: Robert Marko > --- > drivers/clk/qcom/apss-ipq6018.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/apss-ipq6018.c b/drivers/clk/qcom/apss-ipq6018.c > index f2f502e2d5a4..963c69f2c0c2 100644 > --- a/drivers/clk/qcom/apss-ipq6018.c > +++ b/drivers/clk/qcom/apss-ipq6018.c > @@ -101,5 +101,6 @@ static struct platform_driver apss_ipq6018_driver = { > > module_platform_driver(apss_ipq6018_driver); > > +MODULE_ALIAS("platform:qcom,apss-ipq6018-clk"); That's not correct alias (no commas) and usually alias is not needed at all. If you need one, please explain why it is needed. Module autoloading works fine without aliases... Best regards, Krzysztof