From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1F96C433EF for ; Fri, 13 May 2022 16:25:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229935AbiEMQZo (ORCPT ); Fri, 13 May 2022 12:25:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233992AbiEMQZo (ORCPT ); Fri, 13 May 2022 12:25:44 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 377C98E199 for ; Fri, 13 May 2022 09:25:42 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id h16so11423785wrb.2 for ; Fri, 13 May 2022 09:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=pWKM0MBdI2EXI4pLoR/+4e311xPtdPa4XXrZxBV0DhU=; b=VI1nm+5Jsi+Be7G1b2OqP2KXMA+mCV/Sp8eFrKYLkVQaWFihr6IVX6ykzOm0+eZ1GY c+qR1DAiG9vnfUJnZui9Lyl1dEkJFtdQfFk4Qp68U8oJ3l7JP/sLcT2f1B1EAlzjPAPF L35otRSiesaaYb8l9ensh4v53OGAnHTRIchXmYDY55vKSOn3RWcHhcsgRtvWnPL5AhSM HNquXKKtsrQldmr3bvq/vccIQASyPvnSu3YJt4P5AcMQVyrdNzZuC0QjT1Tt7OI0/lBf hWKCQqrZbkgbIOaAFNbFtEjSAu5l7fSgXXOsXFSEJSEctF0CT3aSA6mY9MDrlDx1VY9W yLMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pWKM0MBdI2EXI4pLoR/+4e311xPtdPa4XXrZxBV0DhU=; b=BVe84i4SN8BGNtRLl/RMlbpizi1o+OA05JUpe17nCekOteUdJEWZ6trMUwDQSGxGx+ GS9p1Wl5Pqzr03zX8xpl2X2CoNG2GyhNzNVh3zmyY++ZrlXw402+OI0ECL3OTcL4pjZv MTohuyot9ODZ60QyBmPNQhiY/sulPT5eJkYWGtxvEbQpax/g+EAZTJPF6zAK+tMDf/mx WkIAzIvd79RG2/+pz/GefiOYVGvx/ZXrJjGp1ZKyQTV7R4TuFt2SlT8gw83YSktbLVXd Yot82rzgKbSRPW5vJZXkoomeyNjVgChIN1s7noB+Bf2DK0ZQlvE5DHsLbTKDH9f3/f/T 8lxQ== X-Gm-Message-State: AOAM530Tdy+n1tHgR34iD9rO9u/MqDs6+/VdP/HS+MHNTGW7wS7PmJaS Kv+8EnMK9bTNoMs2uQpDV3139Q== X-Google-Smtp-Source: ABdhPJxqfYPYfaiF6Ttkf9rjeedRQdbuPmmPibHhv95AmmQ7EooiJaPxsic0ElNHElUUfzJOkE4GYQ== X-Received: by 2002:adf:f24d:0:b0:20c:f5a0:be7e with SMTP id b13-20020adff24d000000b0020cf5a0be7emr1261010wrp.344.1652459140704; Fri, 13 May 2022 09:25:40 -0700 (PDT) Received: from [192.168.1.41] (static-176-182-171-101.ncc.abo.bbox.fr. [176.182.171.101]) by smtp.googlemail.com with ESMTPSA id r64-20020a1c2b43000000b003942a244edbsm3926858wmr.32.2022.05.13.09.25.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 09:25:40 -0700 (PDT) Message-ID: <4de41b5e-1fa6-ece4-9d9a-2656d399b452@linaro.org> Date: Fri, 13 May 2022 18:25:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v1] thermal: imx: Update critical temp threshold Content-Language: en-US To: Francesco Dolcini Cc: Lucas Stach , Sascha Hauer , Shawn Guo , linux-pm@vger.kernel.org, Tim Harvey , Amit Kucheria , Jon Nettleton , NXP Linux Team , Pengutronix Kernel Team , "Rafael J . Wysocki" , Fabio Estevam , linux-arm-kernel@lists.infradead.org References: <20220420091300.179753-1-francesco.dolcini@toradex.com> <486c5c72-812a-d4ea-0c5a-49783bdc4a1f@linaro.org> <20220512073600.GA36153@francesco-nb.int.toradex.com> <6918b1a7ba401cd4db2db0601137766acd93bc63.camel@pengutronix.de> <20220512102454.GA39979@francesco-nb.int.toradex.com> <7f5a919c-2fa1-a463-1f6b-6b531d5ee27d@linaro.org> <20220512135653.GB39979@francesco-nb.int.toradex.com> From: Daniel Lezcano In-Reply-To: <20220512135653.GB39979@francesco-nb.int.toradex.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 12/05/2022 15:56, Francesco Dolcini wrote: > On Thu, May 12, 2022 at 12:52:46PM +0200, Daniel Lezcano wrote: >> On 12/05/2022 12:24, Francesco Dolcini wrote: >>> Hello Lucas, >>> >>> On Thu, May 12, 2022 at 12:08:08PM +0200, Lucas Stach wrote: >>>> Am Donnerstag, dem 12.05.2022 um 09:36 +0200 schrieb Francesco Dolcini: >> >> [ ... ] >> >>> Anyway, would it be fine to have a patch that make the critical >>> threshold write-able (in my initial message I mentioned this as my >>> preferred solution also)? If anybody has a pointer on how >>> to do it, it would be great, I'm not familiar with that code. >> >> What about a module param ? > > I would be happy to just be able to write to the `critical` > trip_point_temp file in sysfs, however the thermal > framework seems to enforce the critical threshold being read only (only > `get_trip_temp` callback available). Is there any way to change this? No, critical trip point is not a system setting but a hardware setting. It should be set via the DT or a module parameter. > # cat /sys/class/thermal/thermal_zone0/trip_point_1_type > critical > # ls -l /sys/class/thermal/thermal_zone0/trip_point_1_temp > -r--r--r-- 1 root root 4096 May 6 14:33 /sys/class/thermal/thermal_zone0/trip_point_1_temp -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01131C433F5 for ; Fri, 13 May 2022 16:26:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JCEBb8izoj3+ZZr6DgziQOzlLXEzFRaPiILdQo23gek=; b=Q8R/3RsFfv/Io0 lvatUAA3ATg+gc3imkUt+Ezz4sN4WrrOxSxrmcPDINQcSta52VdDyUHE+vuGBorDA4fUHgah6glbP ZANXkkHGGK61QFizgp0fj+23tF3dAOmBaIs8MrGsfdfhsptJtIBKVSV8KdC8spg5GbPPE8okqvvQl eM9kllsMVQogk2TF7m7klNHsI6SJfOduFyoPpuoHj+0XrH/tA6YNwduTuyK6QWwSboUc+nr2pAUrf a6Mocgv7xjHRcoE4k/qiDqwbS9ZviWBilN+NSYuxgYck098TzwmEvqju+uNl1qG4KKNT2WYfF6pVU e73pUTLssc6FQ8sKqoWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npY6t-00GqM0-55; Fri, 13 May 2022 16:25:47 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npY6p-00GqJI-Gx for linux-arm-kernel@lists.infradead.org; Fri, 13 May 2022 16:25:45 +0000 Received: by mail-wr1-x429.google.com with SMTP id u3so12142520wrg.3 for ; Fri, 13 May 2022 09:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=pWKM0MBdI2EXI4pLoR/+4e311xPtdPa4XXrZxBV0DhU=; b=VI1nm+5Jsi+Be7G1b2OqP2KXMA+mCV/Sp8eFrKYLkVQaWFihr6IVX6ykzOm0+eZ1GY c+qR1DAiG9vnfUJnZui9Lyl1dEkJFtdQfFk4Qp68U8oJ3l7JP/sLcT2f1B1EAlzjPAPF L35otRSiesaaYb8l9ensh4v53OGAnHTRIchXmYDY55vKSOn3RWcHhcsgRtvWnPL5AhSM HNquXKKtsrQldmr3bvq/vccIQASyPvnSu3YJt4P5AcMQVyrdNzZuC0QjT1Tt7OI0/lBf hWKCQqrZbkgbIOaAFNbFtEjSAu5l7fSgXXOsXFSEJSEctF0CT3aSA6mY9MDrlDx1VY9W yLMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pWKM0MBdI2EXI4pLoR/+4e311xPtdPa4XXrZxBV0DhU=; b=BNDk6c19TT4gA8vTJhhGvASwnovBgZ0NCZf2bvptHQed/q3VBZUIt35iMgA4xHvj6v RpzSaC8YXdcu/80N+L0twF2QR2yvnNqMHyqYkODkxgx/4dyv1D8fsvGwZRhJrmOUBtXo Sj9PnewhRCplU6zB6lOOEXrj7ecpDhpH3+qSuRd+OauTYeKgA1oeJZXuwubrOs/yQNog zZlz6C+LbWoHW6YSfT4iutQ6suAcEFRNaezHdNxEUU2X84iAppaBanGjbSMl6HVVoZH5 IrYttNFsPJEeeWNC4zZnzTU7H6QzNof4ZpPmmoLi52IufyKn/6K+O8L667c9AYA+AlUd tPcg== X-Gm-Message-State: AOAM530iK2DZQMZQT9vTm8NZslrZ3tXXrCvjSxzmQTlMAxe1YAtGJtsS Ka3MNJXdeqa2pbaQbTKMUP3O9Q== X-Google-Smtp-Source: ABdhPJxqfYPYfaiF6Ttkf9rjeedRQdbuPmmPibHhv95AmmQ7EooiJaPxsic0ElNHElUUfzJOkE4GYQ== X-Received: by 2002:adf:f24d:0:b0:20c:f5a0:be7e with SMTP id b13-20020adff24d000000b0020cf5a0be7emr1261010wrp.344.1652459140704; Fri, 13 May 2022 09:25:40 -0700 (PDT) Received: from [192.168.1.41] (static-176-182-171-101.ncc.abo.bbox.fr. [176.182.171.101]) by smtp.googlemail.com with ESMTPSA id r64-20020a1c2b43000000b003942a244edbsm3926858wmr.32.2022.05.13.09.25.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 09:25:40 -0700 (PDT) Message-ID: <4de41b5e-1fa6-ece4-9d9a-2656d399b452@linaro.org> Date: Fri, 13 May 2022 18:25:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v1] thermal: imx: Update critical temp threshold Content-Language: en-US To: Francesco Dolcini Cc: Lucas Stach , Sascha Hauer , Shawn Guo , linux-pm@vger.kernel.org, Tim Harvey , Amit Kucheria , Jon Nettleton , NXP Linux Team , Pengutronix Kernel Team , "Rafael J . Wysocki" , Fabio Estevam , linux-arm-kernel@lists.infradead.org References: <20220420091300.179753-1-francesco.dolcini@toradex.com> <486c5c72-812a-d4ea-0c5a-49783bdc4a1f@linaro.org> <20220512073600.GA36153@francesco-nb.int.toradex.com> <6918b1a7ba401cd4db2db0601137766acd93bc63.camel@pengutronix.de> <20220512102454.GA39979@francesco-nb.int.toradex.com> <7f5a919c-2fa1-a463-1f6b-6b531d5ee27d@linaro.org> <20220512135653.GB39979@francesco-nb.int.toradex.com> From: Daniel Lezcano In-Reply-To: <20220512135653.GB39979@francesco-nb.int.toradex.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220513_092543_610492_8BFC7D02 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTIvMDUvMjAyMiAxNTo1NiwgRnJhbmNlc2NvIERvbGNpbmkgd3JvdGU6Cj4gT24gVGh1LCBN YXkgMTIsIDIwMjIgYXQgMTI6NTI6NDZQTSArMDIwMCwgRGFuaWVsIExlemNhbm8gd3JvdGU6Cj4+ IE9uIDEyLzA1LzIwMjIgMTI6MjQsIEZyYW5jZXNjbyBEb2xjaW5pIHdyb3RlOgo+Pj4gSGVsbG8g THVjYXMsCj4+Pgo+Pj4gT24gVGh1LCBNYXkgMTIsIDIwMjIgYXQgMTI6MDg6MDhQTSArMDIwMCwg THVjYXMgU3RhY2ggd3JvdGU6Cj4+Pj4gQW0gRG9ubmVyc3RhZywgZGVtIDEyLjA1LjIwMjIgdW0g MDk6MzYgKzAyMDAgc2NocmllYiBGcmFuY2VzY28gRG9sY2luaToKPj4KPj4gWyAuLi4gXQo+Pgo+ Pj4gQW55d2F5LCB3b3VsZCBpdCBiZSBmaW5lIHRvIGhhdmUgYSBwYXRjaCB0aGF0IG1ha2UgdGhl IGNyaXRpY2FsCj4+PiB0aHJlc2hvbGQgd3JpdGUtYWJsZSAoaW4gbXkgaW5pdGlhbCBtZXNzYWdl IEkgbWVudGlvbmVkIHRoaXMgYXMgbXkKPj4+IHByZWZlcnJlZCBzb2x1dGlvbiBhbHNvKT8gSWYg YW55Ym9keSBoYXMgYSBwb2ludGVyIG9uIGhvdwo+Pj4gdG8gZG8gaXQsIGl0IHdvdWxkIGJlIGdy ZWF0LCBJJ20gbm90IGZhbWlsaWFyIHdpdGggdGhhdCBjb2RlLgo+Pgo+PiBXaGF0IGFib3V0IGEg bW9kdWxlIHBhcmFtID8KPiAKPiBJIHdvdWxkIGJlIGhhcHB5IHRvIGp1c3QgYmUgYWJsZSB0byB3 cml0ZSB0byB0aGUgYGNyaXRpY2FsYAo+IHRyaXBfcG9pbnRfdGVtcCBmaWxlIGluIHN5c2ZzLCBo b3dldmVyIHRoZSB0aGVybWFsCj4gZnJhbWV3b3JrIHNlZW1zIHRvIGVuZm9yY2UgdGhlIGNyaXRp Y2FsIHRocmVzaG9sZCBiZWluZyByZWFkIG9ubHkgKG9ubHkKPiBgZ2V0X3RyaXBfdGVtcGAgY2Fs bGJhY2sgYXZhaWxhYmxlKS4gSXMgdGhlcmUgYW55IHdheSB0byBjaGFuZ2UgdGhpcz8KCk5vLCBj cml0aWNhbCB0cmlwIHBvaW50IGlzIG5vdCBhIHN5c3RlbSBzZXR0aW5nIGJ1dCBhIGhhcmR3YXJl IHNldHRpbmcuCgpJdCBzaG91bGQgYmUgc2V0IHZpYSB0aGUgRFQgb3IgYSBtb2R1bGUgcGFyYW1l dGVyLgoKCj4gIyBjYXQgL3N5cy9jbGFzcy90aGVybWFsL3RoZXJtYWxfem9uZTAvdHJpcF9wb2lu dF8xX3R5cGUKPiBjcml0aWNhbAo+ICMgbHMgLWwgL3N5cy9jbGFzcy90aGVybWFsL3RoZXJtYWxf em9uZTAvdHJpcF9wb2ludF8xX3RlbXAKPiAtci0tci0tci0tIDEgcm9vdCByb290IDQwOTYgTWF5 ICA2IDE0OjMzIC9zeXMvY2xhc3MvdGhlcm1hbC90aGVybWFsX3pvbmUwL3RyaXBfcG9pbnRfMV90 ZW1wCgoKCgoKLS0gCjxodHRwOi8vd3d3LmxpbmFyby5vcmcvPiBMaW5hcm8ub3JnIOKUgiBPcGVu IHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKCkZvbGxvdyBMaW5hcm86ICA8aHR0cDovL3d3 dy5mYWNlYm9vay5jb20vcGFnZXMvTGluYXJvPiBGYWNlYm9vayB8CjxodHRwOi8vdHdpdHRlci5j b20vIyEvbGluYXJvb3JnPiBUd2l0dGVyIHwKPGh0dHA6Ly93d3cubGluYXJvLm9yZy9saW5hcm8t YmxvZy8+IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK