All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Machata <petrm@mellanox.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jiri Pirko <jiri@mellanox.com>,
	Ido Schimmel <idosch@mellanox.com>,
	David Ahern <dsa@cumulusnetworks.com>
Subject: [PATCH net-next v2 3/8] net: ipvlan: ipvlan_set_port_mode(): Add an extack argument
Date: Thu, 6 Dec 2018 17:05:40 +0000	[thread overview]
Message-ID: <4df7c89337f60f47281f00ae0adb6e698d6786c5.1544115501.git.petrm@mellanox.com> (raw)
In-Reply-To: <cover.1544115501.git.petrm@mellanox.com>

A follow-up patch will extend dev_change_flags() with an extack
argument. Extend ipvlan_set_port_mode() to have that argument available
for the conversion.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
---
 drivers/net/ipvlan/ipvlan_main.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index 4a949569ec4c..14f1cbd3b96f 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -71,7 +71,8 @@ static void ipvlan_unregister_nf_hook(struct net *net)
 					ARRAY_SIZE(ipvl_nfops));
 }
 
-static int ipvlan_set_port_mode(struct ipvl_port *port, u16 nval)
+static int ipvlan_set_port_mode(struct ipvl_port *port, u16 nval,
+				struct netlink_ext_ack *extack)
 {
 	struct ipvl_dev *ipvlan;
 	struct net_device *mdev = port->dev;
@@ -498,7 +499,7 @@ static int ipvlan_nl_changelink(struct net_device *dev,
 	if (data[IFLA_IPVLAN_MODE]) {
 		u16 nmode = nla_get_u16(data[IFLA_IPVLAN_MODE]);
 
-		err = ipvlan_set_port_mode(port, nmode);
+		err = ipvlan_set_port_mode(port, nmode, extack);
 	}
 
 	if (!err && data[IFLA_IPVLAN_FLAGS]) {
@@ -672,7 +673,7 @@ int ipvlan_link_new(struct net *src_net, struct net_device *dev,
 	if (data && data[IFLA_IPVLAN_MODE])
 		mode = nla_get_u16(data[IFLA_IPVLAN_MODE]);
 
-	err = ipvlan_set_port_mode(port, mode);
+	err = ipvlan_set_port_mode(port, mode, extack);
 	if (err)
 		goto unlink_netdev;
 
-- 
2.4.11

  parent reply	other threads:[~2018-12-06 17:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 17:05 [PATCH net-next v2 0/8] Pass extack to NETDEV_PRE_UP Petr Machata
2018-12-06 17:05 ` [PATCH net-next v2 1/8] net: core: dev: Add extack argument to dev_open() Petr Machata
2018-12-06 17:05 ` [PATCH net-next v2 2/8] net: vrf: cycle_netdev(): Add an extack argument Petr Machata
2018-12-06 17:05 ` Petr Machata [this message]
2018-12-06 17:05 ` [PATCH net-next v2 4/8] net: core: dev: Add extack argument to dev_change_flags() Petr Machata
2018-12-06 17:05 ` [PATCH net-next v2 5/8] net: core: dev: Add extack argument to __dev_change_flags() Petr Machata
2018-12-06 17:05 ` [PATCH net-next v2 6/8] net: core: dev: Add call_netdevice_notifiers_extack() Petr Machata
2018-12-06 17:05 ` [PATCH net-next v2 7/8] net: core: dev: Attach extack to NETDEV_PRE_UP Petr Machata
2018-12-06 17:05 ` [PATCH net-next v2 8/8] selftests: mlxsw: Add a new test extack.sh Petr Machata
2018-12-06 21:31 ` [PATCH net-next v2 0/8] Pass extack to NETDEV_PRE_UP David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4df7c89337f60f47281f00ae0adb6e698d6786c5.1544115501.git.petrm@mellanox.com \
    --to=petrm@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=idosch@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.