From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Maxim Kochetkov <fido_max@inbox.ru>
Cc: vivien.didelot@gmail.com, olteanv@gmail.com, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] net: dsa: Fix type was not set for devlink port
Date: Mon, 29 Mar 2021 09:56:32 -0700 [thread overview]
Message-ID: <4e0053f3-39b6-b13b-1545-91beb5d1f49a@gmail.com> (raw)
In-Reply-To: <YGIFYiYSGAnrjOiD@lunn.ch>
On 3/29/21 9:50 AM, Andrew Lunn wrote:
> On Mon, Mar 29, 2021 at 06:30:16PM +0300, Maxim Kochetkov wrote:
>> If PHY is not available on DSA port (described at devicetree but absent or
>> failed to detect) then kernel prints warning after 3700 secs:
>>
>> [ 3707.948771] ------------[ cut here ]------------
>> [ 3707.948784] Type was not set for devlink port.
>> [ 3707.948894] WARNING: CPU: 1 PID: 17 at net/core/devlink.c:8097 0xc083f9d8
>>
>> We should unregister the devlink port as a user port and
>> re-register it as an unused port before executing "continue" in case of
>> dsa_port_setup error.
>>
>> Fixes: 86f8b1c01a0a ("net: dsa: Do not make user port errors fatal")
>
> This commit says:
>
> Prior to 1d27732f411d ("net: dsa: setup and teardown ports"), we would
> not treat failures to set-up an user port as fatal, but after this
> commit we would, which is a regression for some systems where interfaces
> may be declared in the Device Tree, but the underlying hardware may not
> be present (pluggable daughter cards for instance).
>
> Florian
>
> Are these daughter cards hot pluggable? So we expect them to appear
> and the port is then usable? Or is a reboot required?
The systems need to be powered off cards replaced and then powered back
on so no true hot-pluggable scheme but cold-pluggable definitively.
--
Florian
next prev parent reply other threads:[~2021-03-29 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 15:30 [PATCH 1/1] net: dsa: Fix type was not set for devlink port Maxim Kochetkov
2021-03-29 16:25 ` Vladimir Oltean
2021-03-29 16:50 ` Andrew Lunn
2021-03-29 16:56 ` Florian Fainelli [this message]
2021-03-29 21:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0053f3-39b6-b13b-1545-91beb5d1f49a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=fido_max@inbox.ru \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.