All of lore.kernel.org
 help / color / mirror / Atom feed
From: steve@lonetwin.net
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Junio C Hamano <jch2355@gmail.com>
Subject: Re: [PATCH] git-completion.bash: Add completion for stash list
Date: Wed, 10 Oct 2018 14:34:43 +0100	[thread overview]
Message-ID: <4e046cd43ff5bfb907a68c5504efd7b2@lonetwin.net> (raw)
In-Reply-To: <xmqq36tiva0i.fsf@gitster-ct.c.googlers.com>

On 2018-10-07 2:08 am, Junio C Hamano wrote:
> Steve <steve@lonetwin.net> writes:
> 
>> Since stash list accepts git-log options, add the following useful
>> options that make sense in the context of the `git stash list` 
>> command:
>> 
>>   --name-status --oneline --patch-with-stat
>> 
>> Signed-off-by: Steven Fernandez <steve@lonetwin.net>
>> ---
>> 
>> This is my first patch to the project so please be excuse any process
>> errors.
>> Although, I've tried my best to follow the guidelines in
>> Documentation/SubmittingPatches but I'm not sure if I missed anything.
> 
> Thanks.  Will queue with manual fix-ups, but since you asked, here
> are the things I'll be fixing up manually, which you may want to
> avoid next time.
> 

Thanks for accepting the patchset and the manual fixes. Thanks a lot 
also
for taking the time to explain the mistakes to avoid.

cheers,
Steve

  reply	other threads:[~2018-10-10 13:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27 19:59 [PATCH] git-completion.bash: Add completion for stash list Steve
2018-10-07  1:08 ` Junio C Hamano
2018-10-10 13:34   ` steve [this message]
2018-09-27 20:09 Steve

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e046cd43ff5bfb907a68c5504efd7b2@lonetwin.net \
    --to=steve@lonetwin.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jch2355@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.