From: Jens Axboe <axboe@kernel.dk>
To: Eric Sandeen <esandeen@redhat.com>, fio <fio@vger.kernel.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH] don't access dlclose'd dynamic ioengine object after close
Date: Sat, 8 May 2021 22:13:30 -0600 [thread overview]
Message-ID: <4e05c5f8-d057-e368-d490-f2bdf74ed65e@kernel.dk> (raw)
In-Reply-To: <14499187-1da8-ff0c-6b60-8fa6dd33d9fa@redhat.com>
On 5/7/21 3:13 PM, Eric Sandeen wrote:
> Alexey reported this bug when using dynamically loaded IO engines;
> a segfault on the line where we set the dlhandle to NULL after
> the dlclose.
>
> I think this is because ops points to the thing we obtained from dlsym:
>
> ops = dlsym(dlhandle, engine_lib);
>
> and after the final dlclose, the object no longer exists and efforts
> to set the handle within it will fail for obvious reasons.
> I'm not sure why I hadn't seen this before.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-05-09 4:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 21:13 [PATCH] don't access dlclose'd dynamic ioengine object after close Eric Sandeen
2021-05-08 16:18 ` Alexey Dobriyan
2021-05-09 4:13 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e05c5f8-d057-e368-d490-f2bdf74ed65e@kernel.dk \
--to=axboe@kernel.dk \
--cc=adobriyan@gmail.com \
--cc=esandeen@redhat.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.