From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 6/6] x86/xstate: Fix latent bugs in compress_xsave_states() Date: Mon, 12 Sep 2016 16:28:53 +0100 Message-ID: <4e2aff92-0f86-0bb6-0c0e-d388c6fbc4b3@citrix.com> References: <1473673900-8585-1-git-send-email-andrew.cooper3@citrix.com> <1473673900-8585-7-git-send-email-andrew.cooper3@citrix.com> <57D6BB49020000780010E05A@prv-mh.provo.novell.com> <6c83aa47-00ab-fbe9-54fd-30023581d95d@citrix.com> <57D6CE12020000780010E118@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <57D6CE12020000780010E118@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Xen-devel List-Id: xen-devel@lists.xenproject.org T24gMTIvMDkvMTYgMTQ6NDcsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDEyLjA5LjE2IGF0 IDE0OjU5LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+IE9uIDEyLzA5LzE2 IDEzOjI3LCBKYW4gQmV1bGljaCB3cm90ZToKPj4+Pj4+IE9uIDEyLjA5LjE2IGF0IDExOjUxLCA8 YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+Pj4gIHZvaWQgY29tcHJlc3NfeHNh dmVfc3RhdGVzKHN0cnVjdCB2Y3B1ICp2LCBjb25zdCB2b2lkICpzcmMsIHVuc2lnbmVkIGludCBz aXplKQo+Pj4+ICB7Cj4+Pj4gICAgICBzdHJ1Y3QgeHNhdmVfc3RydWN0ICp4c2F2ZSA9IHYtPmFy Y2gueHNhdmVfYXJlYTsKPj4+PiAgICAgIHVpbnQxNl90IGNvbXBfb2Zmc2V0c1tzaXplb2YoeGZl YXR1cmVfbWFzaykqOF07Cj4+Pj4gLSAgICB1NjQgeHN0YXRlX2J2ID0gKChjb25zdCBzdHJ1Y3Qg eHNhdmVfc3RydWN0ICopc3JjKS0+eHNhdmVfaGRyLnhzdGF0ZV9idjsKPj4+PiAtICAgIHU2NCB2 YWxpZDsKPj4+PiArICAgIHU2NCB4c3RhdGVfYnYsIHZhbGlkOwo+Pj4+ICsKPj4+PiArICAgIEJV R19PTighdi0+YXJjaC54Y3IwX2FjY3VtKTsKPj4+PiArICAgIEJVR19PTihzaXplICE9IHhzdGF0 ZV9jdHh0X3NpemUodi0+YXJjaC54Y3IwX2FjY3VtKSk7Cj4+Pj4gKyAgICBCVUdfT04oeHNhdmVf YXJlYV9jb21wcmVzc2VkKHNyYykpOwo+Pj4+ICAKPj4+PiAtICAgIEFTU0VSVCgheHNhdmVfYXJl YV9jb21wcmVzc2VkKHNyYykpOwo+Pj4gU2FtZSByZW1hcmsgaGVyZSBhcyBvbiB0aGUgZWFybGll ciBwYXRjaCB3cnQgQlVHX09OKCkgdnMgQVNTRVJUKCkuCj4+IFNhbWUgYW5zd2VyLgo+IFdlbGws IGl0J3MgY2VydGFpbmx5IGEgbWF0dGVyIG9mIHRhc3RlIGhvdyBtdWNoIG9mIHRoZSBhYm92ZSB0 byBjb25zaWRlcgo+IGJvdW5kcyBjaGVja2luZy4gSSBmb3Igb25lIHdvdWxkIHRha2Ugb25seSB0 aGUgbWlkZGxlIG9uZSBhcyBzdWNoLgoKVGhlIGZpcnN0IGlzIG5lY2Vzc2FyeSBpZiB5b3Ugd2Fu dCB0aGUgc2Vjb25kLCBhbmQgaW1wb3J0YW50IGFzIHRoZQpjYWxsaW5nIGNvbnZlbnRpb24gaW52 b2x2ZXMgdGhlIGNhbGxlciBtb2RpZnlpbmcgeGNyMCogdG8gbWF0Y2ggdGhlCmluY29taW5nIHN0 YXRlLgoKVGhlIGNvbXByZXNzZWQgY2hlY2sgaXMgYWRtaXR0ZWRseSBkaWZmZXJlbnQsIGJ1dCBp dCBpcyBjdXJyZW50bHkgYW4gQUJJCnJlcXVpcmVtZW50IHRoYXQgdGhlIGRhdGEgaXMgdW5jb21w cmVzc2VkLiAgVGhpcyBjb3VsZCBiZSBsaWZ0ZWQgaWYgd2UKYWx0ZXIgdGhlIEFCSS4KCj4KPj4+ PiArICAgIHhzdGF0ZV9idiA9ICgoY29uc3Qgc3RydWN0IHhzYXZlX3N0cnVjdCAqKXNyYyktPnhz YXZlX2hkci54c3RhdGVfYnY7Cj4+Pj4gIAo+Pj4+ICAgICAgaWYgKCAhKHYtPmFyY2gueGNyMF9h Y2N1bSAmIFhTVEFURV9YU0FWRVNfT05MWSkgKQo+Pj4+ICAgICAgewo+Pj4+ICsgICAgICAgIC8q Cj4+Pj4gKyAgICAgICAgICogVE9ETzogVGhpcyBsb2dpYyBkb2Vzbid0IGN1cnJlbnRseSBoYW5k bGUgcmVzdG9yYXRpb24gb2YgeHNhdmUKPj4+PiArICAgICAgICAgKiBzdGF0ZSB3aGljaCB3b3Vs ZCBmb3JjZSB0aGUgdmNwdSBmcm9tIHVuY29tcHJlc3NlZCB0byBjb21wcmVzc2VkLgo+Pj4+ICsg ICAgICAgICAqLwo+Pj4+ICsgICAgICAgIEJVR19PTih4c3RhdGVfYnYgJiBYU1RBVEVfWFNBVkVT X09OTFkpOwo+Pj4gSSBkb24ndCB0aGluayB0aGlzIGlzIGEgdmFsaWQgY29uY2VybiBvZiB5b3Vy czogVGhlIGZ1bmN0aW9uIGNhbid0IGJlCj4+PiB1c2VkIHRvIHJlc3RvcmUgZmVhdHVyZXMgbm90 IHhjcjBfYWNjdW0gYW55d2F5IChvciBlbHNlIHRoYXQKPj4+IGZpZWxkIHdvdWxkIG5lZWQgdXBk YXRpbmcpLiBBZmFpY3QgdmFsaWRhdGVfeHN0YXRlKCkgYWxyZWFkeSBwcmV2ZW50cwo+Pj4gdGhp cyBhcyBpbnRlbmRlZC4KPj4gVGhpcyBpcyBhbGwgY3VycmVudGx5IGRlYWQgY29kZS4gIEkgZ3Vl c3MgdGhlIHF1ZXN0aW9uIHJlYWxseSBkZXBlbmRzIG9uCj4+IHdoYXQgd2UgcGxhbiB0byBkbyB3 aXRoIGNvbXByZXNzZWQgc3RhdGVzLgo+Pgo+PiBTdHJpY3RseSBzcGVha2luZywgbm8gWFNBVkVT IHN0YXRlIGNhbiBldmVyeSBiZSBwcmVzZW50IGluIHhjcjAsIGJ5Cj4+IGRlc2lnbi4gIElmIHdl IHJldHJvYWN0aXZlbHkgY29uc2lkZXIgeGNyMF9hY2N1bSB0byBiZSAiYWxsIHN0YXRlcyBpbgo+ PiB1c2UiLAo+IEkgdGhpbmsgdGhhdCdzIHRoZSBvbmx5IHZpYWJsZSBtb2RlbCwgY29uc2lkZXJp bmcgaG93IHRoZSBkb21jdGwgd29ya3M6Cj4geGNyMF9hY2N1bSBuZWVkcyB0byByZXByZXNlbnQg dGhlIGNvbWJpbmF0aW9uIG9mIGZlYXR1cmVzIGV2ZXIKPiBlbmFibGVkIGluIFhDUjAgYW5kIFhT Uy4KCkluIHdoaWNoIGNhc2Ugd2Ugc2hvdWxkIHJlYWxseSByZW5hbWUgaXQgdG8geHN0YXRlX2Fj Y3VtIHRoZW4uCgo+Cj4+IHRoZW4gdGhlIGlmIGNvbmRpdGlvbiBpbiBjb250ZXh0IGRvZXMgYmVj b21lIHJlbGV2YW50IHdoZW4gWGVuCj4+IHN0YXJ0cyBzdXBwb3J0aW5nIFhTQVZFUy1vbmx5IGNv bXBvbmVudHMuCj4+Cj4+IEluIHN1Y2ggYSBjYXNlLCBpdCBpcyBkZWZpbml0ZWx5IHdyb25nIHRv IG1lbWNweSgpIHRoZSB1bmNvbXByZXNzZWQKPj4gYnVmZmVyLCBhcyBYZW4gd2lsbCB0cnkgYW5k IHVzZSB4cnN0b3JzIGFuZCBjb3JydXB0IGFsbCBndWVzdCBzdGF0ZS4KPiBIb3c/IElmIHRoZSBn dWVzdCBuZXZlciBlbmFibGVkIGFueSBiaXQgaW4gWFNTLCBob3cgY2FuIGFueSBzdWNoCj4gYml0 IGJlIHNldCBpbiB4c3RhdGVfYnYgKHdoaWNoIGlzIGFsd2F5cyBhIHN1YnNldCBvZiBYQ1IwfFhT UykuCgpDdXJyZW50bHkgaXQgY2FudC4gIFRoaXMgaXMgYSBwcmVlbXB0aXZlIGNhdGNoIGZvciB3 aG9tZXZlciB0cmllcwppbXBsZW1lbnRpbmcgdGhlIGZpcnN0IFhTUyBzdGF0ZSwgYW5kIGRvZXNu J3QgdGVzdCBtaWdyYXRpb24gYmV0d2VlbgpvbGRlciBhbmQgbmV3ZXIgWGVuLgoKfkFuZHJldwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg==