From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F02DC433EF for ; Wed, 20 Apr 2022 13:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378545AbiDTNiy (ORCPT ); Wed, 20 Apr 2022 09:38:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239748AbiDTNiw (ORCPT ); Wed, 20 Apr 2022 09:38:52 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12FF1AE48 for ; Wed, 20 Apr 2022 06:36:07 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id bg24so1963910pjb.1 for ; Wed, 20 Apr 2022 06:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=lXdyjsZwzid6gzFZsYx+3FvAzRzuWVqc4HAM59uiv4I=; b=TrZDrs3kSql9sib4o8UH2aejnB9lVPUBoAig3WO81PdWJ8jQpG2MxBkFcDMf8NBWou /FVnq8rG4GwfPxJSFY8qmtnxlBvSPNaxIQ47Z0BjaV3alza9bo2WSBMOLtDknFzUpYwH J7MIq8ULFWzX4lVq/3p62Vrqu3mZK9H4Mvsl9jA/DNBp8NaYXXQxol/qLJhIu3CzGIvL MzK/u0YsEw3JXizDM3rHwfPp/35uCo+BpDRmPsVRPQ62kmC9RR4mKLX1zmx8QvGzBReX znz0RqTRuVVrF19Hg9nEY8q/N1Ubm6cUnFI+NnsyAbIxpa0z6m9DPhbarakYNydJR1/K ffQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=lXdyjsZwzid6gzFZsYx+3FvAzRzuWVqc4HAM59uiv4I=; b=U9Ouyl+Aeccqkufb+uvvhk/FjhoQ9btEkEwbH0E0yFVgbZ/Rqonq+ZvxgS71/WZsjr +dcplMsA2gPpUSp5us9Vo74otmjvojvK970dpYKnDx3f8yQEYx+jVhsxQwZiFDdtPmP4 yAwtXl119rYLPLs2ieBvfV/OK78BIklY49flUMJbvj9WE+e0sD9SGkeH98RGfY40pQhY 3E5+DNWTiPJ5N0Arka9qhbjZEMMyU93xIZ4gPuP9V6ADKbOaeTOYpmkxQ2wPnOXZSLFQ RacG55g3f5ULd4zfHkKH/V1HyxWMePYUC4E9K2LwjQxsUbt1beKwGId8oalCLu8WJfBW hVjw== X-Gm-Message-State: AOAM530ab/cyrUXcCcdt3uAGBLl8lJD4jdfSHWiuCE0u3j1zJKce1Hxp UdUi2ZrQ7aB6aKxkV8rraD4= X-Google-Smtp-Source: ABdhPJxtsG9w1ifLwHhGzp8j2IssoTIdZkBYyWeL5HF0RqiBvpRYeBJtoZ/6uVakf9ISJs8wuN4Uxw== X-Received: by 2002:a17:90a:7f94:b0:1cb:1853:da1b with SMTP id m20-20020a17090a7f9400b001cb1853da1bmr4470119pjl.14.1650461766581; Wed, 20 Apr 2022 06:36:06 -0700 (PDT) Received: from [172.16.10.243] ([106.39.150.10]) by smtp.gmail.com with ESMTPSA id j19-20020a056a00235300b0050a858af58fsm10143884pfj.145.2022.04.20.06.36.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Apr 2022 06:36:06 -0700 (PDT) Message-ID: <4e3309d9-879f-3385-3e8e-0fa1a31ddd9a@gmail.com> Date: Wed, 20 Apr 2022 21:35:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] ASoC: fsl: Fix error handling in pcm030_fabric_probe Content-Language: en-US To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20220420021855.8224-1-linmq006@gmail.com> From: Miaoqian Lin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/4/20 21:00, Mark Brown wrote: > On Wed, Apr 20, 2022 at 02:18:52AM +0000, Miaoqian Lin wrote: >> This will call twice platform_device_put() >> if both platform_device_add() and snd_soc_register_card() fails. >> return early on error to avoid duplicating the error code logic. >> >> Signed-off-by: Miaoqian Lin >> --- >> changes in v2: >> - use return statement to return early when fails >> - rebase on top of commit 559089e0a93d ("vmalloc: replace VM_NO_HUGE_VMAP with VM_ALLOW_HUGE_VMAP") > Why rebase on top of that seemingly random commit? Is there some sort > of dependency here? Hi, it the head of master in when I made this patch. It's because you pointed out that patch v1 doesn't apply against current code. But I am not sure what's the problem. So I ensure the codebase is up-to-date. If this patch have no conflict, you can ignore it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FC8DC433F5 for ; Wed, 20 Apr 2022 13:37:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A6DE01AB2; Wed, 20 Apr 2022 15:36:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A6DE01AB2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650461822; bh=ttybcvAcuOW4Q8OVInp+wmQI38Nrf5uDsT8oiy9sda0=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=G3vVRXMjJe0j+v7M9Bau1pdWPGUSZjjRF19Y6nQx/zQRrISvSk7q/WH1GEHkuYWvW PK9jtU4AWkVq8MXDhC6wVxEeEnV77Gv35llLmzxkd+Xz7frpTtqHzE6CCCnG4AiPwX VsOgGWIRUu6HSncy2f5ROy+EBxK8c3oZ6FGYUY9M= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4D4AEF80116; Wed, 20 Apr 2022 15:36:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7EA7EF80125; Wed, 20 Apr 2022 15:36:11 +0200 (CEST) Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DC080F800F8 for ; Wed, 20 Apr 2022 15:36:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DC080F800F8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TrZDrs3k" Received: by mail-pj1-x1036.google.com with SMTP id ll10so1936787pjb.5 for ; Wed, 20 Apr 2022 06:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=lXdyjsZwzid6gzFZsYx+3FvAzRzuWVqc4HAM59uiv4I=; b=TrZDrs3kSql9sib4o8UH2aejnB9lVPUBoAig3WO81PdWJ8jQpG2MxBkFcDMf8NBWou /FVnq8rG4GwfPxJSFY8qmtnxlBvSPNaxIQ47Z0BjaV3alza9bo2WSBMOLtDknFzUpYwH J7MIq8ULFWzX4lVq/3p62Vrqu3mZK9H4Mvsl9jA/DNBp8NaYXXQxol/qLJhIu3CzGIvL MzK/u0YsEw3JXizDM3rHwfPp/35uCo+BpDRmPsVRPQ62kmC9RR4mKLX1zmx8QvGzBReX znz0RqTRuVVrF19Hg9nEY8q/N1Ubm6cUnFI+NnsyAbIxpa0z6m9DPhbarakYNydJR1/K ffQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=lXdyjsZwzid6gzFZsYx+3FvAzRzuWVqc4HAM59uiv4I=; b=U0+ahAeGK0ZnOWi4OVWN54UPKdf1jLOjILP2HTvSQ4V+Gh2kWpCA8CrR1m7ApTEcGe HwYdRxLt2fv5F+Ec1WIK9ntp/z/Iao60+h/mW9SOFeuoR/7fkvfwjDds5KkTxqemxrb7 4IvFkultY7Xh3Xhv4zykUp/LHAnUJDupewmFIRdG/nQ3uIrao1kOkWHk7E9XhEPcJDV/ s2gmZ2ByMJ9u3/wVFH/ohIgFCU5kDm2LauJH6hRuHE0ocZmLI2y/gisNxfmFozt9CnNP YAVt+6tILaRgqKQf7f6+w4bHp0hKDVYzzOvJux06POi1NjRZg5Eq3cAbyNvZ6ga2hKOT CPmg== X-Gm-Message-State: AOAM530qIHcXH1uLiTPOSYkjD7fNRpul5Hnw1Rq83qUrcNoF+YG49t6O UWrRyx2MITLKi46tEPXy3QxMUDNwjDcMDDi9UvM= X-Google-Smtp-Source: ABdhPJxtsG9w1ifLwHhGzp8j2IssoTIdZkBYyWeL5HF0RqiBvpRYeBJtoZ/6uVakf9ISJs8wuN4Uxw== X-Received: by 2002:a17:90a:7f94:b0:1cb:1853:da1b with SMTP id m20-20020a17090a7f9400b001cb1853da1bmr4470119pjl.14.1650461766581; Wed, 20 Apr 2022 06:36:06 -0700 (PDT) Received: from [172.16.10.243] ([106.39.150.10]) by smtp.gmail.com with ESMTPSA id j19-20020a056a00235300b0050a858af58fsm10143884pfj.145.2022.04.20.06.36.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Apr 2022 06:36:06 -0700 (PDT) Message-ID: <4e3309d9-879f-3385-3e8e-0fa1a31ddd9a@gmail.com> Date: Wed, 20 Apr 2022 21:35:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] ASoC: fsl: Fix error handling in pcm030_fabric_probe Content-Language: en-US To: Mark Brown References: <20220420021855.8224-1-linmq006@gmail.com> From: Miaoqian Lin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2022/4/20 21:00, Mark Brown wrote: > On Wed, Apr 20, 2022 at 02:18:52AM +0000, Miaoqian Lin wrote: >> This will call twice platform_device_put() >> if both platform_device_add() and snd_soc_register_card() fails. >> return early on error to avoid duplicating the error code logic. >> >> Signed-off-by: Miaoqian Lin >> --- >> changes in v2: >> - use return statement to return early when fails >> - rebase on top of commit 559089e0a93d ("vmalloc: replace VM_NO_HUGE_VMAP with VM_ALLOW_HUGE_VMAP") > Why rebase on top of that seemingly random commit? Is there some sort > of dependency here? Hi, it the head of master in when I made this patch. It's because you pointed out that patch v1 doesn't apply against current code. But I am not sure what's the problem. So I ensure the codebase is up-to-date. If this patch have no conflict, you can ignore it.