From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: git@vger.kernel.org
Cc: Shourya Shukla <shouryashukla.oo@gmail.com>,
christian.couder@gmail.com, gitster@pobox.com,
liu.denton@gmail.com
Subject: Re: [PATCH 1/2] submodule: port subcommand 'set-branch' from shell to C
Date: Thu, 14 May 2020 14:37:37 +0530 [thread overview]
Message-ID: <4e36c8a0-4f43-79f8-137f-5fd080066af6@gmail.com> (raw)
In-Reply-To: <20200513201737.55778-1-shouryashukla.oo@gmail.com>
-Cc: chriscool@tuxfamily.org (seems redundant; Also, .mailmap confirms
that christian.couder@gmail.com is Christian's preference)
On 14-05-2020 01:47, Shourya Shukla wrote:
>
> The extra '$branch' on line 752 was because of Christian's help after
> reference from TLDP's Parameter Subsitution documentation:
> https://www.tldp.org/LDP/abs/html/parameter-substitution.html
>
For those who lack the context, during the conversion of the script
Shourya faced an issue where the '--branch' argument did not work as
expected. He described the issue in a private e-mail where Christian
pointed out the following (quoting his reply hoping he doesn't mind):
> On Tue, May 12, 2020 at 5:55 PM Christian Couder
<christian.couder@gmail.com> wrote:
>>
>> In your commit (in submodule.sh line 781) there is:
>>
>> `git ${wt_prefix:+-C "$wt_prefix"} ${prefix:+--super-prefix
>> "$prefix"} submodule--helper set-branch ${GIT_QUIET:+--quiet}
>> ${branch:+--branch} ${default:+--default} -- "$@"`
>
> Actually the issue might come from the above. I think it should use
${branch:+--branch $branch} instead of ${branch:+--branch}.
>
> See: https://www.tldp.org/LDP/abs/html/parameter-substitution.html
That's why Shourya mentions the '$branch' as extra. Of course, that's
how it is supposed to be in the first place :)
--
Sivaraam
next prev parent reply other threads:[~2020-05-14 9:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 20:17 [PATCH 1/2] submodule: port subcommand 'set-branch' from shell to C Shourya Shukla
2020-05-13 20:17 ` [PATCH 2/2] submodule: Add 'quiet' option in subcommand 'set-branch' Shourya Shukla
2020-05-14 10:15 ` Denton Liu
2020-05-16 5:50 ` Shourya Shukla
2020-05-16 8:56 ` Denton Liu
2020-05-16 10:40 ` Shourya Shukla
2020-05-16 11:06 ` Denton Liu
2020-05-14 9:07 ` Kaartic Sivaraam [this message]
2020-05-17 15:06 ` [PATCH 1/2] submodule: port subcommand 'set-branch' from shell to C Junio C Hamano
2020-05-17 15:21 ` Kaartic Sivaraam
2020-05-14 10:10 ` Denton Liu
2020-05-16 10:37 ` Shourya Shukla
2020-05-16 10:55 ` Denton Liu
2020-05-17 16:11 ` Đoàn Trần Công Danh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e36c8a0-4f43-79f8-137f-5fd080066af6@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=shouryashukla.oo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.