From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: ymankad@redhat.com, "Daniel P. Berrangé" <berrange@redhat.com>,
"Fam Zheng" <fam@euphon.net>
Subject: Re: [Qemu-devel] [PATCH v1 05/19] tests: update Fedora i386 cross image to Fedora 29
Date: Thu, 10 Jan 2019 18:54:24 +0100 [thread overview]
Message-ID: <4e3923c6-ab62-3e78-eb96-5e68544fa7ca@redhat.com> (raw)
In-Reply-To: <20190110174516.21586-6-alex.bennee@linaro.org>
On 1/10/19 6:45 PM, Alex Bennée wrote:
> From: Daniel P. Berrangé <berrange@redhat.com>
>
> Using the "latest" tag is not a good idea because this changes what
> release it points to every 6 months. Together with caching of docker
> builds this can cause confusion where CI has cached & built with Fedora
> N, while a developer tries to reproduce a CI problem with Fedora N + 1,
> or vica-verca.
So we now learned the hard way commiting "FROM x:latest" to a repository
is a bad practice.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/docker/dockerfiles/fedora-i386-cross.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/fedora-i386-cross.docker b/tests/docker/dockerfiles/fedora-i386-cross.docker
> index a4fd895b07..eb8108d118 100644
> --- a/tests/docker/dockerfiles/fedora-i386-cross.docker
> +++ b/tests/docker/dockerfiles/fedora-i386-cross.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:latest
If checkpatch wasn't in Perl I'd have added a check to ban :latest.
> +FROM fedora:29
> ENV PACKAGES \
> gcc \
> glib2-devel.i686 \
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-01-10 17:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 17:44 [Qemu-devel] [PATCH v1 00/19] testing/next queue for travis and docker Alex Bennée
2019-01-10 17:44 ` [Qemu-devel] [PATCH v1 01/19] docker: Use stable git tag for virglrenderer Alex Bennée
2019-01-10 18:01 ` Philippe Mathieu-Daudé
2019-01-10 17:44 ` [Qemu-devel] [PATCH v1 02/19] tests: run ldconfig after installing extra software Alex Bennée
2019-01-10 18:12 ` Philippe Mathieu-Daudé
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 03/19] tests: remove obsolete 'debian' dockerfile Alex Bennée
2019-01-10 18:04 ` Philippe Mathieu-Daudé
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 04/19] tests: update Fedora dockerfile to use Fedora 29 Alex Bennée
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 05/19] tests: update Fedora i386 cross image to " Alex Bennée
2019-01-10 17:54 ` Philippe Mathieu-Daudé [this message]
2019-01-10 17:56 ` Daniel P. Berrangé
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 06/19] tests: use in-place sed magic for enabling deb-src in travis image Alex Bennée
2019-01-10 17:58 ` Philippe Mathieu-Daudé
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 07/19] travis: add whitespace between each major section & matrix entry Alex Bennée
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 08/19] travis: define all the build matrix entries in one place Alex Bennée
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 09/19] travis: standardize the syntax used for env variables Alex Bennée
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 10/19] travis: don't clone git submodules upfront Alex Bennée
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 11/19] travis: use homebrew addon for MacOSX Alex Bennée
2019-01-10 18:23 ` Daniel P. Berrangé
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 12/19] travis: stop redefining the script commands Alex Bennée
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 13/19] travis: stop using container based envs Alex Bennée
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 14/19] travis: run tests in verbose mode Alex Bennée
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 15/19] travis: remove matrix settings that duplicate global settings Alex Bennée
2019-01-10 18:06 ` Philippe Mathieu-Daudé
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 16/19] docker: Use a stable snapshot for Debian Sid Alex Bennée
2019-01-11 13:13 ` Philippe Mathieu-Daudé
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 17/19] travis: bump to Xenial baseline Alex Bennée
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 18/19] tests/docker: update our Travis image Alex Bennée
2019-01-10 17:45 ` [Qemu-devel] [PATCH v1 19/19] tests/docker: remove SID_AGE test hack Alex Bennée
2019-01-13 15:20 ` [Qemu-devel] [PATCH v1 00/19] testing/next queue for travis and docker no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e3923c6-ab62-3e78-eb96-5e68544fa7ca@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=fam@euphon.net \
--cc=qemu-devel@nongnu.org \
--cc=ymankad@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.