From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v3 3/3] vfio: use the generic multi-process channel Date: Thu, 25 Jan 2018 12:15:35 +0000 Message-ID: <4e40d407-5457-91bd-4f79-00e4e8db9da2@intel.com> References: <1512067450-59203-1-git-send-email-jianfeng.tan@intel.com> <2010166.0Q39LqRaO8@xps> <3fe4f70a-eeb6-e061-5d2e-8b62578ced47@intel.com> <2069506.YIxbetVmv7@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Jianfeng Tan , dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com To: Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6AC332BE5 for ; Thu, 25 Jan 2018 13:15:38 +0100 (CET) In-Reply-To: <2069506.YIxbetVmv7@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 25-Jan-18 10:57 AM, Thomas Monjalon wrote: > 25/01/2018 11:52, Burakov, Anatoly: >> On 25-Jan-18 10:47 AM, Thomas Monjalon wrote: >>> 25/01/2018 05:16, Jianfeng Tan: >>>> Previously, vfio uses its own private channel for the secondary >>>> process to get container fd and group fd from the primary process. >>>> >>>> This patch changes to use the generic mp channel. >>> >>> There was a private request to get it in 18.02-rc2. >>> >>> I have 3 concerns: >>> 1/ It is late >>> 2/ It is not yet reviewed by Anatoly and Konstantin >>> 3/ We try to not rework the existing code in RC2, >>> because it would totally invalidate the validation work >>> done for RC1. >>> >>> >> >> Hi Thomas, >> >> We can postpone the VFIO patch until 18.05, and integrate only the first >> two patches. First two patches do not change anything in DPDK, so >> validation impact should be non-existent. > > Yes, possible if it is well reviewed and all comments addressed. > OK then. Jianfeng, let's drop the VFIO patch for now, and postpone it for 18.05? -- Thanks, Anatoly