From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud7.xs4all.net ([194.109.24.24]:53677 "EHLO lb1-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727526AbeJEC3C (ORCPT ); Thu, 4 Oct 2018 22:29:02 -0400 Subject: Re: [PATCH v4 00/11] imx-media: Fixes for interlaced capture To: Steve Longerbeam , linux-media@vger.kernel.org References: <20181004185401.15751-1-slongerbeam@gmail.com> From: Hans Verkuil Message-ID: <4e521c80-7041-e5d8-cfa6-c05af07d5cf1@xs4all.nl> Date: Thu, 4 Oct 2018 21:34:15 +0200 MIME-Version: 1.0 In-Reply-To: <20181004185401.15751-1-slongerbeam@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 10/04/2018 08:53 PM, Steve Longerbeam wrote: > A set of patches that fixes some bugs with capturing from an > interlaced source, and incompatibilites between IDMAC interlace > interweaving and 4:2:0 data write reduction. > > History: > v4: > - rebased to latest media-tree master branch. > - Make patch author and SoB email addresses the same. > > v3: > - add support for/fix interweaved scan with YUV planar output. > - fix bug in 4:2:0 U/V offset macros. > - add patch that generalizes behavior of field swap in > ipu_csi_init_interface(). > - add support for interweaved scan with field order swap. > Suggested by Philipp Zabel. > - in v2, inteweave scan was determined using field types of > CSI (and PRPENCVF) at the sink and source pads. In v3, this > has been moved one hop downstream: interweave is now determined > using field type at source pad, and field type selected at > capture interface. Suggested by Philipp. > - make sure to double CSI crop target height when input field > type in alternate. > - more updates to media driver doc to reflect above. > > v2: > - update media driver doc. > - enable idmac interweave only if input field is sequential/alternate, > and output field is 'interlaced*'. > - move field try logic out of *try_fmt and into separate function. > - fix bug with resetting crop/compose rectangles. > - add a patch that fixes a field order bug in VDIC indirect mode. > - remove alternate field type from V4L2_FIELD_IS_SEQUENTIAL() macro > Suggested-by: Nicolas Dufresne . > - add macro V4L2_FIELD_IS_INTERLACED(). > > > Steve Longerbeam (11): > media: videodev2.h: Add more field helper macros > gpu: ipu-csi: Swap fields according to input/output field types > gpu: ipu-v3: Add planar support to interlaced scan What should I do with these patches? Do they go through us? Or the drm subsystem (or whoever handles this)? If it goes through another subsystem, then I can Ack them. Regards, Hans > media: imx: Fix field negotiation > media: imx-csi: Double crop height for alternate fields at sink > media: imx: interweave and odd-chroma-row skip are incompatible > media: imx-csi: Allow skipping odd chroma rows for YVU420 > media: imx: vdic: rely on VDIC for correct field order > media: imx-csi: Move crop/compose reset after filling default mbus > fields > media: imx: Allow interweave with top/bottom lines swapped > media: imx.rst: Update doc to reflect fixes to interlaced capture > > Documentation/media/v4l-drivers/imx.rst | 93 ++++++---- > drivers/gpu/ipu-v3/ipu-cpmem.c | 26 ++- > drivers/gpu/ipu-v3/ipu-csi.c | 132 ++++++++++---- > drivers/staging/media/imx/imx-ic-prpencvf.c | 48 +++-- > drivers/staging/media/imx/imx-media-capture.c | 14 ++ > drivers/staging/media/imx/imx-media-csi.c | 166 ++++++++++++------ > drivers/staging/media/imx/imx-media-vdic.c | 12 +- > include/uapi/linux/videodev2.h | 7 + > include/video/imx-ipu-v3.h | 6 +- > 9 files changed, 359 insertions(+), 145 deletions(-) >