From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 873A5C4338F for ; Fri, 13 Aug 2021 16:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70D2260E52 for ; Fri, 13 Aug 2021 16:46:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235739AbhHMQqi (ORCPT ); Fri, 13 Aug 2021 12:46:38 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3650 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbhHMQqg (ORCPT ); Fri, 13 Aug 2021 12:46:36 -0400 Received: from fraeml714-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GmTv86sfxz6FBPV; Sat, 14 Aug 2021 00:45:24 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml714-chm.china.huawei.com (10.206.15.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Fri, 13 Aug 2021 18:46:08 +0200 Received: from [10.47.94.64] (10.47.94.64) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 13 Aug 2021 17:46:07 +0100 Subject: Re: [PATCH 1/4] iommu/arm-smmu-v3: Use command queue batching helpers to improve performance To: Robin Murphy , Zhen Lei , Will Deacon , Joerg Roedel , linux-arm-kernel , iommu , References: <20210811114852.2429-1-thunder.leizhen@huawei.com> <20210811114852.2429-2-thunder.leizhen@huawei.com> <81258eb7-eb73-8a32-0983-3487daba1167@arm.com> From: John Garry Message-ID: <4e741216-d6e7-c40c-f257-242cd2fea302@huawei.com> Date: Fri, 13 Aug 2021 17:45:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <81258eb7-eb73-8a32-0983-3487daba1167@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.47.94.64] X-ClientProxiedBy: lhreml730-chm.china.huawei.com (10.201.108.81) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/08/2021 17:01, Robin Murphy wrote: >> >> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c >> b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c >> index 235f9bdaeaf223b..c81cd929047f573 100644 >> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c >> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c >> @@ -1747,15 +1747,16 @@ static int arm_smmu_atc_inv_master(struct >> arm_smmu_master *master) >>   { >>       int i; >>       struct arm_smmu_cmdq_ent cmd; >> +    struct arm_smmu_cmdq_batch cmds = {}; > > BTW, it looks like this has crossed over with John's patch removing these. It is only called from arm_smmu_disable_ats(), so not hot-path by the look for it. Or who even has ats HW ...? But it should be at least cleaned-up for consistency. Leizhen? Thanks, John From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 422F5C4338F for ; Fri, 13 Aug 2021 16:46:19 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2842610A4 for ; Fri, 13 Aug 2021 16:46:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D2842610A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9F46F80F04; Fri, 13 Aug 2021 16:46:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UZnOzAy7r0mh; Fri, 13 Aug 2021 16:46:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 5971B80E7F; Fri, 13 Aug 2021 16:46:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 27D58C001A; Fri, 13 Aug 2021 16:46:14 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id A00B1C000E for ; Fri, 13 Aug 2021 16:46:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 89FE480E91 for ; Fri, 13 Aug 2021 16:46:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Euqhq2BBKao for ; Fri, 13 Aug 2021 16:46:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4805B80E7F for ; Fri, 13 Aug 2021 16:46:11 +0000 (UTC) Received: from fraeml714-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GmTv86sfxz6FBPV; Sat, 14 Aug 2021 00:45:24 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml714-chm.china.huawei.com (10.206.15.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Fri, 13 Aug 2021 18:46:08 +0200 Received: from [10.47.94.64] (10.47.94.64) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 13 Aug 2021 17:46:07 +0100 Subject: Re: [PATCH 1/4] iommu/arm-smmu-v3: Use command queue batching helpers to improve performance To: Robin Murphy , Zhen Lei , Will Deacon , Joerg Roedel , linux-arm-kernel , iommu , References: <20210811114852.2429-1-thunder.leizhen@huawei.com> <20210811114852.2429-2-thunder.leizhen@huawei.com> <81258eb7-eb73-8a32-0983-3487daba1167@arm.com> From: John Garry Message-ID: <4e741216-d6e7-c40c-f257-242cd2fea302@huawei.com> Date: Fri, 13 Aug 2021 17:45:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <81258eb7-eb73-8a32-0983-3487daba1167@arm.com> Content-Language: en-US X-Originating-IP: [10.47.94.64] X-ClientProxiedBy: lhreml730-chm.china.huawei.com (10.201.108.81) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gMTMvMDgvMjAyMSAxNzowMSwgUm9iaW4gTXVycGh5IHdyb3RlOgo+Pgo+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMuYyAKPj4gYi9kcml2 ZXJzL2lvbW11L2FybS9hcm0tc21tdS12My9hcm0tc21tdS12My5jCj4+IGluZGV4IDIzNWY5YmRh ZWFmMjIzYi4uYzgxY2Q5MjkwNDdmNTczIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2lvbW11L2Fy bS9hcm0tc21tdS12My9hcm0tc21tdS12My5jCj4+ICsrKyBiL2RyaXZlcnMvaW9tbXUvYXJtL2Fy bS1zbW11LXYzL2FybS1zbW11LXYzLmMKPj4gQEAgLTE3NDcsMTUgKzE3NDcsMTYgQEAgc3RhdGlj IGludCBhcm1fc21tdV9hdGNfaW52X21hc3RlcihzdHJ1Y3QgCj4+IGFybV9zbW11X21hc3RlciAq bWFzdGVyKQo+PiDCoCB7Cj4+IMKgwqDCoMKgwqAgaW50IGk7Cj4+IMKgwqDCoMKgwqAgc3RydWN0 IGFybV9zbW11X2NtZHFfZW50IGNtZDsKPj4gK8KgwqDCoCBzdHJ1Y3QgYXJtX3NtbXVfY21kcV9i YXRjaCBjbWRzID0ge307Cj4gCj4gQlRXLCBpdCBsb29rcyBsaWtlIHRoaXMgaGFzIGNyb3NzZWQg b3ZlciB3aXRoIEpvaG4ncyBwYXRjaCByZW1vdmluZyB0aGVzZS4KCkl0IGlzIG9ubHkgY2FsbGVk IGZyb20gYXJtX3NtbXVfZGlzYWJsZV9hdHMoKSwgc28gbm90IGhvdC1wYXRoIGJ5IHRoZSAKbG9v ayBmb3IgaXQuIE9yIHdobyBldmVuIGhhcyBhdHMgSFcgLi4uPwoKQnV0IGl0IHNob3VsZCBiZSBh dCBsZWFzdCBjbGVhbmVkLXVwIGZvciBjb25zaXN0ZW5jeS4gTGVpemhlbj8KClRoYW5rcywKSm9o bgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBt YWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0 cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 090A2C4338F for ; Fri, 13 Aug 2021 16:47:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFB5360E52 for ; Fri, 13 Aug 2021 16:47:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CFB5360E52 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vHwNvZtcEEz3P+ts73u5ytweZOS7OFgdmVRgQtuz7DQ=; b=ImrIR+9R2eF+sNgqRLdMGFIG69 /fFeCHqsZ5yBbWd6v5wvbG8VggtIOWWaNeh5tMM7jOng0rRRsFzQeffxOG6kev0rm/BNyb4jtBtec 5BAB4YnFCxXrWsGAYcRLQ7cgRdGeZyqkwT/rbe1P12GFJ2dNnct9g4uYkOxFDCoAE3yYquf7QcJSd tcw77gCDVg02o+S6wigNT/p5X7YpPDqQRa72k8OwilaGONjdaH2Hk3FQydxU7LPk2KmspKUaW1trz TfsrvVqzA/8MKo1pEU0ZfAp9JZZNVrQc9cZRLDzkciYRdZPoOAnXptQYr4mdSvA6L1IU62Nuuci7M KJxvGDgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEaKB-00D9IF-5M; Fri, 13 Aug 2021 16:46:27 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEaK7-00D9Fi-P8 for linux-arm-kernel@lists.infradead.org; Fri, 13 Aug 2021 16:46:25 +0000 Received: from fraeml714-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GmTv86sfxz6FBPV; Sat, 14 Aug 2021 00:45:24 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml714-chm.china.huawei.com (10.206.15.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Fri, 13 Aug 2021 18:46:08 +0200 Received: from [10.47.94.64] (10.47.94.64) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 13 Aug 2021 17:46:07 +0100 Subject: Re: [PATCH 1/4] iommu/arm-smmu-v3: Use command queue batching helpers to improve performance To: Robin Murphy , Zhen Lei , Will Deacon , Joerg Roedel , linux-arm-kernel , iommu , References: <20210811114852.2429-1-thunder.leizhen@huawei.com> <20210811114852.2429-2-thunder.leizhen@huawei.com> <81258eb7-eb73-8a32-0983-3487daba1167@arm.com> From: John Garry Message-ID: <4e741216-d6e7-c40c-f257-242cd2fea302@huawei.com> Date: Fri, 13 Aug 2021 17:45:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <81258eb7-eb73-8a32-0983-3487daba1167@arm.com> Content-Language: en-US X-Originating-IP: [10.47.94.64] X-ClientProxiedBy: lhreml730-chm.china.huawei.com (10.201.108.81) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210813_094624_006212_9B043EBF X-CRM114-Status: UNSURE ( 9.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTMvMDgvMjAyMSAxNzowMSwgUm9iaW4gTXVycGh5IHdyb3RlOgo+Pgo+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMuYyAKPj4gYi9kcml2 ZXJzL2lvbW11L2FybS9hcm0tc21tdS12My9hcm0tc21tdS12My5jCj4+IGluZGV4IDIzNWY5YmRh ZWFmMjIzYi4uYzgxY2Q5MjkwNDdmNTczIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2lvbW11L2Fy bS9hcm0tc21tdS12My9hcm0tc21tdS12My5jCj4+ICsrKyBiL2RyaXZlcnMvaW9tbXUvYXJtL2Fy bS1zbW11LXYzL2FybS1zbW11LXYzLmMKPj4gQEAgLTE3NDcsMTUgKzE3NDcsMTYgQEAgc3RhdGlj IGludCBhcm1fc21tdV9hdGNfaW52X21hc3RlcihzdHJ1Y3QgCj4+IGFybV9zbW11X21hc3RlciAq bWFzdGVyKQo+PiDCoCB7Cj4+IMKgwqDCoMKgwqAgaW50IGk7Cj4+IMKgwqDCoMKgwqAgc3RydWN0 IGFybV9zbW11X2NtZHFfZW50IGNtZDsKPj4gK8KgwqDCoCBzdHJ1Y3QgYXJtX3NtbXVfY21kcV9i YXRjaCBjbWRzID0ge307Cj4gCj4gQlRXLCBpdCBsb29rcyBsaWtlIHRoaXMgaGFzIGNyb3NzZWQg b3ZlciB3aXRoIEpvaG4ncyBwYXRjaCByZW1vdmluZyB0aGVzZS4KCkl0IGlzIG9ubHkgY2FsbGVk IGZyb20gYXJtX3NtbXVfZGlzYWJsZV9hdHMoKSwgc28gbm90IGhvdC1wYXRoIGJ5IHRoZSAKbG9v ayBmb3IgaXQuIE9yIHdobyBldmVuIGhhcyBhdHMgSFcgLi4uPwoKQnV0IGl0IHNob3VsZCBiZSBh dCBsZWFzdCBjbGVhbmVkLXVwIGZvciBjb25zaXN0ZW5jeS4gTGVpemhlbj8KClRoYW5rcywKSm9o bgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=