From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matti Vaittinen <mazziesaccount@gmail.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Paul Gazzillo <paul@pgazz.com>,
Conor Dooley <conor+dt@kernel.org>,
Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: light: Avago APDS9306
Date: Mon, 9 Oct 2023 10:36:13 +0200 [thread overview]
Message-ID: <4e785d2e-d310-4592-a75a-13549938dcef@linaro.org> (raw)
In-Reply-To: <20231008154857.24162-2-subhajit.ghosh@tweaklogic.com>
On 08/10/2023 17:48, Subhajit Ghosh wrote:
> Add devicetree bindings for Avago APDS9306 Ambient Light Sensor.
>
> Signed-off-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
> ---
> .../bindings/iio/light/avago,apds9306.yaml | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml
> new file mode 100644
> index 000000000000..e8bb897782fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/avago,apds9306.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Avago APDS9306 Ambient Light Sensor
> +
> +maintainers:
> + - Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
> +
> +description:
> + Datasheet at https://docs.broadcom.com/doc/AV02-4755EN
This is exactly the same as two other Avago devices. It should be
squashed - first two device schemas squashed, then add new device support.
Also, the supply is not vin, but vdd.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-09 8:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 15:48 [PATCH 0/2] Support for Avago APDS9306 Ambient Light Sensor Subhajit Ghosh
2023-10-08 15:48 ` [PATCH 1/2] dt-bindings: iio: light: Avago APDS9306 Subhajit Ghosh
2023-10-09 8:36 ` Krzysztof Kozlowski [this message]
2023-10-09 11:25 ` Subhajit Ghosh
2023-10-10 8:52 ` Matti Vaittinen
2023-10-10 12:18 ` Subhajit Ghosh
2023-10-10 14:49 ` Jonathan Cameron
2023-10-10 16:19 ` Rob Herring
2023-10-11 13:04 ` Subhajit Ghosh
2023-10-10 13:51 ` Jonathan Cameron
2023-10-11 13:10 ` Subhajit Ghosh
2023-10-08 15:48 ` [PATCH 2/2] iio: light: Add support for APDS9306 Light Sensor Subhajit Ghosh
2023-10-10 9:45 ` Matti Vaittinen
2023-10-10 12:17 ` Subhajit Ghosh
2023-10-10 14:38 ` Jonathan Cameron
2023-10-11 14:37 ` Subhajit Ghosh
2023-10-12 7:54 ` Jonathan Cameron
2023-10-12 12:37 ` Subhajit Ghosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e785d2e-d310-4592-a75a-13549938dcef@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=paul@pgazz.com \
--cc=robh+dt@kernel.org \
--cc=stefan.windfeldt-prytz@axis.com \
--cc=subhajit.ghosh@tweaklogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.