From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AC95C4363D for ; Wed, 23 Sep 2020 23:30:28 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B03C120BED for ; Wed, 23 Sep 2020 23:30:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B03C120BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BxZD119F1zDqYq for ; Thu, 24 Sep 2020 09:30:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jason.m.bills@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BxZBY2MyfzDqW7 for ; Thu, 24 Sep 2020 09:29:07 +1000 (AEST) IronPort-SDR: 3GYGcIcQ0WNHXTsDMhDlouDGInPopyMzQiAKbE73NVErU9I1NDBAgELP3sDL1doGAFbqb2m8io qowLs4riVOag== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="141051144" X-IronPort-AV: E=Sophos;i="5.77,295,1596524400"; d="scan'208";a="141051144" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 16:29:05 -0700 IronPort-SDR: 8E1bIXpRXieZwZowWNV1JxHUzLWrbkb8KP/Om+mvFdrg2qjDungguJAvtjWI6xpKJb7pGWK/w/ 5i0n7sac9lag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,295,1596524400"; d="scan'208";a="486654211" Received: from linux.intel.com ([10.54.29.200]) by orsmga005.jf.intel.com with ESMTP; 23 Sep 2020 16:29:03 -0700 Received: from [10.251.15.151] (jmbills-MOBL.amr.corp.intel.com [10.251.15.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id B8FC1580298 for ; Wed, 23 Sep 2020 16:29:03 -0700 (PDT) Subject: Re: Chassis reset To: openbmc@lists.ozlabs.org References: <9EC0D657-2D58-4544-BA9E-65D3C4148A81@fb.com> <20200923191051.GR6152@heinlein> <20200923202113.GT6152@heinlein> <20200923214237.GV6152@heinlein> From: "Bills, Jason M" Message-ID: <4e78f884-a256-6ae7-fefd-ba3c6cdc0d52@linux.intel.com> Date: Wed, 23 Sep 2020 16:29:03 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On 9/23/2020 3:35 PM, Ed Tanous wrote: > On Wed, Sep 23, 2020 at 3:01 PM Bills, Jason M > wrote: >> >> >> >> On 9/23/2020 2:42 PM, Patrick Williams wrote: >>> >>> I'm not understanding what you mean by "come up with an API to steer the >>> Redfish..." I think everything is specified here at a dbus level. The >>> issue is figuring out the appropriate Redfish model of >>> Chassis/ComputerSystem objects (along with the included Resource.Reset >>> types). To a casual reader, who hasn't been involved much in Redfish >>> implementation, the current mapping of these ResetTypes seems fairly >>> arbitrary. >>> >>> With CIM there use to be these Profile documents that showed "the right >>> way" to fit all these pieces together. Does that not exist with >>> Redfish? How does any external application consume Redfish in a >>> consistent way? >> >> I'm not sure it helps with the overall consistency question, but for >> OpenBMC, we defined our mapping of Redfish ResetType values to Chassis >> and Host State Transitions on D-Bus, here: >> https://github.com/openbmc/docs/blob/838fa962b73deb1ef7908ee8dfa1203fa5263517/designs/state-management-and-external-interfaces.md#proposed-design. >> >> This is what x86-power-control aspires to match and I think what led to >> creating new D-Bus interfaces for the chassis_system and AC power state >> changes (since we didn't want to break this mapping). > > Sounds reasonable, it just makes things slightly more complex for > Redfish, as now there's two things that could be a redfish Chassis > reset. Not a huge deal. > >> >> Perhaps we need to separate the Host and Chassis on the Redfish side and >> extend the D-Bus interfaces to support all the needed ResetTypes? >>> > > I'm not following. There's a Host (ie ComputerSystem) and Chassis in > redfish today. How would we separate them further? I meant in the table here: https://github.com/openbmc/docs/blob/838fa962b73deb1ef7908ee8dfa1203fa5263517/designs/state-management-and-external-interfaces.md#proposed-design. Extend it to include both Chassis and System ResetType values and map them all to the correct State Transition on D-Bus. >