From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BF6C433EF for ; Fri, 8 Jul 2022 01:21:56 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66FDF4069D; Fri, 8 Jul 2022 03:21:55 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 710AC40041 for ; Fri, 8 Jul 2022 03:21:54 +0200 (CEST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LfFpk12zxzpW4q; Fri, 8 Jul 2022 09:21:02 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 8 Jul 2022 09:21:27 +0800 Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 8 Jul 2022 09:21:27 +0800 Message-ID: <4e94f06a-26b5-41f1-efb9-8267419005fd@huawei.com> Date: Fri, 8 Jul 2022 09:21:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] app/testpmd: fix display types failure when query RSS rule To: Ferruh Yigit , CC: , , , , References: <20220707105044.10567-1-lihuisong@huawei.com> <773cea2b-68e3-ac28-b6cc-dd57377144b1@xilinx.com> <4757b6d3-1796-05c3-1324-39c4e541085b@huawei.com> From: "lihuisong (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2022/7/7 21:12, Ferruh Yigit 写道: > On 7/7/2022 1:42 PM, lihuisong (C) wrote: >> CAUTION: This message has originated from an External Source. Please >> use proper judgment and caution when opening attachments, clicking >> links, or responding to this email. >> >> >> 在 2022/7/7 20:22, Ferruh Yigit 写道: >>> On 7/7/2022 11:50 AM, Huisong Li wrote: >>>> Now testpmd fails to display types when query RSS rule. The failure is >>>> because the '\n' character is missing at the end of the function >>>> 'rss_config_display()'. >>>> >>> >>> Bugzilla ID: 1048 >>> >>>> Fixes: 534988c490f1 ("app/testpmd: unify RSS types display") >>>> >>>> Signed-off-by: Huisong Li >>>> --- >>>>   app/test-pmd/config.c | 1 + >>>>   1 file changed, 1 insertion(+) >>>> >>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >>>> index 608bec9796..bcb6d42da3 100644 >>>> --- a/app/test-pmd/config.c >>>> +++ b/app/test-pmd/config.c >>>> @@ -1693,6 +1693,7 @@ rss_config_display(struct rte_flow_action_rss >>>> *rss_conf) >>>>           return; >>>>       } >>>>       rss_types_display(rss_conf->types, >>>> TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE); >>>> +    printf("\n"); >>> >>> >>> Thanks Huisong for the fix. >>> >>> What do you think to have '\n' in the 'rss_types_display()' function >>> and update 'port_rss_hash_conf_show()' usage? >>> >>> And can do same change for 'rss_offload_types_display()', having last >>> '\n' in the function. >> For the quering RSS rule command, the 'rss_types_display()' is the last >> function >> of 'port_flow_query(). But it is not the case in other RSS commands, and >> all have >> ''printf("\n")'' after 'xxx_types_display()'. > > It shouldn't matter if it is last function or not. I think we can make > 'xxx_types_display()' functions self sufficient, without needing > additional '\n' after them. > > Current output of functions: > " > A B C > D E" > > Suggested output" > " > A B C > D E > " Yes, every place calling "xxx_types_display()" needs '\n'. I will move it to the inside of "xxx_types_display()" > > >>> >>>>   } >>>>     static struct port_indirect_action * >>> >>> . > > .