All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, sboyd@codeaurora.org,
	bjorn.andersson@linaro.org, srinivas.kandagatla@linaro.org,
	Fengguang Wu <fengguang.wu@intel.com>,
	linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK
Date: Mon, 10 Apr 2017 12:35:59 +0530	[thread overview]
Message-ID: <4e998bf747cacc9601e9509e32c3a87f@codeaurora.org> (raw)
In-Reply-To: <8f7014dd-612e-fa8f-d7e6-54258d013073@ti.com>

On 2017-04-10 10:52, Kishon Vijay Abraham I wrote:
> On Friday 07 April 2017 01:37 AM, Vivek Gautam wrote:
>> The driver uses clock provider interface, and therefore
>> it fails to build when enabled for COMPILE_TEST, since
>> COMMON_CLK is not enabled at that time.
>> So, make PHY_QCOM_QMP depend on COMMON_CLK as well.
>> 
>> Cc: Fengguang Wu <fengguang.wu@intel.com>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>> ---
>> 
>> Hi Kishon,
>> 
>> This patch is fixing the build failures for architectures
>> such as, tile, and ia64, that don't enable COMMON_CLK by default.
>> You can either squash this into the qmp phy driver patch,
>> or put it as a separate patch with 'Fix' tag.
>> Let me know if you want me to add a 'fix' tag with a reference
>> to the commit ID.
> 
> I squashed it with your earlier patch and pushed.

Thanks Kishon.

Regards
Vivek

> 
> Thanks
> Kishon
> 
>> 
>> Regards
>> Vivek
>> 
>>  drivers/phy/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index bb8140355608..8550d3dc0b71 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -441,7 +441,7 @@ config PHY_STIH407_USB
>> 
>>  config PHY_QCOM_QMP
>>  	tristate "Qualcomm QMP PHY Driver"
>> -	depends on OF && (ARCH_QCOM || COMPILE_TEST)
>> +	depends on OF && COMMON_CLK && (ARCH_QCOM || COMPILE_TEST)
>>  	select GENERIC_PHY
>>  	help
>>  	  Enable this to support the QMP PHY transceiver that is used
>> 
> --
> To unsubscribe from this list: send the line "unsubscribe 
> linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2017-04-10  7:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201704062226.0RxDxHDj%fengguang.wu@intel.com>
     [not found] ` <201704062226.0RxDxHDj%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-06 20:07   ` [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK Vivek Gautam
2017-04-06 20:07     ` Vivek Gautam
2017-04-10  5:22     ` Kishon Vijay Abraham I
2017-04-10  5:22       ` Kishon Vijay Abraham I
2017-04-10  7:05       ` Vivek Gautam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e998bf747cacc9601e9509e32c3a87f@codeaurora.org \
    --to=vivek.gautam@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=fengguang.wu@intel.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-msm-owner@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.