All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] pinctrl: tegra: fix missing __iomem in suspend/resume
Date: Wed, 18 Dec 2019 16:05:26 +0300	[thread overview]
Message-ID: <4ea1d111-478d-5054-a17f-8c2876b71c2f@gmail.com> (raw)
In-Reply-To: <20191218110456.2533088-1-ben.dooks@codethink.co.uk>

18.12.2019 14:04, Ben Dooks (Codethink) пишет:
> The functions should have __iomem on the register pointer
> so add that to silence the following sparse warnings:
> 
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: warning: incorrect type in assignment (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22:    expected unsigned int [usertype] *regs
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22:    got void [noderef] <asn:2> *
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: warning: incorrect type in argument 1 (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42:    expected void const volatile [noderef] <asn:2> *addr
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42:    got unsigned int [usertype] *
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: warning: incorrect type in assignment (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22:    expected unsigned int [usertype] *regs
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22:    got void [noderef] <asn:2> *
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25:    expected void volatile [noderef] <asn:2> *addr
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25:    got unsigned int [usertype] *
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Dmitry Osipenko <digetx@gmail.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> ---
>  drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
> index 692d8b3e2a20..cefbbb8d1a68 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
> @@ -648,7 +648,7 @@ static int tegra_pinctrl_suspend(struct device *dev)
>  {
>  	struct tegra_pmx *pmx = dev_get_drvdata(dev);
>  	u32 *backup_regs = pmx->backup_regs;
> -	u32 *regs;
> +	u32 __iomem *regs;
>  	size_t bank_size;
>  	unsigned int i, k;
>  
> @@ -666,7 +666,7 @@ static int tegra_pinctrl_resume(struct device *dev)
>  {
>  	struct tegra_pmx *pmx = dev_get_drvdata(dev);
>  	u32 *backup_regs = pmx->backup_regs;
> -	u32 *regs;
> +	u32 __iomem *regs;
>  	size_t bank_size;
>  	unsigned int i, k;
>  
> 

Looks good!

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>

  reply	other threads:[~2019-12-18 13:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 11:04 [PATCH] pinctrl: tegra: fix missing __iomem in suspend/resume Ben Dooks (Codethink)
2019-12-18 13:05 ` Dmitry Osipenko [this message]
2019-12-19 13:02 ` Thierry Reding
2020-01-06 23:00 ` Linus Walleij
2020-01-07  8:13   ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ea1d111-478d-5054-a17f-8c2876b71c2f@gmail.com \
    --to=digetx@gmail.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=jonathanh@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.