All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Guo, Jia" <jia.guo@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Zhang, HengjianX" <hengjianx.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40evf: fix packet loss issue for X722
Date: Wed, 24 Feb 2021 02:34:47 +0000	[thread overview]
Message-ID: <4ea4236364b54a89bd01d959afa350f2@intel.com> (raw)
In-Reply-To: <20210224020900.93574-1-beilei.xing@intel.com>

Acked-by: Jeff Guo <jia.guo@intel.com>

> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Wednesday, February 24, 2021 10:09 AM
> To: Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org;
> Zhang, HengjianX <hengjianx.zhang@intel.com>
> Subject: [PATCH] net/i40evf: fix packet loss issue for X722
> 
> From: Beilei Xing <beilei.xing@intel.com>
> 
> When Tx queue number is more than Rx queue number, and RSS is enabled,
> there'll be packet loss with X722.
> The root cause is the lookup table is not configured correctly, since it uses
> VF's queue pair number but not Rx queue number.
> 
> Fixes: 2da3ba746795 ("net/i40e: fix VF runtime queues RSS config")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> Signed-off-by: Hengjian Zhang <hengjianx.zhang@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index 2909b4d894..0c9bd8d2c6 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2746,7 +2746,7 @@ i40evf_config_rss(struct i40e_vf *vf)
>  		}
> 
>  		for (i = 0; i < rss_lut_size; i++)
> -			lut_info[i] = i % vf->num_queue_pairs;
> +			lut_info[i] = i % num;
> 
>  		ret = i40evf_set_rss_lut(&vf->vsi, lut_info,
>  					 rss_lut_size);
> --
> 2.26.2


  reply	other threads:[~2021-02-24  2:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  2:09 [dpdk-dev] [PATCH] net/i40evf: fix packet loss issue for X722 beilei.xing
2021-02-24  2:34 ` Guo, Jia [this message]
2021-03-05  8:49   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ea4236364b54a89bd01d959afa350f2@intel.com \
    --to=jia.guo@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=hengjianx.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.