From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] legal-info: rename legal-warning-pkg-savednothing helper
Date: Sat, 14 Jun 2014 17:10:23 +0200 [thread overview]
Message-ID: <4ea524430e932e989a86440588d9cf5122aa03ce.1402758331.git.yann.morin.1998@free.fr> (raw)
In-Reply-To: <cover.1402758331.git.yann.morin.1998@free.fr>
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
This helper was called when none of the sources or license
files were saved.
Now we handle license files separately from the sources,
this is no longer the case: they are only called when the
sources are not saved.
Rename the handler and change the warning message accordingly.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Fabio Porcedda <fabio.porcedda@gmail.com>
---
package/pkg-generic.mk | 4 ++--
package/pkg-utils.mk | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index d16908a..8a32f9d 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -640,10 +640,10 @@ endif # license files
ifeq ($$($(2)_SITE_METHOD),local)
# Packages without a tarball: don't save and warn
- @$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),local)
+ @$(call legal-license-nosource,$$($(2)_RAWNAME),local)
else ifneq ($$($(2)_OVERRIDE_SRCDIR),)
- @$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),override)
+ @$(call legal-license-nosource,$$($(2)_RAWNAME),override)
else
# Other packages
diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
index 163ef8a..471f3ed 100644
--- a/package/pkg-utils.mk
+++ b/package/pkg-utils.mk
@@ -101,8 +101,8 @@ define legal-warning-pkg # pkg, text
echo "WARNING: $(1): $(2)" >>$(LEGAL_WARNINGS)
endef
-define legal-warning-pkg-savednothing # pkg, {local|override}
- $(call legal-warning-pkg,$(1),sources and license files not saved ($(2) packages not handled))
+define legal-license-nosource # pkg, {local|override}
+ $(call legal-warning-pkg,$(1),sources not saved ($(2) packages not handled))
endef
define legal-manifest # pkg, version, license, license-files, source, {HOST|TARGET}
--
1.8.3.2
next prev parent reply other threads:[~2014-06-14 15:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-14 15:10 [Buildroot] [PATCH 0/5 v5] legal-info: extract packages to get license files (branch yem/legal) Yann E. MORIN
2014-06-14 15:10 ` [Buildroot] [PATCH 1/5] legal-info: extract even no-redistribute packages Yann E. MORIN
2014-06-18 21:17 ` Luca Ceresoli
2014-06-21 22:08 ` Yann E. MORIN
2014-06-14 15:10 ` [Buildroot] [PATCH 2/5] legal-info: save license files even for local or overriden packages Yann E. MORIN
2014-06-18 21:22 ` Luca Ceresoli
2014-06-14 15:10 ` [Buildroot] [PATCH 3/5] legal-info: add a comment about what packages we save the tarballs of Yann E. MORIN
2014-06-18 21:25 ` Luca Ceresoli
2014-06-14 15:10 ` Yann E. MORIN [this message]
2014-06-18 15:32 ` [Buildroot] [PATCH 4/5] legal-info: rename legal-warning-pkg-savednothing helper Luca Ceresoli
2014-06-21 22:17 ` Yann E. MORIN
2014-06-14 15:10 ` [Buildroot] [PATCH 5/5] legal-info: properly error out on missing license file Yann E. MORIN
2014-06-18 21:38 ` Luca Ceresoli
2014-06-21 22:35 ` Yann E. MORIN
2014-06-15 10:42 ` [Buildroot] [PATCH 0/5 v5] legal-info: extract packages to get license files (branch yem/legal) Yann E. MORIN
2014-06-18 16:00 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ea524430e932e989a86440588d9cf5122aa03ce.1402758331.git.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.