From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A9C3C10F29 for ; Tue, 17 Mar 2020 16:43:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A1D220735 for ; Tue, 17 Mar 2020 16:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726823AbgCQQnJ (ORCPT ); Tue, 17 Mar 2020 12:43:09 -0400 Received: from foss.arm.com ([217.140.110.172]:40394 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726157AbgCQQnJ (ORCPT ); Tue, 17 Mar 2020 12:43:09 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2465E30E; Tue, 17 Mar 2020 09:43:08 -0700 (PDT) Received: from [10.37.12.228] (unknown [10.37.12.228]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EEF153F52E; Tue, 17 Mar 2020 09:43:03 -0700 (PDT) Subject: Re: [PATCH v4 18/26] arm64: vdso32: Replace TASK_SIZE_32 check in vgettimeofday From: Vincenzo Frascino To: Catalin Marinas Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, linux-mips@vger.kernel.org, x86@kernel.org, Will Deacon , Arnd Bergmann , Russell King , Paul Burton , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , Borislav Petkov , Stephen Boyd , Mark Salyzyn , Kees Cook , Peter Collingbourne , Dmitry Safonov <0x7f454c46@gmail.com>, Andrei Vagin , Nick Desaulniers , Marc Zyngier , Mark Rutland , Will Deacon References: <20200317122220.30393-1-vincenzo.frascino@arm.com> <20200317122220.30393-19-vincenzo.frascino@arm.com> <20200317143834.GC632169@arrakis.emea.arm.com> <20200317155031.GD632169@arrakis.emea.arm.com> <83aaf9e1-0a8f-4908-577a-23766541b2ba@arm.com> Message-ID: <4eaa8717-78b4-0f28-6e14-9a0765e179c5@arm.com> Date: Tue, 17 Mar 2020 16:43:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83aaf9e1-0a8f-4908-577a-23766541b2ba@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/17/20 4:40 PM, Vincenzo Frascino wrote: > Hi Catalin, > > On 3/17/20 3:50 PM, Catalin Marinas wrote: >> On Tue, Mar 17, 2020 at 03:04:01PM +0000, Vincenzo Frascino wrote: >>> On 3/17/20 2:38 PM, Catalin Marinas wrote: >>>> On Tue, Mar 17, 2020 at 12:22:12PM +0000, Vincenzo Frascino wrote: > > [...] > >>> >>> Can TASK_SIZE > UINTPTR_MAX on an arm64 system? >> >> TASK_SIZE yes on arm64 but not TASK_SIZE_32. I was asking about the >> arm32 check where TASK_SIZE < UINTPTR_MAX. How does the vdsotest return >> -EFAULT on arm32? Which code path causes this in the user vdso code? >> > > Sorry I got confused because you referred to arch/arm/vdso/vgettimeofday.c which > is the arm64 implementation, not the compat one :) > I stand corrected arch/*arm*/vdso/vgettimeofday.c is definitely the arm32 implemetation... I got completely confused here :) -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincenzo Frascino Subject: Re: [PATCH v4 18/26] arm64: vdso32: Replace TASK_SIZE_32 check in vgettimeofday Date: Tue, 17 Mar 2020 16:43:32 +0000 Message-ID: <4eaa8717-78b4-0f28-6e14-9a0765e179c5@arm.com> References: <20200317122220.30393-1-vincenzo.frascino@arm.com> <20200317122220.30393-19-vincenzo.frascino@arm.com> <20200317143834.GC632169@arrakis.emea.arm.com> <20200317155031.GD632169@arrakis.emea.arm.com> <83aaf9e1-0a8f-4908-577a-23766541b2ba@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from foss.arm.com ([217.140.110.172]:40394 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726157AbgCQQnJ (ORCPT ); Tue, 17 Mar 2020 12:43:09 -0400 In-Reply-To: <83aaf9e1-0a8f-4908-577a-23766541b2ba@arm.com> Content-Language: en-US Sender: linux-arch-owner@vger.kernel.org List-ID: To: Catalin Marinas Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, linux-mips@vger.kernel.org, x86@kernel.org, Will Deacon , Arnd Bergmann , Russell King , Paul Burton , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , Borislav Petkov , Stephen Boyd , Mark Salyzyn , Kees Cook , Peter Collingbourne , Dmitry Safonov <0x7f454c46@gmail.com>, Andrei Vagin , Nick Desaulniers , Marc Zyngier Mark On 3/17/20 4:40 PM, Vincenzo Frascino wrote: > Hi Catalin, > > On 3/17/20 3:50 PM, Catalin Marinas wrote: >> On Tue, Mar 17, 2020 at 03:04:01PM +0000, Vincenzo Frascino wrote: >>> On 3/17/20 2:38 PM, Catalin Marinas wrote: >>>> On Tue, Mar 17, 2020 at 12:22:12PM +0000, Vincenzo Frascino wrote: > > [...] > >>> >>> Can TASK_SIZE > UINTPTR_MAX on an arm64 system? >> >> TASK_SIZE yes on arm64 but not TASK_SIZE_32. I was asking about the >> arm32 check where TASK_SIZE < UINTPTR_MAX. How does the vdsotest return >> -EFAULT on arm32? Which code path causes this in the user vdso code? >> > > Sorry I got confused because you referred to arch/arm/vdso/vgettimeofday.c which > is the arm64 implementation, not the compat one :) > I stand corrected arch/*arm*/vdso/vgettimeofday.c is definitely the arm32 implemetation... I got completely confused here :) -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC695C10F29 for ; Tue, 17 Mar 2020 16:43:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82EA120663 for ; Tue, 17 Mar 2020 16:43:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S9SIOG1V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82EA120663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3T0LFi19dC4ePNdluE7hBJ2fpiCnIxTAmbd4FpOzpK8=; b=S9SIOG1VD/EG24 SJnDhTUu4rtx8iMDqJjyi56eqv6hgylUBDooGm/An3+hLBeqoK2+k0dmj/CGhv7nexGdavefnPsSo 41AQtO5uRhSGkl9hD3NJ0YpDqIbY/FSwnif71NOrrqaBXGD1Jve4z516+GfttfvGpcAIMRjNMxyB+ fw2SlUaGWI8ArpbAsopnEXWtKySi2SyYRgE9AsKDp4sbM8vfIRJCQJIHM9ORmlQfN7g3jDA9wOCt0 n3b6jexXtFJ6jDbzzAMUQLorXocTLlReN1RQwBK8wSQKokUOWquch8JO1vqAQ5HLBQhIpjVcL3/+6 sZ63SZHgrX88tx9bKwTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEFJ9-0007fo-Tx; Tue, 17 Mar 2020 16:43:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEFJ6-0007fF-QT for linux-arm-kernel@lists.infradead.org; Tue, 17 Mar 2020 16:43:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2465E30E; Tue, 17 Mar 2020 09:43:08 -0700 (PDT) Received: from [10.37.12.228] (unknown [10.37.12.228]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EEF153F52E; Tue, 17 Mar 2020 09:43:03 -0700 (PDT) Subject: Re: [PATCH v4 18/26] arm64: vdso32: Replace TASK_SIZE_32 check in vgettimeofday From: Vincenzo Frascino To: Catalin Marinas References: <20200317122220.30393-1-vincenzo.frascino@arm.com> <20200317122220.30393-19-vincenzo.frascino@arm.com> <20200317143834.GC632169@arrakis.emea.arm.com> <20200317155031.GD632169@arrakis.emea.arm.com> <83aaf9e1-0a8f-4908-577a-23766541b2ba@arm.com> Message-ID: <4eaa8717-78b4-0f28-6e14-9a0765e179c5@arm.com> Date: Tue, 17 Mar 2020 16:43:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83aaf9e1-0a8f-4908-577a-23766541b2ba@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200317_094308_897699_F4955EB9 X-CRM114-Status: GOOD ( 13.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Dmitry Safonov <0x7f454c46@gmail.com>, linux-mips@vger.kernel.org, Will Deacon , linux-arch@vger.kernel.org, Marc Zyngier , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Kees Cook , Arnd Bergmann , Will Deacon , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, Andrei Vagin , Stephen Boyd , Nick Desaulniers , linux-kernel@vger.kernel.org, Mark Salyzyn , Paul Burton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/17/20 4:40 PM, Vincenzo Frascino wrote: > Hi Catalin, > > On 3/17/20 3:50 PM, Catalin Marinas wrote: >> On Tue, Mar 17, 2020 at 03:04:01PM +0000, Vincenzo Frascino wrote: >>> On 3/17/20 2:38 PM, Catalin Marinas wrote: >>>> On Tue, Mar 17, 2020 at 12:22:12PM +0000, Vincenzo Frascino wrote: > > [...] > >>> >>> Can TASK_SIZE > UINTPTR_MAX on an arm64 system? >> >> TASK_SIZE yes on arm64 but not TASK_SIZE_32. I was asking about the >> arm32 check where TASK_SIZE < UINTPTR_MAX. How does the vdsotest return >> -EFAULT on arm32? Which code path causes this in the user vdso code? >> > > Sorry I got confused because you referred to arch/arm/vdso/vgettimeofday.c which > is the arm64 implementation, not the compat one :) > I stand corrected arch/*arm*/vdso/vgettimeofday.c is definitely the arm32 implemetation... I got completely confused here :) -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel