From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42CEC433B4 for ; Mon, 17 May 2021 05:28:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A0FF6101B for ; Mon, 17 May 2021 05:28:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A0FF6101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liVo8-0006ZE-Fu for qemu-devel@archiver.kernel.org; Mon, 17 May 2021 01:28:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liVmm-0005N5-G4; Mon, 17 May 2021 01:27:24 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:54208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1liVmh-0002QQ-DT; Mon, 17 May 2021 01:27:24 -0400 Received: by mail-wm1-x333.google.com with SMTP id 62so1793489wmb.3; Sun, 16 May 2021 22:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3CtS9VRwM3InD0PGwlK54ZrR8rhtiT3SkoXXxD+MF90=; b=mzgnf3igaFPIl3j2nfhIGZ4Mr6b4wkCroJYvv7hO629iajbsLT6+n8YnmHgmKNhvcd cOC2qNvSx4dgEKsiRcdXPj9uXVvHWvJrQWoV24IaA5qgwGQK4wtuG0dN6qcF6Pa7SaSb oYGQUUrseWHMYx0TDI74rc6lZ8JcB6Lo9x+n2jM0AmilNSjy5xglfAlM0eWlD8WNEJkw qIaIraLf7KvBY3T6awQmZ/YoSur5KPWZx7R6yy8zXCwmv04YKL2iqqEwuywip7zUrSq1 0l3yi2B3YzdAlFxKDrW8nQ6dDqOS3A80RzgZICMCDAAFair3vYnKF0chNTb12A6ZAW5W 3fjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3CtS9VRwM3InD0PGwlK54ZrR8rhtiT3SkoXXxD+MF90=; b=VNPd3tG79168w0SEocDmJBKysnsjYuhYgYLax9u3JrD7Rts4JfsJebejRCWJ3wnWB5 2c+UFW8swlrf1VTkYBtJ522RXcwFi1UJ/7JeDl8oteDzPFcFAkIFah+Z+UJTWTXf8/G6 TJfYBPp1PVNorNgGBqy9REaTovwgp0X8UJpFr+RLxefl3OP7JqHui5LU3nw78EUQy68v uyWa0lJXt2+EclTWR/311p/C5CAMf88mIzQIl48liCIvr+Vy2cfUlbi/BH2XhV41SmWy 9khDNvofDEsxfHurl9nTm6Jz2F993Fwco9rk7NoZP8vcI0gLGjWj5zW4hcTQVMVIs/ix z6QQ== X-Gm-Message-State: AOAM531ikk0g9KEGmmq+NUWOvuf9x+lr4sI41BK36xSk3FezxSGYSE+5 Do6dIeyPm2vbV8qSE7uyCIk= X-Google-Smtp-Source: ABdhPJxnyMqqZzPJTQiYpeMQPh/YlqoVk3SbI+puYNqpTMCf6L/AZZmQJ7IX/heyMyJ1qxHlzvjzUg== X-Received: by 2002:a05:600c:154f:: with SMTP id f15mr20362081wmg.81.1621229236440; Sun, 16 May 2021 22:27:16 -0700 (PDT) Received: from [192.168.1.36] (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id f20sm15036686wmh.41.2021.05.16.22.27.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 May 2021 22:27:15 -0700 (PDT) Subject: Re: [PATCH v6 08/18] cpu/{avr, lm32, moxie}: Set DeviceClass vmsd field (not CPUClass one) To: Richard Henderson , qemu-devel@nongnu.org References: <20210422193902.2644064-1-f4bug@amsat.org> <20210422193902.2644064-9-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <4ee022bf-5873-e689-8549-a8ca0bfda64a@amsat.org> Date: Mon, 17 May 2021 07:27:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-riscv@nongnu.org, Eduardo Habkost , Juan Quintela , qemu-s390x@nongnu.org, Anthony Green , "Dr. David Alan Gilbert" , Laurent Vivier , Michael Walle , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Claudio Fontana , Michael Rolnik Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/23/21 3:16 AM, Richard Henderson wrote: > On 4/22/21 12:38 PM, Philippe Mathieu-Daudé wrote: >> See rationale in previous commit. Targets should use the vmsd field >> of DeviceClass, not CPUClass. As migration is not important on the >> avr/lm32/moxie targets, break the migration compatibility and set >> the DeviceClass vmsd field. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   target/avr/cpu.c   | 2 +- >>   target/lm32/cpu.c  | 2 +- >>   target/moxie/cpu.c | 2 +- >>   3 files changed, 3 insertions(+), 3 deletions(-) > > Do you not have to increment the vmstate versions? > > Though I can't see how the version numbers would even get compared, > since we're looking for them in different locations? Yes, I am not sure how that will work. Anyway, better safe than sorry! From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1liVmo-0005NU-1P for mharc-qemu-riscv@gnu.org; Mon, 17 May 2021 01:27:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liVmm-0005N5-G4; Mon, 17 May 2021 01:27:24 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:54208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1liVmh-0002QQ-DT; Mon, 17 May 2021 01:27:24 -0400 Received: by mail-wm1-x333.google.com with SMTP id 62so1793489wmb.3; Sun, 16 May 2021 22:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3CtS9VRwM3InD0PGwlK54ZrR8rhtiT3SkoXXxD+MF90=; b=mzgnf3igaFPIl3j2nfhIGZ4Mr6b4wkCroJYvv7hO629iajbsLT6+n8YnmHgmKNhvcd cOC2qNvSx4dgEKsiRcdXPj9uXVvHWvJrQWoV24IaA5qgwGQK4wtuG0dN6qcF6Pa7SaSb oYGQUUrseWHMYx0TDI74rc6lZ8JcB6Lo9x+n2jM0AmilNSjy5xglfAlM0eWlD8WNEJkw qIaIraLf7KvBY3T6awQmZ/YoSur5KPWZx7R6yy8zXCwmv04YKL2iqqEwuywip7zUrSq1 0l3yi2B3YzdAlFxKDrW8nQ6dDqOS3A80RzgZICMCDAAFair3vYnKF0chNTb12A6ZAW5W 3fjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3CtS9VRwM3InD0PGwlK54ZrR8rhtiT3SkoXXxD+MF90=; b=VNPd3tG79168w0SEocDmJBKysnsjYuhYgYLax9u3JrD7Rts4JfsJebejRCWJ3wnWB5 2c+UFW8swlrf1VTkYBtJ522RXcwFi1UJ/7JeDl8oteDzPFcFAkIFah+Z+UJTWTXf8/G6 TJfYBPp1PVNorNgGBqy9REaTovwgp0X8UJpFr+RLxefl3OP7JqHui5LU3nw78EUQy68v uyWa0lJXt2+EclTWR/311p/C5CAMf88mIzQIl48liCIvr+Vy2cfUlbi/BH2XhV41SmWy 9khDNvofDEsxfHurl9nTm6Jz2F993Fwco9rk7NoZP8vcI0gLGjWj5zW4hcTQVMVIs/ix z6QQ== X-Gm-Message-State: AOAM531ikk0g9KEGmmq+NUWOvuf9x+lr4sI41BK36xSk3FezxSGYSE+5 Do6dIeyPm2vbV8qSE7uyCIk= X-Google-Smtp-Source: ABdhPJxnyMqqZzPJTQiYpeMQPh/YlqoVk3SbI+puYNqpTMCf6L/AZZmQJ7IX/heyMyJ1qxHlzvjzUg== X-Received: by 2002:a05:600c:154f:: with SMTP id f15mr20362081wmg.81.1621229236440; Sun, 16 May 2021 22:27:16 -0700 (PDT) Received: from [192.168.1.36] (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id f20sm15036686wmh.41.2021.05.16.22.27.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 May 2021 22:27:15 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH v6 08/18] cpu/{avr, lm32, moxie}: Set DeviceClass vmsd field (not CPUClass one) To: Richard Henderson , qemu-devel@nongnu.org Cc: Peter Maydell , Michael Walle , qemu-riscv@nongnu.org, Eduardo Habkost , Juan Quintela , Anthony Green , "Dr. David Alan Gilbert" , Laurent Vivier , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Claudio Fontana , Michael Rolnik References: <20210422193902.2644064-1-f4bug@amsat.org> <20210422193902.2644064-9-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <4ee022bf-5873-e689-8549-a8ca0bfda64a@amsat.org> Date: Mon, 17 May 2021 07:27:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2021 05:27:25 -0000 On 4/23/21 3:16 AM, Richard Henderson wrote: > On 4/22/21 12:38 PM, Philippe Mathieu-Daudé wrote: >> See rationale in previous commit. Targets should use the vmsd field >> of DeviceClass, not CPUClass. As migration is not important on the >> avr/lm32/moxie targets, break the migration compatibility and set >> the DeviceClass vmsd field. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   target/avr/cpu.c   | 2 +- >>   target/lm32/cpu.c  | 2 +- >>   target/moxie/cpu.c | 2 +- >>   3 files changed, 3 insertions(+), 3 deletions(-) > > Do you not have to increment the vmstate versions? > > Though I can't see how the version numbers would even get compared, > since we're looking for them in different locations? Yes, I am not sure how that will work. Anyway, better safe than sorry!