From: Jacob Keller <jacob.e.keller@intel.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, valex@mellanox.com
Subject: Re: [PATCH 1/2] devlink: correct misspelling of snapshot
Date: Fri, 10 Jan 2020 09:47:31 -0800 [thread overview]
Message-ID: <4eeb5bca-19bd-509f-ed9c-e8891f6022fc@intel.com> (raw)
In-Reply-To: <20200110093636.GK2235@nanopsycho.orion>
On 1/10/2020 1:36 AM, Jiri Pirko wrote:
> Thu, Jan 09, 2020 at 08:08:20PM CET, jacob.e.keller@intel.com wrote:
>> The function to obtain a unique snapshot id was mistakenly typo'd as
>> devlink_region_shapshot_id_get. Fix this typo by renaming the function
>> and all of its users.
>>
>> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
>
> If you want to send this as a patchset, please provide a cover letter.
>
> This patch looks fine to me.
>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
>
I don't really care about it being merged as a series, I just searched
for the shapshot typo and tried to fix it everywhere.
It doesn't seem worth the effort to resend with a cover letter..
Thanks,
Jake
next prev parent reply other threads:[~2020-01-10 17:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 19:08 [PATCH 1/2] devlink: correct misspelling of snapshot Jacob Keller
2020-01-09 19:08 ` [PATCH 2/2] doc: fix typo of snapshot in documentation Jacob Keller
2020-01-09 20:00 ` Stephen Hemminger
2020-01-09 20:06 ` Jacob Keller
2020-01-09 20:11 ` Jacob Keller
2020-01-09 20:36 ` Stephen Hemminger
2020-01-11 0:49 ` David Miller
2020-01-10 9:36 ` [PATCH 1/2] devlink: correct misspelling of snapshot Jiri Pirko
2020-01-10 17:47 ` Jacob Keller [this message]
2020-01-11 0:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eeb5bca-19bd-509f-ed9c-e8891f6022fc@intel.com \
--to=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.