All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>,
	dev@dpdk.org, alejandro.lucero@netronome.com
Cc: reshma.pattan@intel.com, rmody@marvell.com, shshaikh@marvell.com,
	beilei.xing@intel.com, qi.z.zhang@intel.com,
	pablo.de.lara.guarch@intel.com, declan.doherty@intel.com,
	stable@dpdk.org
Subject: Re: [PATCH] drivers: fix to replace strcat with strncat
Date: Mon, 14 Jan 2019 13:29:38 +0000	[thread overview]
Message-ID: <4eefd77e-aaec-90ce-05df-f320dc01af66@intel.com> (raw)
In-Reply-To: <1547445875-24601-1-git-send-email-tallurix.chaitanya.babu@intel.com>

On 1/14/2019 6:04 AM, Chaitanya Babu Talluri wrote:
> Strcat does not check the destination length and there might be
> chances of string overflow so insted of strcat, strncat is used.
> 
> Fixes: 540a211084 ("bnx2x: driver core")
> Fixes: e163c18a15 ("net/i40e: update ptype and pctype info")
> Fixes: ef28aa96e5 ("net/nfp: support multiprocess")
> Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>

<...>

> @@ -685,11 +687,11 @@ nfp_acquire_secondary_process_lock(struct nfp_pcie_user *desc)
>  	 * driver is used because that implies root user.
>  	 */
>  	home_path = getenv("HOME");
> -	lockfile = calloc(strlen(home_path) + strlen(lockname) + 1,
> +	lockfile = calloc(LOCKFILE_HOME_PATH + strlen(lockname) + 1,
>  			  sizeof(char));
>  
> -	strcat(lockfile, home_path);
> -	strcat(lockfile, "/.lock_nfp_secondary");
> +	strncat(lockfile, home_path, LOCKFILE_HOME_PATH);
> +	strncat(lockfile, lockname, strlen(lockfile));

I guess this need to be 'LOCKFILE_HOME_PATH - strlen(lockfile) - 1' instead.
But also this can be implemented as 'snprintf()'

Since 'lockfile' allocated dynamically based on sizes of existing strings, using
'lockname' instead of "/.lock_nfp_secondary" will show that there won't be any
overflow but tools still may be complaining about 'strcat' usage.

  reply	other threads:[~2019-01-14 13:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  6:04 [PATCH] drivers: fix to replace strcat with strncat Chaitanya Babu Talluri
2019-01-14 13:29 ` Ferruh Yigit [this message]
2019-01-14 16:24   ` Stephen Hemminger
2019-01-17 16:44     ` Thomas Monjalon
2019-01-14 14:21 ` Bruce Richardson
2019-01-15  1:53   ` Thomas Monjalon
2019-01-18 15:11 ` [PATCH v2] " Chaitanya Babu Talluri
2019-01-18 15:23 ` Chaitanya Babu Talluri
2019-01-21 10:43   ` Parthasarathy, JananeeX M
2019-02-07 11:56     ` Ferruh Yigit
2019-02-07 12:08       ` Thomas Monjalon
2019-02-07 13:27       ` Bruce Richardson
2019-02-13 11:54         ` Ferruh Yigit
2019-02-27  6:02   ` [PATCH v3] drivers: fix to replace strcat with strlcat Chaitanya Babu Talluri
2019-02-27  9:43     ` [dpdk-stable] " Ferruh Yigit
2019-02-27  9:49     ` Bruce Richardson
2019-02-27 10:26     ` Pattan, Reshma
2019-03-05 13:14     ` [PATCH v4] drivers: fix possible overflow with strcat Chaitanya Babu Talluri
2019-03-06 18:14       ` [dpdk-stable] " Ferruh Yigit
2019-03-07 12:56       ` [PATCH v5] " Chaitanya Babu Talluri
2019-03-13 18:39         ` Ferruh Yigit
2019-03-14 13:34         ` [PATCH v6] drivers/net: " Chaitanya Babu Talluri
2019-03-14 14:09           ` Pattan, Reshma
2019-03-18 12:41           ` [PATCH v7] drivers/net: fix possible overflow using strlcat Chaitanya Babu Talluri
2019-03-20 20:18             ` Ferruh Yigit
2019-03-22  7:51             ` [PATCH v8] " Chaitanya Babu Talluri
2019-03-22  8:02               ` [EXT] " Shahed Shaikh
2019-03-22 10:35                 ` [dpdk-stable] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4eefd77e-aaec-90ce-05df-f320dc01af66@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=beilei.xing@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=rmody@marvell.com \
    --cc=shshaikh@marvell.com \
    --cc=stable@dpdk.org \
    --cc=tallurix.chaitanya.babu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.