From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH 1/2] memalloc: do not leave unmapped holes in
 EAL virtual memory area
Date: Fri, 1 Jun 2018 15:59:42 +0100
Message-ID: <4ef183de-b569-efa7-f9a7-17593c4ab5b4@intel.com>
References: <1527857469-159391-1-git-send-email-dariuszx.stojaczyk@intel.com>
 <4ad00805-bf12-7426-4040-6a44c51226f2@intel.com>
 <FBE7E039FA50BF47A673AD0BD3CD56A846142C02@HASMSX105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: "Stojaczyk, DariuszX" <dariuszx.stojaczyk@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id D37A14F94
 for <dev@dpdk.org>; Fri,  1 Jun 2018 16:59:44 +0200 (CEST)
In-Reply-To: <FBE7E039FA50BF47A673AD0BD3CD56A846142C02@HASMSX105.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

>> Page size shouldn't be zero, should be alloc_sz.
> 
> The 0 above is for the `flags` parameter. Page size is set to alloc_sz.
> 
> ```
> void *
> eal_get_virtual_area(void *requested_addr, size_t *size,
> 		size_t page_sz, int flags, int mmap_flags);
> ```
> 
> I believe it's okay. Correct me if I'm wrong.

Apologies, you're right. I misread the code.


-- 
Thanks,
Anatoly