From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C43729CA for ; Mon, 18 Oct 2021 07:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634543815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pW1J9ofif2zOmnDiVcKxrIN5ntR57Bu+Zk3Ktoioz/k=; b=HTu6PwG50sa4c80pB6TnziH2zSK291uT1aH0Fr638cFVM76dZKREcfYrGVF6oRCbew/BBJ bZjdlLEgs466ip5KCvVcDUeL1FeVqwBbguBQyqSAMUOTjIcg9LbqUJffY2Y50ESwsF1cex 4I/7Ksplo7UGPoKz6sluap0shbgu18Y= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-123-rnP98EeCO_O8S36dsM45lw-1; Mon, 18 Oct 2021 03:56:54 -0400 X-MC-Unique: rnP98EeCO_O8S36dsM45lw-1 Received: by mail-ed1-f70.google.com with SMTP id r11-20020aa7cfcb000000b003d4fbd652b9so13553029edy.14 for ; Mon, 18 Oct 2021 00:56:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pW1J9ofif2zOmnDiVcKxrIN5ntR57Bu+Zk3Ktoioz/k=; b=pIOUbCFjMrgySjB8Pivwq6Q9o5ymrhVeF3bm3muYyBb4+U4TblUw0L6dPSbD9uDv8u hXZyg8b+vUGbpWFSGHRYODLNmoUW/4gi4w+0SpPFCaCmVm4ZN44Zu2UG1WFGYkKMgNFT 1Or5LZWmwup2GduINg75T+Xz8YOi31pBFwzR0TSUepwIwbPwr8JvdR3MxAy/0TX7Sckd tjMDgmlyPvjHeCD00UPULJDXlfQj2qB21mo6tutvyd6ob+5A/zChR5k8z+jEQRWzD5I5 qPxCjPniwpEuY6f91N5OvMKMw+iNsO/JL4k//x42qf7fOxjXKNE7cWbvLGfJfOnFJAG7 YHZQ== X-Gm-Message-State: AOAM5301cfnXHPvPpFui1XV5F16wFsT8Qa3BgC3c2wU9i3P1HKYwSE7+ VmHWfikEcrT4wzvb0Ft9wrEfRVawRbIAkhzJfkiko6Z7BfW8C14tc1eoNhAGY0j4AvBH9uqkx1I JBhuv1annM4n9x2RiFMWA6pA3cw== X-Received: by 2002:a17:906:2346:: with SMTP id m6mr27676652eja.512.1634543813115; Mon, 18 Oct 2021 00:56:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMAfba/aRuzrULmiVfI2mevsZfFAWys1fo4WzU1WEccjOT3FVMM/D0QV8aWm6hTOUVtiKILA== X-Received: by 2002:a17:906:2346:: with SMTP id m6mr27676640eja.512.1634543812932; Mon, 18 Oct 2021 00:56:52 -0700 (PDT) Received: from [10.40.1.223] ([81.30.35.201]) by smtp.gmail.com with ESMTPSA id j3sm3614741ejo.2.2021.10.18.00.56.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Oct 2021 00:56:52 -0700 (PDT) Message-ID: <4ef1f770-f15f-ff11-bc64-ccd461dfdf61@redhat.com> Date: Mon, 18 Oct 2021 09:56:52 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 16/17] [NOT-FOR-MERGE] media: atomsip: pci: add DMI match for Microsoft Surface 3 with broken DMI (OEMB) To: Tsuchiya Yuto Cc: Patrik Gfeller , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Aniket Bhattacharyea , Aline Santana Cordeiro , Yang Yingliang , Hans Verkuil , Alan , Dinghao Liu , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20211017161958.44351-1-kitakar@gmail.com> <20211017161958.44351-17-kitakar@gmail.com> From: Hans de Goede In-Reply-To: <20211017161958.44351-17-kitakar@gmail.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 10/17/21 18:19, Tsuchiya Yuto wrote: > This commit is added for Surface 3 with broken DMI table. HACK-ish. > Not intended for upstreaming. Thus, NOT-FOR-MERGE. But, if someone > knows a nicer way to address this, comments are welcome... > >> 8-----------------------------------------------------------------8< > > On some Microsoft Surface 3, the DMI table gets corrupted for unknown > reasons and breaks existing DMI matching used for device-specific quirks. > > This commit adds the (broken) DMI data into dmi_system_id tables used > for quirks so that the driver can enable quirks even on the affected > systems. > > On affected systems, the DMI data will look like this: > > $ grep . /sys/devices/virtual/dmi/id/{bios_vendor,board_name,board_vendor,\ > chassis_vendor,product_name,sys_vendor} > /sys/devices/virtual/dmi/id/bios_vendor:American Megatrends Inc. > /sys/devices/virtual/dmi/id/board_name:OEMB > /sys/devices/virtual/dmi/id/board_vendor:OEMB > /sys/devices/virtual/dmi/id/chassis_vendor:OEMB > /sys/devices/virtual/dmi/id/product_name:OEMB > /sys/devices/virtual/dmi/id/sys_vendor:OEMB I wonder what the bios_date field contains ? Typically when the DMI strings are no good (e.g. often they contain "Default String" or "To be filled by OEM") we add a check on the bios-date, which together with the broken strings is considered unique enough to still allow a match with broken strings in the kernel. Also have you tried doing something like "load bios/setup defaults" in the BIOS setup ? Maybe that helps ? Regards, Hans > > Expected: > > $ grep . /sys/devices/virtual/dmi/id/{bios_vendor,board_name,board_vendor,\ > chassis_vendor,product_name,sys_vendor} > /sys/devices/virtual/dmi/id/bios_vendor:American Megatrends Inc. > /sys/devices/virtual/dmi/id/board_name:Surface 3 > /sys/devices/virtual/dmi/id/board_vendor:Microsoft Corporation > /sys/devices/virtual/dmi/id/chassis_vendor:Microsoft Corporation > /sys/devices/virtual/dmi/id/product_name:Surface 3 > /sys/devices/virtual/dmi/id/sys_vendor:Microsoft Corporation > > Signed-off-by: Tsuchiya Yuto > --- > .../staging/media/atomisp/pci/atomisp_gmin_platform.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c > index 948eb6f809f5..3868d64cbc2b 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c > @@ -377,6 +377,17 @@ static const struct dmi_system_id gmin_vars[] = { > }, > .driver_data = surface3_vars, > }, > + { > + .ident = "Surface 3", > + .matches = { > + /* DMI data for Surface 3 with broken DMI table */ > + DMI_MATCH(DMI_BIOS_VENDOR, "American Megatrends Inc."), > + DMI_MATCH(DMI_BOARD_NAME, "OEMB"), > + DMI_MATCH(DMI_PRODUCT_NAME, "OEMB"), > + DMI_MATCH(DMI_SYS_VENDOR, "OEMB"), > + }, > + .driver_data = surface3_vars, > + }, > {} > }; > >