From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52431C433E6 for ; Sat, 6 Feb 2021 04:07:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C56A64E34 for ; Sat, 6 Feb 2021 04:07:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbhBFEHa (ORCPT ); Fri, 5 Feb 2021 23:07:30 -0500 Received: from mail29.static.mailgun.info ([104.130.122.29]:12718 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbhBFEFr (ORCPT ); Fri, 5 Feb 2021 23:05:47 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1612584304; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=+/uIP87vJEaaYUqbVLHKGTP87A5yWxtIFnA2Yl8Y65Y=; b=HcYDSYNMFfbJ2uhTyqT8qd+UPyBqem1/wb6hhxm70QEW7CiA2B9Fe6Djg9hHvM8ddORfws/2 ZPEvb+9CgCTAaQkD/0bWkDpQ2a7gO+JyadXKP1poy72CsRd+yB0QJnRdRZPFH2vrCH+1/T8G Ki+6o8gDzT/I+OAWN8CAr1+SbP8= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 601ddd2d3919dfb4555a5859 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 06 Feb 2021 00:05:01 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 475A3C433C6; Sat, 6 Feb 2021 00:05:01 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id EA5EEC433ED; Sat, 6 Feb 2021 00:04:59 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 05 Feb 2021 16:04:59 -0800 From: abhinavk@codeaurora.org To: Yang Li Cc: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, daniel@ffwll.ch, freedreno@lists.freedesktop.org Subject: Re: [Freedreno] [PATCH] drm/msm/dp: remove unneeded semicolon In-Reply-To: <1612321727-25156-1-git-send-email-yang.lee@linux.alibaba.com> References: <1612321727-25156-1-git-send-email-yang.lee@linux.alibaba.com> Message-ID: <4efdd6c16dacc1909c9253c355c3c810@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-02-02 19:08, Yang Li wrote: > Eliminate the following coccicheck warning: > ./drivers/gpu/drm/msm/dp/dp_ctrl.c:1161:2-3: Unneeded semicolon > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c > b/drivers/gpu/drm/msm/dp/dp_ctrl.c > index e3462f5..61ed67b 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c > @@ -1158,7 +1158,7 @@ static int dp_ctrl_link_rate_down_shift(struct > dp_ctrl_private *ctrl) > default: > ret = -EINVAL; > break; > - }; > + } > > if (!ret) > DRM_DEBUG_DP("new rate=0x%x\n", ctrl->link->link_params.rate); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A01C433E0 for ; Sat, 6 Feb 2021 00:05:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EE106500F for ; Sat, 6 Feb 2021 00:05:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EE106500F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B736F6F525; Sat, 6 Feb 2021 00:05:03 +0000 (UTC) Received: from so15.mailgun.net (so15.mailgun.net [198.61.254.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 576606F52A for ; Sat, 6 Feb 2021 00:05:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1612569902; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=+/uIP87vJEaaYUqbVLHKGTP87A5yWxtIFnA2Yl8Y65Y=; b=kM4CZe6SwjaiQ3FXMqpb32KP36afwBPACSFqD7pkR4jq9BiG5krUyJeeAdedPYR1goAgWkcd bqbmPBuOqfifYJzQgENzUd0RT5Ns8p4wu6M2ExxAOjiRe0i6mMK23Xcj9mId/iClH1bSzxFL 0A9iAYXGDbVOd05FmV5Qpk2B1Zs= X-Mailgun-Sending-Ip: 198.61.254.15 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 601ddd2d8e43a988b7a034cf (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 06 Feb 2021 00:05:01 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AB4A3C43467; Sat, 6 Feb 2021 00:05:00 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id EA5EEC433ED; Sat, 6 Feb 2021 00:04:59 +0000 (UTC) MIME-Version: 1.0 Date: Fri, 05 Feb 2021 16:04:59 -0800 From: abhinavk@codeaurora.org To: Yang Li Subject: Re: [Freedreno] [PATCH] drm/msm/dp: remove unneeded semicolon In-Reply-To: <1612321727-25156-1-git-send-email-yang.lee@linux.alibaba.com> References: <1612321727-25156-1-git-send-email-yang.lee@linux.alibaba.com> Message-ID: <4efdd6c16dacc1909c9253c355c3c810@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, airlied@linux.ie, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sean@poorly.run Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-02-02 19:08, Yang Li wrote: > Eliminate the following coccicheck warning: > ./drivers/gpu/drm/msm/dp/dp_ctrl.c:1161:2-3: Unneeded semicolon > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c > b/drivers/gpu/drm/msm/dp/dp_ctrl.c > index e3462f5..61ed67b 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c > @@ -1158,7 +1158,7 @@ static int dp_ctrl_link_rate_down_shift(struct > dp_ctrl_private *ctrl) > default: > ret = -EINVAL; > break; > - }; > + } > > if (!ret) > DRM_DEBUG_DP("new rate=0x%x\n", ctrl->link->link_params.rate); _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel