* [PATCH] xfs_scrub: make interpreter explicit to python3
@ 2018-02-24 2:15 Luis R. Rodriguez
2018-02-24 4:40 ` Darrick J. Wong
0 siblings, 1 reply; 5+ messages in thread
From: Luis R. Rodriguez @ 2018-02-24 2:15 UTC (permalink / raw)
To: sandeen; +Cc: darrick.wong, linux-xfs, Luis R. Rodriguez
Using #!/usr/bin/env makes some package dependency tools
such as rpm complain given that it cannot verify package
dependencies. Making it explicit resolves this lint rant.
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
scrub/xfs_scrub_all.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scrub/xfs_scrub_all.in b/scrub/xfs_scrub_all.in
index fff05da3ea7a..80f07d5c8b02 100644
--- a/scrub/xfs_scrub_all.in
+++ b/scrub/xfs_scrub_all.in
@@ -1,4 +1,4 @@
-#!/usr/bin/env python3
+#!/usr/bin/python3
# Run online scrubbers in parallel, but avoid thrashing.
#
--
2.16.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs_scrub: make interpreter explicit to python3
2018-02-24 2:15 [PATCH] xfs_scrub: make interpreter explicit to python3 Luis R. Rodriguez
@ 2018-02-24 4:40 ` Darrick J. Wong
2018-03-02 4:05 ` Eric Sandeen
0 siblings, 1 reply; 5+ messages in thread
From: Darrick J. Wong @ 2018-02-24 4:40 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: sandeen, linux-xfs
On Fri, Feb 23, 2018 at 06:15:12PM -0800, Luis R. Rodriguez wrote:
> Using #!/usr/bin/env makes some package dependency tools
> such as rpm complain given that it cannot verify package
> dependencies. Making it explicit resolves this lint rant.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> scrub/xfs_scrub_all.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scrub/xfs_scrub_all.in b/scrub/xfs_scrub_all.in
> index fff05da3ea7a..80f07d5c8b02 100644
> --- a/scrub/xfs_scrub_all.in
> +++ b/scrub/xfs_scrub_all.in
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python3
> +#!/usr/bin/python3
>
> # Run online scrubbers in parallel, but avoid thrashing.
> #
> --
> 2.16.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs_scrub: make interpreter explicit to python3
2018-02-24 4:40 ` Darrick J. Wong
@ 2018-03-02 4:05 ` Eric Sandeen
2018-03-02 9:08 ` Carlos Maiolino
0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2018-03-02 4:05 UTC (permalink / raw)
To: Darrick J. Wong, Luis R. Rodriguez; +Cc: linux-xfs
On 2/23/18 10:40 PM, Darrick J. Wong wrote:
> On Fri, Feb 23, 2018 at 06:15:12PM -0800, Luis R. Rodriguez wrote:
>> Using #!/usr/bin/env makes some package dependency tools
>> such as rpm complain given that it cannot verify package
>> dependencies. Making it explicit resolves this lint rant.
>>
>> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
>
> Looks ok,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
intereting, my rpmbuild actually converts this on the fly. ;)
But fine by me to hardcode it if Darrick says ok. :)
Thanks,
-Eric
> --D
>
>> ---
>> scrub/xfs_scrub_all.in | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scrub/xfs_scrub_all.in b/scrub/xfs_scrub_all.in
>> index fff05da3ea7a..80f07d5c8b02 100644
>> --- a/scrub/xfs_scrub_all.in
>> +++ b/scrub/xfs_scrub_all.in
>> @@ -1,4 +1,4 @@
>> -#!/usr/bin/env python3
>> +#!/usr/bin/python3
>>
>> # Run online scrubbers in parallel, but avoid thrashing.
>> #
>> --
>> 2.16.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs_scrub: make interpreter explicit to python3
2018-03-02 4:05 ` Eric Sandeen
@ 2018-03-02 9:08 ` Carlos Maiolino
2018-03-02 16:24 ` Darrick J. Wong
0 siblings, 1 reply; 5+ messages in thread
From: Carlos Maiolino @ 2018-03-02 9:08 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Darrick J. Wong, Luis R. Rodriguez, linux-xfs
On Thu, Mar 01, 2018 at 10:05:09PM -0600, Eric Sandeen wrote:
>
>
> On 2/23/18 10:40 PM, Darrick J. Wong wrote:
> > On Fri, Feb 23, 2018 at 06:15:12PM -0800, Luis R. Rodriguez wrote:
> >> Using #!/usr/bin/env makes some package dependency tools
> >> such as rpm complain given that it cannot verify package
> >> dependencies. Making it explicit resolves this lint rant.
> >>
> >> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> >
> > Looks ok,
> > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> intereting, my rpmbuild actually converts this on the fly. ;)
> But fine by me to hardcode it if Darrick says ok. :)
>
Just a question though about this.
What if somebody/somedistro installs python3 on another $PATH?
It's been a while since I don't do any packaging stuff, so, I just wonder if
this couldn't cause issues on distros using different install paths?
Cheers.
> Thanks,
> -Eric
>
> > --D
> >
> >> ---
> >> scrub/xfs_scrub_all.in | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/scrub/xfs_scrub_all.in b/scrub/xfs_scrub_all.in
> >> index fff05da3ea7a..80f07d5c8b02 100644
> >> --- a/scrub/xfs_scrub_all.in
> >> +++ b/scrub/xfs_scrub_all.in
> >> @@ -1,4 +1,4 @@
> >> -#!/usr/bin/env python3
> >> +#!/usr/bin/python3
> >>
> >> # Run online scrubbers in parallel, but avoid thrashing.
> >> #
> >> --
> >> 2.16.2
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Carlos
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs_scrub: make interpreter explicit to python3
2018-03-02 9:08 ` Carlos Maiolino
@ 2018-03-02 16:24 ` Darrick J. Wong
0 siblings, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2018-03-02 16:24 UTC (permalink / raw)
To: Eric Sandeen, Luis R. Rodriguez, linux-xfs
On Fri, Mar 02, 2018 at 10:08:42AM +0100, Carlos Maiolino wrote:
> On Thu, Mar 01, 2018 at 10:05:09PM -0600, Eric Sandeen wrote:
> >
> >
> > On 2/23/18 10:40 PM, Darrick J. Wong wrote:
> > > On Fri, Feb 23, 2018 at 06:15:12PM -0800, Luis R. Rodriguez wrote:
> > >> Using #!/usr/bin/env makes some package dependency tools
> > >> such as rpm complain given that it cannot verify package
> > >> dependencies. Making it explicit resolves this lint rant.
> > >>
> > >> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> > >
> > > Looks ok,
> > > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > intereting, my rpmbuild actually converts this on the fly. ;)
> > But fine by me to hardcode it if Darrick says ok. :)
> >
>
> Just a question though about this.
>
> What if somebody/somedistro installs python3 on another $PATH?
>
> It's been a while since I don't do any packaging stuff, so, I just wonder if
> this couldn't cause issues on distros using different install paths?
They can always patch in the path to their python3 executable.
Though, given the number of /usr/bin/python3 scripts floating around in
Google, I'm guessing a distro would have to have a really good reason to
put it elsewhere.
--D
> Cheers.
>
> > Thanks,
> > -Eric
> >
> > > --D
> > >
> > >> ---
> > >> scrub/xfs_scrub_all.in | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/scrub/xfs_scrub_all.in b/scrub/xfs_scrub_all.in
> > >> index fff05da3ea7a..80f07d5c8b02 100644
> > >> --- a/scrub/xfs_scrub_all.in
> > >> +++ b/scrub/xfs_scrub_all.in
> > >> @@ -1,4 +1,4 @@
> > >> -#!/usr/bin/env python3
> > >> +#!/usr/bin/python3
> > >>
> > >> # Run online scrubbers in parallel, but avoid thrashing.
> > >> #
> > >> --
> > >> 2.16.2
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> Carlos
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-02 16:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-24 2:15 [PATCH] xfs_scrub: make interpreter explicit to python3 Luis R. Rodriguez
2018-02-24 4:40 ` Darrick J. Wong
2018-03-02 4:05 ` Eric Sandeen
2018-03-02 9:08 ` Carlos Maiolino
2018-03-02 16:24 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.