From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Wu Date: Tue, 12 May 2020 09:56:51 +0800 Subject: [PATCH 6/8] net: dwc_eth_qos: Split eqos_start() to get link speed In-Reply-To: <5c12f86c-a69a-e1a6-9c99-b723c51dc40f@st.com> References: <20200430103656.29728-1-david.wu@rock-chips.com> <20200430104423.31014-1-david.wu@rock-chips.com> <5fa0a9ce-74b1-cbbd-55b7-08a74f31376a@rock-chips.com> <5c12f86c-a69a-e1a6-9c99-b723c51dc40f@st.com> Message-ID: <4f1c20ff-1142-3d70-c3b7-49cdc38c9e3f@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Patrice, ? 2020/5/11 ??8:48, Patrice CHOTARD ??: > Hi David > > On 5/9/20 8:42 AM, David Wu wrote: >> Hi Patrice, >> >> ? 2020/4/30 ??11:33, Patrice CHOTARD ??: >>> Can you explain why you are splitting this function in 2 parts and calling these parts sequentially ? >> >> For rockchip, need to obtain the current link speed to configure the tx clocks, (for example, in rgmii mode, 1000M link: 125M, 100M link: 25M, 10M link is 2.5M rate) and then enable gmac. So after the adjust_link(), before the start gamc, this intermediate stage needs to configure the clock according to the current link speed. >> >> > Please, add these informations in the commit message I will add it at the next version, Thanks. > > Thanks > > Patrice >