All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Price <steven.price@arm.com>
To: Rob Herring <robh@kernel.org>, dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH] drm/panfrost: Add support for 2MB page entries
Date: Fri, 12 Apr 2019 11:40:52 +0100	[thread overview]
Message-ID: <4f2f944c-44eb-768c-804e-13f4e08cba9e@arm.com> (raw)
In-Reply-To: <20190411215313.1937-1-robh@kernel.org>

On 11/04/2019 22:53, Rob Herring wrote:
> Add support for 2MB sized pages. This will improve our map and unmap
> times and save a bit of memory by avoiding 3rd level page tables for
> contiguous allocations.
> 
> As we use shmem for buffers and huge page allocations for shmem are off
> by default, there isn't an improvement out of the box and userspace must
> enable THP for shmem.
> 
> It's not clear if the h/w can support 1GB page sizes which standard
> ARM long format descriptors support. In any case, it is unlikely we'll
> see any contiguous 1GB allocations on current h/w.
> 
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Rob Herring <robh@kernel.org>

LGTM, and I see a nice speed up too!

Reviewed-by: Steven Price <steven.price@arm.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2019-04-12 10:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 21:53 [PATCH] drm/panfrost: Add support for 2MB page entries Rob Herring
2019-04-11 21:54 ` Alyssa Rosenzweig
2019-04-12 14:52   ` Tomeu Vizoso
2019-04-12 10:40 ` Steven Price [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f2f944c-44eb-768c-804e-13f4e08cba9e@arm.com \
    --to=steven.price@arm.com \
    --cc=airlied@linux.ie \
    --cc=alyssa@rosenzweig.io \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robh@kernel.org \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.