From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>, Jeremy Allison <jra@samba.org>
Cc: Jeremy Allison <jallison@ciq.com>,
tansuresh@google.com, linux-nvme@lists.infradead.org,
gregkh@linuxfoundation.org, rafael@kernel.org,
bhelgaas@google.com
Subject: Re: [PATCH 1/3] driver core: Support asynchronous driver shutdown
Date: Tue, 19 Dec 2023 15:49:18 +0200 [thread overview]
Message-ID: <4f3084d3-10ce-49b9-8219-70dbf504cd6a@grimberg.me> (raw)
In-Reply-To: <20231219062102.GA1702@lst.de>
On 12/19/23 08:21, Christoph Hellwig wrote:
> On Mon, Dec 18, 2023 at 10:19:43PM -0800, Jeremy Allison wrote:
>>> Is there any reason to have a separate shutdown_pre method?
>>> Especially with all the method wrapping in the driver core, yet
>>> another method just keeps confusing everyone.
>>
>> Currently in the patch the existence of a shutdown_pre() method
>> for a device causes it to be added to the async_shutdown_list
>> which is walked to reap the completion status after all the
>> calls to shutdown_pre().
>>
>> I could change this so that the existing shutdown() method
>> is always called, and the device is only added to the async_shutdown_list
>> if a shutdown_post() (or as requested below, shutdown_wait())
>> method is defined for the device.
>
> Yes, that's what I mean.
I think its usually better to separate sync vs async interfaces. However
I assume that the suggested interface exists elsewhere in the kernel, so
its not a big deal.
next prev parent reply other threads:[~2023-12-19 13:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 0:03 Make NVME shutdown async - version 2 Jeremy Allison
2023-12-15 0:03 ` [PATCH 1/3] driver core: Support asynchronous driver shutdown Jeremy Allison
2023-12-15 12:21 ` Greg KH
2023-12-19 5:33 ` Christoph Hellwig
2023-12-19 6:19 ` Jeremy Allison
2023-12-19 6:21 ` Christoph Hellwig
2023-12-19 13:49 ` Sagi Grimberg [this message]
2023-12-19 13:56 ` Christoph Hellwig
2023-12-19 14:12 ` Sagi Grimberg
2023-12-15 0:03 ` [PATCH 2/3] PCI: Support asynchronous shutdown Jeremy Allison
2023-12-15 0:03 ` [PATCH 3/3] nvme: Add async shutdown support Jeremy Allison
2023-12-19 5:43 ` Christoph Hellwig
2023-12-19 6:35 ` Jeremy Allison
-- strict thread matches above, loose matches on Subject: below --
2023-12-12 18:09 Make NVME shutdown async Jeremy Allison
2023-12-12 18:09 ` [PATCH 1/3] driver core: Support asynchronous driver shutdown Jeremy Allison
2023-12-13 13:59 ` Sagi Grimberg
2023-12-13 17:34 ` Jeremy Allison
2023-12-13 17:48 ` Bart Van Assche
2022-03-24 21:34 Tanjore Suresh
2022-03-25 5:59 ` Greg Kroah-Hartman
2022-03-25 13:24 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f3084d3-10ce-49b9-8219-70dbf504cd6a@grimberg.me \
--to=sagi@grimberg.me \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jallison@ciq.com \
--cc=jra@samba.org \
--cc=linux-nvme@lists.infradead.org \
--cc=rafael@kernel.org \
--cc=tansuresh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.