From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 508B5C43613 for ; Mon, 24 Jun 2019 12:22:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29CE02089F for ; Mon, 24 Jun 2019 12:22:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29CE02089F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50686 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfNzP-0002Ea-Bs for qemu-devel@archiver.kernel.org; Mon, 24 Jun 2019 08:22:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47770) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfNxX-0001D7-IH for qemu-devel@nongnu.org; Mon, 24 Jun 2019 08:20:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfNxW-0005uP-82 for qemu-devel@nongnu.org; Mon, 24 Jun 2019 08:20:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52182) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfNxQ-0005f3-Ju; Mon, 24 Jun 2019 08:20:25 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ACAA2C18B2E8; Mon, 24 Jun 2019 12:20:16 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-204-152.brq.redhat.com [10.40.204.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52A2B5C22E; Mon, 24 Jun 2019 12:20:15 +0000 (UTC) To: Peter Maydell References: <20190621132324.2165-1-mreitz@redhat.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <4f34c316-2d5a-4d0c-ab3b-2c85b1a9e22f@redhat.com> Date: Mon, 24 Jun 2019 14:20:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oQrFMtA0NZH5qrUOz2Ibe5by4PxofVsap" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 24 Jun 2019 12:20:16 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PULL 0/8] Block patches X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , QEMU Developers , Qemu-block , Pino Toscano Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oQrFMtA0NZH5qrUOz2Ibe5by4PxofVsap Content-Type: multipart/mixed; boundary="7UqeWTI7FawTAoZELFLTn6Tv8dv0mEJYp"; protected-headers="v1" From: Max Reitz To: Peter Maydell Cc: Qemu-block , QEMU Developers , Kevin Wolf , Pino Toscano Message-ID: <4f34c316-2d5a-4d0c-ab3b-2c85b1a9e22f@redhat.com> Subject: Re: [PULL 0/8] Block patches References: <20190621132324.2165-1-mreitz@redhat.com> In-Reply-To: --7UqeWTI7FawTAoZELFLTn6Tv8dv0mEJYp Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 23.06.19 19:18, Peter Maydell wrote: > On Fri, 21 Jun 2019 at 14:23, Max Reitz wrote: >> >> The following changes since commit 33d609990621dea6c7d056c86f707b88113= 20ac1: >> >> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into = staging (2019-06-18 17:00:52 +0100) >> >> are available in the Git repository at: >> >> https://github.com/XanClic/qemu.git tags/pull-block-2019-06-21 >> >> for you to fetch changes up to e2a76186f7948b8b75d1b2b52638de7c2f7f747= 2: >> >> iotests: Fix 205 for concurrent runs (2019-06-21 14:40:28 +0200) >> >> ---------------------------------------------------------------- >> Block patches: >> - The SSH block driver now uses libssh instead of libssh2 >> - The VMDK block driver gets read-only support for the seSparse >> subformat >> - Various fixes >> >=20 > Hi; this failed to build on my s390 box: >=20 > /home/linux1/qemu/block/ssh.c: In function =E2=80=98check_host_key_know= nhosts=E2=80=99: > /home/linux1/qemu/block/ssh.c:367:27: error: implicit declaration of > function =E2=80=98ssh_get_fingerprint_hash=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > fingerprint =3D ssh_get_fingerprint_hash(SSH_PUBLICKEY_HAS= H_SHA1, > ^ > /home/linux1/qemu/block/ssh.c:367:13: error: nested extern declaration > of =E2=80=98ssh_get_fingerprint_hash=E2=80=99 [-Werror=3Dnested-externs= ] > fingerprint =3D ssh_get_fingerprint_hash(SSH_PUBLICKEY_HAS= H_SHA1, > ^ > /home/linux1/qemu/block/ssh.c:367:25: error: assignment makes pointer > from integer without a cast [-Werror=3Dint-conversion] > fingerprint =3D ssh_get_fingerprint_hash(SSH_PUBLICKEY_HAS= H_SHA1, > ^ >=20 > It looks like that function was introduced in libssh 0.8.3, and this bo= x > has 0.6.3. (configure has correctly not defined HAVE_LIBSSH_0_8 > but this usage is inside a bit of code that's compiled even when > that is not defined.) Pino, would you be OK with dropping that piece of code for pre-0.8 and just replacing it with the else-error_setg()? Max --7UqeWTI7FawTAoZELFLTn6Tv8dv0mEJYp-- --oQrFMtA0NZH5qrUOz2Ibe5by4PxofVsap Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl0Qv/sACgkQ9AfbAGHV z0A7+wf+PgL1LchKcPOi/G0Ummg0g/F2zNrLeD9xb7tpa5w1nJjRxBu9dJNW656A uv8qPlh4T8oGPT/9g0Eshk594zIu2vABr+yD5akzFwSevVl2TdjlqHKxeh/DHG+2 z+aDyXSpKpc6HWVWAha/64gyLTKtUsEuuSs1hTpTOWDtZPJqeXE9wv/S11mTyJSt H7q1a+JUMLgFKF+4SCWVAEApcBZtD9dnqY3Pcpa8gIcV23fweLHla1cDyTzkYDYN dA0POjU4nPoOcuAUyw5aNqgDdEHEIUNkL8KbCmUOCVKA8c49x/VsxsxNBXslUSBt 11dj6K9bp4xs4sApgPAGI0u4aVdk2Q== =d6Ky -----END PGP SIGNATURE----- --oQrFMtA0NZH5qrUOz2Ibe5by4PxofVsap--