From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72785C433ED for ; Wed, 5 May 2021 11:37:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F21D610C8 for ; Wed, 5 May 2021 11:37:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233096AbhEELiO (ORCPT ); Wed, 5 May 2021 07:38:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:50538 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232917AbhEELiN (ORCPT ); Wed, 5 May 2021 07:38:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620214636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C5Lah4Bb8DHKwVhTcxaDUF/2d0Qp2D0Gt9JdNQHVqpM=; b=FSIy6NC3MVwTWLIcm6igyLXXY+7p3hvqPxTCuyVZahralKMEQjCpVT13cBn7pHndKzvYVZ khcDddNu48ZwkybvCjwoJ8vYns+pCxCQyyjlJMuFRDdhabz6UKuE8Rr/eMbNA8pZlGH7mC TEJ9hxkO0hx+94XfgoQ8h8ctofoWD5c= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-350-zSzpoIZHOsWIjKJCmmA8Rg-1; Wed, 05 May 2021 07:37:15 -0400 X-MC-Unique: zSzpoIZHOsWIjKJCmmA8Rg-1 Received: by mail-ed1-f71.google.com with SMTP id c15-20020a056402100fb029038518e5afc5so697621edu.18 for ; Wed, 05 May 2021 04:37:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C5Lah4Bb8DHKwVhTcxaDUF/2d0Qp2D0Gt9JdNQHVqpM=; b=Z9v59crdH3M911z8Tud8AZF9LMLEB+gFAOabow34Ib0XLfJhwn06YpF6+oFF+9jFXu wWLBFJm1k+X2FKhTE8Dza5vMFQOoHpTWNLa/N5bROo0ZT2NnZ6Yd4cO5WY3QyEmuY1J9 a4GB19ca0UO8CtnQ3AivI+TA1ceKcsmOKI7LU6QkCB6iDRr1ksRLoqiE3COzBRI4Klm4 GJ+8B9MIuKOhFv1UKoCJ6JJirWf7rr0FceLNOkmqgin8GXzZdh1GIEXGPqN0Q0QAT84m NLefoQ/Vh2vZkYjzViJOKgr8IX4pIE42eIDt8mqxKaierwmbyIdXp3dE/HbB2bEr3sP8 2EHg== X-Gm-Message-State: AOAM533nlbMaCjT3aqc/R5CkJfMWWG6BX/R1Z+XDvUuWRKzn9QKreeOg 4rrzwxZjgafAw1d7+q6ZQWO5+7665W5IpMeaYKCiaTz9drQLpFadGlZ/CDr2I4aLCmmjaxUj03j PFK0ggOO6caU/3AWtayEwMHQ5 X-Received: by 2002:a17:906:ce5a:: with SMTP id se26mr27558898ejb.332.1620214634249; Wed, 05 May 2021 04:37:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvqQBG09+x9kPbhc/155unYddBlPP6BJb1muXWMIK8OXYKn1M29PWBNb8X2eVyIfruqOJ9YQ== X-Received: by 2002:a17:906:ce5a:: with SMTP id se26mr27558870ejb.332.1620214634029; Wed, 05 May 2021 04:37:14 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id u25sm2780048ejb.12.2021.05.05.04.37.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 May 2021 04:37:13 -0700 (PDT) Subject: Re: [PATCH 4/6] kvm: Select SCHED_INFO instead of TASK_DELAY_ACCT To: Peter Zijlstra , tglx@linutronix.de, mingo@kernel.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, bsingharora@gmail.com, maz@kernel.org Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, riel@surriel.com, hannes@cmpxchg.org References: <20210505105940.190490250@infradead.org> <20210505111525.187225172@infradead.org> From: Paolo Bonzini Message-ID: <4f35124c-1127-2629-2e00-800bc965e9f1@redhat.com> Date: Wed, 5 May 2021 13:37:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210505111525.187225172@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/21 12:59, Peter Zijlstra wrote: > AFAICT KVM only relies on SCHED_INFO. Nothing uses the p->delays data > that belongs to TASK_DELAY_ACCT. > > Signed-off-by: Peter Zijlstra (Intel) Right, SCHED_INFO didn't exist at the time (it was introduced in 2015, while KVM started using run_delay in 2011). I'm not sure if it could have used SCHEDSTATS instead. Acked-by: Paolo Bonzini Paolo > --- > arch/arm64/kvm/Kconfig | 5 +---- > arch/x86/kvm/Kconfig | 5 +---- > 2 files changed, 2 insertions(+), 8 deletions(-) > > --- a/arch/arm64/kvm/Kconfig > +++ b/arch/arm64/kvm/Kconfig > @@ -20,8 +20,6 @@ if VIRTUALIZATION > menuconfig KVM > bool "Kernel-based Virtual Machine (KVM) support" > depends on OF > - # for TASKSTATS/TASK_DELAY_ACCT: > - depends on NET && MULTIUSER > select MMU_NOTIFIER > select PREEMPT_NOTIFIERS > select HAVE_KVM_CPU_RELAX_INTERCEPT > @@ -38,8 +36,7 @@ menuconfig KVM > select IRQ_BYPASS_MANAGER > select HAVE_KVM_IRQ_BYPASS > select HAVE_KVM_VCPU_RUN_PID_CHANGE > - select TASKSTATS > - select TASK_DELAY_ACCT > + select SCHED_INFO > help > Support hosting virtualized guest machines. > > --- a/arch/x86/kvm/Kconfig > +++ b/arch/x86/kvm/Kconfig > @@ -22,8 +22,6 @@ config KVM > tristate "Kernel-based Virtual Machine (KVM) support" > depends on HAVE_KVM > depends on HIGH_RES_TIMERS > - # for TASKSTATS/TASK_DELAY_ACCT: > - depends on NET && MULTIUSER > depends on X86_LOCAL_APIC > select PREEMPT_NOTIFIERS > select MMU_NOTIFIER > @@ -36,8 +34,7 @@ config KVM > select KVM_ASYNC_PF > select USER_RETURN_NOTIFIER > select KVM_MMIO > - select TASKSTATS > - select TASK_DELAY_ACCT > + select SCHED_INFO > select PERF_EVENTS > select HAVE_KVM_MSI > select HAVE_KVM_CPU_RELAX_INTERCEPT > >