From: Jens Axboe <axboe@kernel.dk>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, linux-block@vger.kernel.org,
hch@lst.de
Subject: Re: [PATCH 2/2] xfs: add 'discard_sync' mount flag
Date: Wed, 2 May 2018 08:20:00 -0600 [thread overview]
Message-ID: <4f3b8286-7ef3-c8c4-01f2-47508ee5ab16@kernel.dk> (raw)
In-Reply-To: <yq1wowm7oo8.fsf@oracle.com>
On 5/1/18 8:54 PM, Martin K. Petersen wrote:
>
> Jens,
>
>> diff --git a/block/blk-wbt.h b/block/blk-wbt.h
>> index a232c98fbf4d..aec5bc82d580 100644
>> --- a/block/blk-wbt.h
>> +++ b/block/blk-wbt.h
>> @@ -14,12 +14,17 @@ enum wbt_flags {
>> WBT_TRACKED = 1, /* write, tracked for throttling */
>> WBT_READ = 2, /* read */
>> WBT_KSWAPD = 4, /* write, from kswapd */
>> + WBT_TRIM = 8,
>
> The term TRIM does not apply to NVMe, nor SCSI. Please call it
> WBT_DISCARD.
Sure, I can do that.
--
Jens Axboe
next prev parent reply other threads:[~2018-05-02 14:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 15:32 [PATCHSET 0/2] sync discard Jens Axboe
2018-04-30 15:32 ` [PATCH 1/2] block: add BLKDEV_DISCARD_SYNC flag Jens Axboe
2018-04-30 15:32 ` [PATCH 2/2] xfs: add 'discard_sync' mount flag Jens Axboe
2018-04-30 17:19 ` Brian Foster
2018-04-30 18:07 ` Jens Axboe
2018-04-30 18:25 ` Luis R. Rodriguez
2018-04-30 18:31 ` Jens Axboe
2018-04-30 19:19 ` Eric Sandeen
2018-04-30 19:21 ` Jens Axboe
2018-04-30 19:57 ` Eric Sandeen
2018-04-30 19:58 ` Jens Axboe
2018-04-30 22:59 ` Eric Sandeen
2018-04-30 23:02 ` Jens Axboe
2018-04-30 19:18 ` Brian Foster
2018-04-30 21:31 ` Dave Chinner
2018-04-30 21:42 ` Jens Axboe
2018-04-30 22:28 ` Dave Chinner
2018-04-30 22:40 ` Jens Axboe
2018-04-30 23:00 ` Jens Axboe
2018-04-30 23:23 ` Dave Chinner
2018-05-01 11:11 ` Brian Foster
2018-05-01 15:23 ` Jens Axboe
2018-05-02 2:54 ` Martin K. Petersen
2018-05-02 14:20 ` Jens Axboe [this message]
2018-04-30 23:01 ` Darrick J. Wong
2018-05-02 12:45 ` [PATCHSET 0/2] sync discard Christoph Hellwig
2018-05-02 14:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f3b8286-7ef3-c8c4-01f2-47508ee5ab16@kernel.dk \
--to=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.