All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ruehl <chris.ruehl@gtsys.com.hk>
To: Oliver Neukum <oneukum@suse.com>,
	"michael.lee@omron.com" <michael.lee@omron.com>,
	Lars Melin <larsm17@gmail.com>,
	USB list <linux-usb@vger.kernel.org>
Subject: Re: serial: usb: cdc-acm: OMRON B5L ToF, device probe failed
Date: Thu, 23 Jun 2022 16:55:14 +0800	[thread overview]
Message-ID: <4f4977bf-6096-592c-9c06-44aacb82ccd7@gtsys.com.hk> (raw)
In-Reply-To: <3194ea30-34da-3d34-6d4a-08dc7c8d683a@gtsys.com.hk>



On 23/6/2022 4:44 pm, Chris Ruehl wrote:
>
> On 23/6/2022 4:28 pm, Oliver Neukum wrote:
>>
>> On 23.06.22 04:26, Chris Ruehl wrote:
>>
>> Hi,
>>
>>> thanks for that patch, I can confirm it works for me. I have the ToF up
>>> and running at B921600 8N1.
>>> But I would wait, not apply to the kernel, because I noticed that the
>>> team from OMRON is working
>>> on the CDC implantation.
>>> So this patch is only a workaround for the moment.
>>>
>> if you absolutely want it to be driven from CDC-ACM, try this
>> new attached patch.
>> In your original patch you used NO_UNION_NORMAL. That will allow
>> a device to work without a union descriptor but with the normal
>> two interfaces. This devices has what in terms of ACM is a collapsed
>> interface without a union descriptor.
>> The driver provides for that but then it checks for the exact
>> number of required endpoints, which is three. Your device has
>> four endpoints.
>> The patch ignores a fourth endpoint.
>>
>>     Regards
>>         Oliver
>
> Oliver,
>
> I give this patch a try and report how it works.
>
> Thanks
> Chris
>
Apply the patch ,
still no /dev/ttyACM0 comes up.

Thanks for your effort.
Chris

  reply	other threads:[~2022-06-23  8:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17  4:11 serial: usb: cdc-acm: OMRON B5L ToF, device probe failed Chris Ruehl
2022-06-20  2:44 ` Chris Ruehl
2022-06-20  3:35   ` Lars Melin
2022-06-20  6:20     ` Chris Ruehl
2022-06-21  0:38       ` michael.lee
2022-06-21  7:16         ` Greg KH
2022-06-21 10:09         ` Oliver Neukum
2022-06-21 10:44           ` Chris Ruehl
2022-06-23  2:26           ` Chris Ruehl
2022-06-23  8:28             ` Oliver Neukum
2022-06-23  8:44               ` Chris Ruehl
2022-06-23  8:55                 ` Chris Ruehl [this message]
2022-06-23  9:39                   ` Oliver Neukum
2022-06-25  2:35                     ` Chris Ruehl
2022-06-25  2:42                       ` Chris Ruehl
2022-06-25  7:32                       ` Greg KH
2022-06-25  7:46                         ` Chris Ruehl
2022-07-20 11:12                   ` Oliver Neukum
2022-07-20 16:24     ` Oliver Neukum
  -- strict thread matches above, loose matches on Subject: below --
2022-06-15  7:25 Chris Ruehl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f4977bf-6096-592c-9c06-44aacb82ccd7@gtsys.com.hk \
    --to=chris.ruehl@gtsys.com.hk \
    --cc=larsm17@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael.lee@omron.com \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.