From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94FB7C4338F for ; Sun, 1 Aug 2021 11:02:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A0D9610A2 for ; Sun, 1 Aug 2021 11:02:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5A0D9610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3202E188B; Sun, 1 Aug 2021 13:02:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3202E188B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627815770; bh=2g1bEYAPvqG5SBDvEs7lQnvBOY44SYgyLYHPh65EwaA=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vmzrXkoLzEp+HxqqWkXAiihEDUeiiCMMdIPv1/Ah7cVNP1rjM+Cno3fSBo9jjMPtV +yROEuhhHCAhAjWFqARuK7W0G2C3roDkyj2hKAePMnSAR1nS2BTzdpuPE5jOwQ8aW8 1nZzISnaQ1pUmMQAZjYqcybH9Z6ttTpy0tK5UbP4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C2AD6F8016D; Sun, 1 Aug 2021 13:01:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2B4C0F802E8; Sun, 1 Aug 2021 13:01:58 +0200 (CEST) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D765EF80095 for ; Sun, 1 Aug 2021 13:01:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D765EF80095 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hG+U541T" Received: by mail-ej1-x62f.google.com with SMTP id e19so25984031ejs.9 for ; Sun, 01 Aug 2021 04:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HaY7BE+zIs6Wp8fTD42qxnu2bftdWvir9jeFi82TTuQ=; b=hG+U541TM1JehfC+7jl2/UEmUyNPWQXqPYF6jMc9h73LFe3i2fvXRaynIf30cinq6R dhg5+WDSfJPDLxQuVkaW1zPMQ7pmyeAegCMB3xVmM5RuCAdAiX5HOFyHg4B99CnAuJX5 lnT8FGXmcwU5QHJLudDM+W/gbI1lXSxWa05z1daWBkPFXjMDyEl/GhhXCRBRNAmXGo5J Ymbp+2GwLTsRI6FC9FmtLYNZBpsChSvlaxysFc9YnVullIdnnXiVT8JJwT2c2WPa2JcY bPlvwZbBpknMFtEYbSfVAIQWizJIXgnGRDJMLtRoDMGlJzokdzHvVClayqhF4rxJ+E25 VVng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HaY7BE+zIs6Wp8fTD42qxnu2bftdWvir9jeFi82TTuQ=; b=gDCsalx4OWLmdlONXs6WSuU4DtMkp8dedhqvDy0yMt6osbEPi0xLHs7jHsugv0nPsA OIuPHtuehE1hcJFatWdAyrfE7S9D2ZryR5Du+iIdBMBmpfgT+ztmZKJosBfbtVflatg4 qR5sv6WrB6QEBffMgeH8eoB7jTJTJfvs2xLVHW1bHl0qCaiPOpvvnPmfn32TWR0mJPjn AEkRZqN5ugLjWdgieGSshEB4bhcIw+VQU6EnNf4Hj3Ayvp/iG/5S4bL2UaeJmWanAUPh uqvsaal8vJ+uXQDRkTQ9HSPlZX4mMMsAo2E1vPjFF67W2b2umLgb3kl1EmM6avdtLRcO gZ7g== X-Gm-Message-State: AOAM531emAsfCoistQwCGUB5Gq0oFp0TtziEcb1qigzsNDOZ6E84ne9U EwOWkxK7GLGCm7pxKxO08zI= X-Google-Smtp-Source: ABdhPJy6myK64KrUPEeWKREeOSKw7KTsXIXdxmtGo+wlZzKvxYnkdpUJfmYyhgQkWm3+Va09fRgySA== X-Received: by 2002:a17:906:8a98:: with SMTP id mu24mr10889294ejc.404.1627815709018; Sun, 01 Aug 2021 04:01:49 -0700 (PDT) Received: from ?IPv6:2a02:587:9423:c0a8:d967:ca01:966a:f420? ([2a02:587:9423:c0a8:d967:ca01:966a:f420]) by smtp.gmail.com with ESMTPSA id w6sm3904214edd.22.2021.08.01.04.01.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Aug 2021 04:01:48 -0700 (PDT) Subject: Re: [PATCH] ALSA: hda/realtek: add mic quirk for Acer SF314-42 To: Takashi Iwai References: <20210721170141.24807-1-amonakov@ispras.ru> From: Nikos Liolios Message-ID: <4f7a01cb-a452-68cb-3238-3bfe6b8ea390@gmail.com> Date: Sun, 1 Aug 2021 14:01:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Alexander Monakov , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 01 Aug 2021 10:39:13 +0300, Takashi Iwai wrote: > On Sun, 01 Aug 2021 09:00:48 +0200, > Alexander Monakov wrote: >> >> On Sun, 1 Aug 2021, Nikos Liolios wrote: >> >>> Other quirks for Acer Swift (for Acer SWIFT SF314-54/55/56) they describe the >>> model using capital letters ("SWIFT" instead of "Swift"). I do think that >>> "Swift" is better than (caps locked) "SWIFT". Thinking to create a patch for >>> it since I helped to create this mess. From my understanding it only affects >>> the dmesg of which quirk was used, nothing important, but lets keep code >>> clean. >>> >>> What do you think? Rename "SWIFT"s to "Swift"s? >>> If no disagreement or no reply I am doing it like tomorrow. >> >> I agree "Swift" would be better: as far as I can tell, Acer mostly uses "Swift" >> (both in marketing materials and DMI information). I would support the rename. > > That's a really bikeshed topic, and I don't think we need an extra > patch to correct it. The message is only for debug prints, usually > you don't see it. > > > thanks, > > Takashi > I will respect your/Takashi's opinion. Won't do any such patch. Thank you for letting me know beforehand.