From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion notification Date: Wed, 14 Feb 2018 13:39:35 -0800 Message-ID: <4f85d732-f060-9510-6fdb-1458aa4cf435@oracle.com> References: <331448b2-65d1-0f62-033c-b97d87a57b87@oracle.com> <20180214190110.GM11528@oracle.com> <20180214.140256.2107383260203156183.davem@davemloft.net> <20180214212524.GR11528@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, willemdebruijn.kernel@gmail.com, rds-devel@oss.oracle.com To: Sowmini Varadhan Return-path: Received: from userp2120.oracle.com ([156.151.31.85]:43436 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031404AbeBNVjn (ORCPT ); Wed, 14 Feb 2018 16:39:43 -0500 In-Reply-To: <20180214212524.GR11528@oracle.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2/14/2018 1:25 PM, Sowmini Varadhan wrote: > On (02/14/18 13:10), Santosh Shilimkar wrote: >>>>> RDS support true zero copy already with RDMA transport so some of >>>>> this code can easily get confused. > > btw, another way to solve this is to have the RDMA code use the > suffix "rdma" (which is what it really is) as needed. > And same breath,here zcopy is No message from user ;-) ZCOPY is otherwise often tied with RDMA directly. Renaming churns are not that useful and I definitely agree with what Dave said if it was renaming change to the existing code like what you are suggesting with 'rdma' Anyways I don't want to contest this too much since I can follow that code and know what each does and means :-) The comment was long term readability perspective for some one completely new reading the code and being able to distinguish the different modes. Regards, Santosh