From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED3D9C636C8 for ; Tue, 20 Jul 2021 21:20:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4DFB60FD7 for ; Tue, 20 Jul 2021 21:20:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234908AbhGTUiz (ORCPT ); Tue, 20 Jul 2021 16:38:55 -0400 Received: from mga09.intel.com ([134.134.136.24]:42193 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236662AbhGTUfd (ORCPT ); Tue, 20 Jul 2021 16:35:33 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10051"; a="211328752" X-IronPort-AV: E=Sophos;i="5.84,256,1620716400"; d="scan'208";a="211328752" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2021 14:16:09 -0700 X-IronPort-AV: E=Sophos;i="5.84,256,1620716400"; d="scan'208";a="632441016" Received: from akleen-mobl1.amr.corp.intel.com (HELO [10.212.245.156]) ([10.212.245.156]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2021 14:16:08 -0700 Subject: Re: [PATCH v3 5/6] platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver To: Dave Hansen , "Kuppuswamy, Sathyanarayanan" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , Hans de Goede , Mark Gross , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: Peter H Anvin , Tony Luck , Dan Williams , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , x86@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org References: <20210720045552.2124688-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210720045552.2124688-6-sathyanarayanan.kuppuswamy@linux.intel.com> <4c43dfe4-e44b-9d6d-b012-63790bb47b19@linux.intel.com> <52caa0e2-d3da-eef0-da5f-e83cc54c133c@intel.com> From: Andi Kleen Message-ID: <4f8dc9dd-0dbc-bff9-570b-0d20f673d3f0@linux.intel.com> Date: Tue, 20 Jul 2021 14:16:08 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <52caa0e2-d3da-eef0-da5f-e83cc54c133c@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/20/2021 10:59 AM, Dave Hansen wrote: > On 7/20/21 10:52 AM, Kuppuswamy, Sathyanarayanan wrote: >>> Why does this need to use the page allocator directly? > ^^ You didn't address this question. The address needs to be naturally aligned, and I'm not sure all slab allocators guarantee 64 byte alignment. So using the page allocator seems to be safer. I guess a comment would be good. -Andi