From: John Garry <john.garry@huawei.com>
To: Yang Li <yang.lee@linux.alibaba.com>, <martin.petersen@oracle.com>
Cc: <jejb@linux.ibm.com>, <lduncan@suse.com>, <cleech@redhat.com>,
<open-iscsi@googlegroups.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: iscsi: Switch to using the new API kobj_to_dev()
Date: Mon, 22 Feb 2021 08:30:57 +0000 [thread overview]
Message-ID: <4fa2baa0-8727-9e72-eb42-db773401b8a1@huawei.com> (raw)
In-Reply-To: <1613978804-4846-1-git-send-email-yang.lee@linux.alibaba.com>
On 22/02/2021 07:26, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/scsi/scsi_transport_iscsi.c:436:60-61: WARNING opportunity for
> kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:1128:60-61: WARNING opportunity
> for kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:4043:61-62: WARNING opportunity
> for kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:4312:61-62: WARNING opportunity
> for kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:4456:61-62: WARNING opportunity
> for kobj_to_dev()
that API is not new, so please in future stop writing that. And 'new' is
a time-dependent term, and not appropriate to use anyway.
Thanks,
John
>
> Reported-by: Abaci Robot<abaci@linux.alibaba.com>
> Signed-off-by: Yang Li<yang.lee@linux.alibaba.com>
next prev parent reply other threads:[~2021-02-22 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 7:26 [PATCH] scsi: iscsi: Switch to using the new API kobj_to_dev() Yang Li
2021-02-22 8:30 ` John Garry [this message]
2021-03-02 9:40 Jiapeng Chong
2021-03-08 3:34 Jiapeng Chong
2021-03-08 4:27 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fa2baa0-8727-9e72-eb42-db773401b8a1@huawei.com \
--to=john.garry@huawei.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=open-iscsi@googlegroups.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.