All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: "Lee, Kah Jing" <kah.jing.lee@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Bacrau, Radu" <radu.bacrau@intel.com>,
	"Ang, Tien Sung" <tien.sung.ang@intel.com>
Subject: Re: [PATCH v3 2/2] firmware: stratix10-rsu: query spt addresses
Date: Mon, 24 Jul 2023 09:39:58 -0500	[thread overview]
Message-ID: <4faac72e-3ab8-6a07-dad0-7be8840da7c4@kernel.org> (raw)
In-Reply-To: <PH0PR11MB56738D1373C7B2FEA7D947A9CB3FA@PH0PR11MB5673.namprd11.prod.outlook.com>



On 7/20/23 21:34, Lee, Kah Jing wrote:
> Hi Dinh,
> 
> Any feedback on this patch ?
> 

Please fix these checkpatch warnings:

CHECK: Alignment should match open parenthesis
#64: FILE: drivers/firmware/stratix10-rsu.c:275:
+static void rsu_get_spt_callback(struct stratix10_svc_client *client,
+                                    struct stratix10_svc_cb_data *data)

CHECK: Unnecessary parentheses around 'data->status != BIT(SVC_STATUS_OK)'
#70: FILE: drivers/firmware/stratix10-rsu.c:281:
+       if ((data->status != BIT(SVC_STATUS_OK)) || (*mbox_err) ||
+           (*resp_len != RSU_GET_SPT_RESP_LEN))

CHECK: Alignment should match open parenthesis
#116: FILE: drivers/firmware/stratix10-rsu.c:626:
+static ssize_t spt0_address_show(struct device *dev,
+                                 struct device_attribute *attr, char *buf)

CHECK: Alignment should match open parenthesis
#130: FILE: drivers/firmware/stratix10-rsu.c:640:
+static ssize_t spt1_address_show(struct device *dev,
+                                 struct device_attribute *attr, char *buf)

CHECK: Alignment should match open parenthesis
#190: FILE: drivers/firmware/stratix10-rsu.c:787:
+               ret = rsu_send_msg(priv, COMMAND_MBOX_SEND_CMD,
+                               RSU_GET_SPT_CMD, rsu_get_spt_callback);


  reply	other threads:[~2023-07-24 14:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17  1:49 [PATCH v3 0/2] Query the RSU SPT table offset to determine RSU page size kah.jing.lee
2023-07-17  1:49 ` [PATCH v3 1/2] firmware: stratix10-svc: Generic Mailbox Command kah.jing.lee
2023-07-21  2:33   ` Lee, Kah Jing
2023-07-17  1:50 ` [PATCH v3 2/2] firmware: stratix10-rsu: query spt addresses kah.jing.lee
2023-07-21  2:34   ` Lee, Kah Jing
2023-07-24 14:39     ` Dinh Nguyen [this message]
2023-07-25  8:51       ` Lee, Kah Jing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4faac72e-3ab8-6a07-dad0-7be8840da7c4@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=kah.jing.lee@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=radu.bacrau@intel.com \
    --cc=tien.sung.ang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.