All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Stevens <darren@stevens-zone.net>
To: Scott Wood <oss@buserror.net>
Cc: linuxppc-dev@lists.ozlabs.org, chzigotzky@xenosoft.de
Subject: Re: powerpc/mpc85xx: Add Cyrus P5040 device tree source
Date: Wed, 13 May 2020 23:02:02 +0100 (BST)	[thread overview]
Message-ID: <4fb03d6874.55cfc4a1@auth.smtp.1and1.co.uk> (raw)
In-Reply-To: <d64d04f010598ada6e7ddb3af63fee2592b3ebeb.camel@buserror.net>

Hello Scott

On 08/05/2020, Scott Wood wrote:
> On Thu, 2020-05-07 at 22:30 +0100, Darren Stevens wrote:
>> 
>> +/include/ "p5040si-pre.dtsi"
>> +
>> +/ {
>> +    model = "varisys,CYRUS5040";
>> +    compatible = "varisys,CYRUS";
>
> Is this board 100% compatible with the Cyrus P5020 board, down to every last
> quirk, except for the SoC plugged into it?  If not, they shouldn't have the
> same compatible.  If they are, then couldn't everything in this file but the
> SoC include be moved to a dtsi shared with cyrus_p5020.dts?

It's not 100% compatible, the mdio ports map to different fman ports, but both as are 'corenet generic' boards, I added varisys,CYRUS so it would be detected in corenet_generic.c - support for the 5020 was added by Andy Flemming, I've just tried to copy what he did.

I can add another entry to the table, but do we realy want a separate entry in the table for every supported board rather than using the device tree for similar boards?

It would be nice to get these sorted, the dts files are the last bits to make these fully supported in Linux.

>> +    aliases{
>> +        ethernet0 = &enet4;
>> +        ethernet1 = &enet10;
>> +    };
>
> Space after "aliases"

Opps, will be fixed on next version

Thanks
Darren


  reply	other threads:[~2020-05-13 22:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 21:30 [PATCH 5/5] " Darren Stevens
2020-05-08 20:42 ` Scott Wood
2020-05-13 22:02   ` Darren Stevens [this message]
2020-05-14  6:42     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fb03d6874.55cfc4a1@auth.smtp.1and1.co.uk \
    --to=darren@stevens-zone.net \
    --cc=chzigotzky@xenosoft.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=oss@buserror.net \
    --subject='Re: powerpc/mpc85xx: Add Cyrus P5040 device tree source' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.