From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755133AbeASJuR (ORCPT ); Fri, 19 Jan 2018 04:50:17 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:46884 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbeASJuL (ORCPT ); Fri, 19 Jan 2018 04:50:11 -0500 Subject: Re: [PATCH V5 1/2] nvme-pci: introduce RECONNECTING state to mark initializing procedure To: Max Gurtovoy , keith.busch@intel.com, axboe@fb.com, hch@lst.de, sagi@grimberg.me, james.smart@broadcom.com Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <1516270202-8051-1-git-send-email-jianchao.w.wang@oracle.com> <1516270202-8051-2-git-send-email-jianchao.w.wang@oracle.com> <4be66899-0246-9d03-eb03-76488e7e629e@mellanox.com> From: "jianchao.wang" Message-ID: <4fc5bb3c-9947-35eb-42b5-7d9f5190ee9a@oracle.com> Date: Fri, 19 Jan 2018 17:49:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <4be66899-0246-9d03-eb03-76488e7e629e@mellanox.com> Content-Type: text/plain; charset=windows-1255 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8778 signatures=668654 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801190128 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Max Thanks for your kindly comment and response. On 01/18/2018 06:17 PM, Max Gurtovoy wrote: > > On 1/18/2018 12:10 PM, Jianchao Wang wrote: >> After Sagi's commit (nvme-rdma: fix concurrent reset and reconnect), >> both nvme-fc/rdma have following pattern: >> RESETTING    - quiesce blk-mq queues, teardown and delete queues/ >>                 connections, clear out outstanding IO requests... >> RECONNECTING - establish new queues/connections and some other >>                 initializing things. > > I guess we can call it NVME_CTRL_CONNECTING in later patch (more suitable name for this state now). I think we can change the name in another patchset in which just talk about the more suitable names of the states. :) Thanks Jianchao From mboxrd@z Thu Jan 1 00:00:00 1970 From: jianchao.w.wang@oracle.com (jianchao.wang) Date: Fri, 19 Jan 2018 17:49:31 +0800 Subject: [PATCH V5 1/2] nvme-pci: introduce RECONNECTING state to mark initializing procedure In-Reply-To: <4be66899-0246-9d03-eb03-76488e7e629e@mellanox.com> References: <1516270202-8051-1-git-send-email-jianchao.w.wang@oracle.com> <1516270202-8051-2-git-send-email-jianchao.w.wang@oracle.com> <4be66899-0246-9d03-eb03-76488e7e629e@mellanox.com> Message-ID: <4fc5bb3c-9947-35eb-42b5-7d9f5190ee9a@oracle.com> Hi Max Thanks for your kindly comment and response. On 01/18/2018 06:17 PM, Max Gurtovoy wrote: > > On 1/18/2018 12:10 PM, Jianchao Wang wrote: >> After Sagi's commit (nvme-rdma: fix concurrent reset and reconnect), >> both nvme-fc/rdma have following pattern: >> RESETTING??? - quiesce blk-mq queues, teardown and delete queues/ >> ??????????????? connections, clear out outstanding IO requests... >> RECONNECTING - establish new queues/connections and some other >> ??????????????? initializing things. > > I guess we can call it NVME_CTRL_CONNECTING in later patch (more suitable name for this state now). I think we can change the name in another patchset in which just talk about the more suitable names of the states. :) Thanks Jianchao