From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay-us1.mymailcheap.com (relay-us1.mymailcheap.com [51.81.35.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 704083D65 for ; Tue, 12 Jul 2022 12:06:05 +0000 (UTC) Received: from relay5.mymailcheap.com (relay5.mymailcheap.com [159.100.241.64]) by relay-us1.mymailcheap.com (Postfix) with ESMTPS id 7585C201F7 for ; Tue, 12 Jul 2022 11:58:08 +0000 (UTC) Received: from relay2.mymailcheap.com (relay2.mymailcheap.com [217.182.113.132]) by relay5.mymailcheap.com (Postfix) with ESMTPS id 0649D206D6 for ; Tue, 12 Jul 2022 11:57:59 +0000 (UTC) Received: from filter1.mymailcheap.com (filter1.mymailcheap.com [149.56.130.247]) by relay2.mymailcheap.com (Postfix) with ESMTPS id 01CD73ECD9; Tue, 12 Jul 2022 13:57:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by filter1.mymailcheap.com (Postfix) with ESMTP id 565912A37A; Tue, 12 Jul 2022 11:57:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at filter1.mymailcheap.com Received: from filter1.mymailcheap.com ([127.0.0.1]) by localhost (filter1.mymailcheap.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M5DJ4iuCCZiA; Tue, 12 Jul 2022 11:57:49 +0000 (UTC) Received: from mail20.mymailcheap.com (mail20.mymailcheap.com [51.83.111.147]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by filter1.mymailcheap.com (Postfix) with ESMTPS; Tue, 12 Jul 2022 11:57:49 +0000 (UTC) Received: from edelgard.icenowy.me (unknown [59.41.160.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail20.mymailcheap.com (Postfix) with ESMTPSA id 42D17401CE; Tue, 12 Jul 2022 11:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aosc.io; s=default; t=1657627068; bh=ngIZLTuVH9bK77KIsBS8/RQadlTRO2EmRZFRx9q6pic=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=legNVkDF7C6eeEdfhizFOZu6xr38rsC6eHTxb8EoeQJZFlO5hbwJXtVo71Q6znPff GlcbGVi35E7LcHRbnqH5JEmuc55DX567CisvB0fDIhE8yWpU14AZmtGFt2P1lnyo00 x12JEgzd3uzbPPieUjRTJBMJh/HgFomrIp2e3Kc8= Message-ID: <4fc9873e87c11dce23099a24be34465f09f3a9a4.camel@aosc.io> Subject: Re: [PATCH 06/12] clk: sunxi=ng: add support for R329 CCUs From: Icenowy Zheng To: Samuel Holland Cc: Rob Herring , Chen-Yu Tsai , Jernej Skrabec , Ulf Hansson , Linus Walleij , Andre Przywara , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Date: Tue, 12 Jul 2022 19:57:29 +0800 In-Reply-To: References: <20220422140902.1058101-1-icenowy@aosc.io> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 在 2022-04-23星期六的 21:12 -0500，Samuel Holland写道： > On 4/22/22 10:41 AM, icenowy@outlook.com wrote: > > From: Icenowy Zheng > > > > Allwinner R329 has two CCUs, one in CPUX and another in PRCM. > > > > Add support for them. > > > > Signed-off-by: Icenowy Zheng > > There is a typo in your commit title. = should be -. > > Thanks for updating the driver to use .fw_name and be loadable as a > module. All > of those changes look good. > > There are still some missing clocks here compared to the BSP, and a > couple of > other minor issues. Please see my earlier review: > > https://lore.kernel.org/linux-sunxi/99a74950-fdc0-ecfe-e5f0-ba4a7d8751f0@sholland.org/ > > So far it's been consistent that any settable bits in the CCU > registers actually > do something. So I would expect all of those bits to have an index > reserved in > the binding, even if we do not model them. I want to avoid having to Sorry but I don't think it proper to reserve unclear bits, because we're just allocating the numbers as a random sequence (in fact it's the sequence that it gets implemented). Or consider a structural number scheme, in which a value can be uniquely predicted by its name? > go back and > add gates to the binding out-of-order later, like we are doing for > H6. > > Regards, > Samuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3A3BC43334 for ; Tue, 12 Jul 2022 12:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tUaC+kjPlGuS5ZFq22Q9mQUTj6+i/L2cNw5J044P1C4=; b=sA7AUa57iwR/pN dJO1mQyKFmQD+eG9AtbnMXlv1f+ZD84CUOqYkkMrm1uHT2Eh8Caej0B4EFwtL34JfukRmA8jFeypW gnDhrEXpqcB4fD8UW/H+o2m3JkW5dhRE5/sCb/lLxXYyOtxwqwEXxCOy5hoCkFDZFP18Hb8iipf0g ZaAQs1clUQUJvUZu5CHTwqx9eMtW4h0qa2pL2qwxN8A9ljUxWzCxf6feq8gBU8n3oqbLKZD/LJDQY 2VWnlgvrAlLiT9bUKHgKuJLHKfPgeGBG5vznXMBr+oRvJgWUxouI6x9+8GViL+S4uWyifHpbQF0Oh GVeI+VJ/U9iOy6KGIdPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBEeW-00An9V-H5; Tue, 12 Jul 2022 12:06:08 +0000 Received: from relay-us1.mymailcheap.com ([51.81.35.219]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBEeT-00An7F-23 for linux-arm-kernel@lists.infradead.org; Tue, 12 Jul 2022 12:06:06 +0000 Received: from relay5.mymailcheap.com (relay5.mymailcheap.com [159.100.241.64]) by relay-us1.mymailcheap.com (Postfix) with ESMTPS id 88B23201F8 for ; Tue, 12 Jul 2022 11:58:30 +0000 (UTC) Received: from relay2.mymailcheap.com (relay2.mymailcheap.com [217.182.113.132]) by relay5.mymailcheap.com (Postfix) with ESMTPS id E2987206D3 for ; Tue, 12 Jul 2022 11:58:12 +0000 (UTC) Received: from filter1.mymailcheap.com (filter1.mymailcheap.com [149.56.130.247]) by relay2.mymailcheap.com (Postfix) with ESMTPS id 01CD73ECD9; Tue, 12 Jul 2022 13:57:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by filter1.mymailcheap.com (Postfix) with ESMTP id 565912A37A; Tue, 12 Jul 2022 11:57:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at filter1.mymailcheap.com Received: from filter1.mymailcheap.com ([127.0.0.1]) by localhost (filter1.mymailcheap.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M5DJ4iuCCZiA; Tue, 12 Jul 2022 11:57:49 +0000 (UTC) Received: from mail20.mymailcheap.com (mail20.mymailcheap.com [51.83.111.147]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by filter1.mymailcheap.com (Postfix) with ESMTPS; Tue, 12 Jul 2022 11:57:49 +0000 (UTC) Received: from edelgard.icenowy.me (unknown [59.41.160.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail20.mymailcheap.com (Postfix) with ESMTPSA id 42D17401CE; Tue, 12 Jul 2022 11:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aosc.io; s=default; t=1657627068; bh=ngIZLTuVH9bK77KIsBS8/RQadlTRO2EmRZFRx9q6pic=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=legNVkDF7C6eeEdfhizFOZu6xr38rsC6eHTxb8EoeQJZFlO5hbwJXtVo71Q6znPff GlcbGVi35E7LcHRbnqH5JEmuc55DX567CisvB0fDIhE8yWpU14AZmtGFt2P1lnyo00 x12JEgzd3uzbPPieUjRTJBMJh/HgFomrIp2e3Kc8= Message-ID: <4fc9873e87c11dce23099a24be34465f09f3a9a4.camel@aosc.io> Subject: Re: [PATCH 06/12] clk: sunxi=ng: add support for R329 CCUs From: Icenowy Zheng To: Samuel Holland Cc: Rob Herring , Chen-Yu Tsai , Jernej Skrabec , Ulf Hansson , Linus Walleij , Andre Przywara , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Date: Tue, 12 Jul 2022 19:57:29 +0800 In-Reply-To: References: <20220422140902.1058101-1-icenowy@aosc.io> User-Agent: Evolution 3.40.4 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220712_050605_184290_E01F821F X-CRM114-Status: GOOD ( 24.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 5ZyoIDIwMjItMDQtMjPmmJ/mnJ/lha3nmoQgMjE6MTIgLTA1MDDvvIxTYW11ZWwgSG9sbGFuZOWG memBk++8mgo+IE9uIDQvMjIvMjIgMTA6NDEgQU0sIGljZW5vd3lAb3V0bG9vay5jb23CoHdyb3Rl Ogo+ID4gRnJvbTogSWNlbm93eSBaaGVuZyA8aWNlbm93eUBhb3NjLmlvPgo+ID4gCj4gPiBBbGx3 aW5uZXIgUjMyOSBoYXMgdHdvIENDVXMsIG9uZSBpbiBDUFVYIGFuZCBhbm90aGVyIGluIFBSQ00u Cj4gPiAKPiA+IEFkZCBzdXBwb3J0IGZvciB0aGVtLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBJ Y2Vub3d5IFpoZW5nIDxpY2Vub3d5QGFvc2MuaW8+Cj4gCj4gVGhlcmUgaXMgYSB0eXBvIGluIHlv dXIgY29tbWl0IHRpdGxlLiA9IHNob3VsZCBiZSAtLgo+IAo+IFRoYW5rcyBmb3IgdXBkYXRpbmcg dGhlIGRyaXZlciB0byB1c2UgLmZ3X25hbWUgYW5kIGJlIGxvYWRhYmxlIGFzIGEKPiBtb2R1bGUu IEFsbAo+IG9mIHRob3NlIGNoYW5nZXMgbG9vayBnb29kLgo+IAo+IFRoZXJlIGFyZSBzdGlsbCBz b21lIG1pc3NpbmcgY2xvY2tzIGhlcmUgY29tcGFyZWQgdG8gdGhlIEJTUCwgYW5kIGEKPiBjb3Vw bGUgb2YKPiBvdGhlciBtaW5vciBpc3N1ZXMuIFBsZWFzZSBzZWUgbXkgZWFybGllciByZXZpZXc6 Cj4gCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtc3VueGkvOTlhNzQ5NTAtZmRjMC1l Y2ZlLWU1ZjAtYmE0YTdkODc1MWYwQHNob2xsYW5kLm9yZy8KPiAKPiBTbyBmYXIgaXQncyBiZWVu IGNvbnNpc3RlbnQgdGhhdCBhbnkgc2V0dGFibGUgYml0cyBpbiB0aGUgQ0NVCj4gcmVnaXN0ZXJz IGFjdHVhbGx5Cj4gZG8gc29tZXRoaW5nLiBTbyBJIHdvdWxkIGV4cGVjdCBhbGwgb2YgdGhvc2Ug Yml0cyB0byBoYXZlIGFuIGluZGV4Cj4gcmVzZXJ2ZWQgaW4KPiB0aGUgYmluZGluZywgZXZlbiBp ZiB3ZSBkbyBub3QgbW9kZWwgdGhlbS4gSSB3YW50IHRvIGF2b2lkIGhhdmluZyB0bwoKU29ycnkg YnV0IEkgZG9uJ3QgdGhpbmsgaXQgcHJvcGVyIHRvIHJlc2VydmUgdW5jbGVhciBiaXRzLCBiZWNh dXNlCndlJ3JlIGp1c3QgYWxsb2NhdGluZyB0aGUgbnVtYmVycyBhcyBhIHJhbmRvbSBzZXF1ZW5j ZSAoaW4gZmFjdCBpdCdzCnRoZSBzZXF1ZW5jZSB0aGF0IGl0IGdldHMgaW1wbGVtZW50ZWQpLgoK T3IgY29uc2lkZXIgYSBzdHJ1Y3R1cmFsIG51bWJlciBzY2hlbWUsIGluIHdoaWNoIGEgdmFsdWUg Y2FuIGJlCnVuaXF1ZWx5IHByZWRpY3RlZCBieSBpdHMgbmFtZT8KCj4gZ28gYmFjayBhbmQKPiBh ZGQgZ2F0ZXMgdG8gdGhlIGJpbmRpbmcgb3V0LW9mLW9yZGVyIGxhdGVyLCBsaWtlIHdlIGFyZSBk b2luZyBmb3IKPiBINi4KPiAKPiBSZWdhcmRzLAo+IFNhbXVlbAoKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==